From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28EB0C388F9 for ; Tue, 27 Oct 2020 19:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB2B321D7B for ; Tue, 27 Oct 2020 19:52:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504153AbgJ0TwE (ORCPT ); Tue, 27 Oct 2020 15:52:04 -0400 Received: from smtprelay0135.hostedemail.com ([216.40.44.135]:60186 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2503972AbgJ0TwC (ORCPT ); Tue, 27 Oct 2020 15:52:02 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id A213063D; Tue, 27 Oct 2020 19:52:00 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: soap06_23053322727e X-Filterd-Recvd-Size: 2922 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Tue, 27 Oct 2020 19:51:58 +0000 (UTC) Message-ID: Subject: Re: Subject: [RFC] clang tooling cleanups From: Joe Perches To: Tom Rix , Nick Desaulniers , Stephen Rothwell Cc: LKML , clang-built-linux , linux-toolchains@vger.kernel.org, Julia.Lawall@lip6.fr, Linus Torvalds , Masahiro Yamada , Nathan Huckleberry Date: Tue, 27 Oct 2020 12:51:57 -0700 In-Reply-To: <8abd1e5a-511a-e4f6-6f2c-a045d33fa2aa@redhat.com> References: <20201027164255.1573301-1-trix@redhat.com> <8abd1e5a-511a-e4f6-6f2c-a045d33fa2aa@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (Adding Stephen Rothwell) On Tue, 2020-10-27 at 12:33 -0700, Tom Rix wrote: > On 10/27/20 11:42 AM, Nick Desaulniers wrote: > > (cutting down the CC list to something more intimate) [] > I am interested in treewide fixes. As am I, but here the definition of fixes is undefined though. Whitespace / style changes and other bits that don't change generated object code aren't considered fixes by many maintainers. > Cleaning them up (maybe me not doing all the patches) and keeping them clean. > > The clang -Wextra-semi-stmt -fixit will fix all 10,000 problems I rather doubt there are 10K extra semicolons in the kernel source tree. Is there a proposed diff/patch posted somewhere? > This clang tidy fixer will fix only the 100 problems that are 'switch() {};' > > When doing a treewide cleanup, batching a bunch of fixes that are the same problem and fix > is much easier on everyone to review and more likely to be accepted. That depends on the definition of batching. If individual patches are sent to multiple maintainers, the acceptance / apply rate seems always < 50% and some are rejected outright by various maintainers as "unnecessary churn". Single treewide patches are generally not applied unless by Linus. The trivial tree isn't widely used for this. Perhaps a 'scripted' git tree could be established that is integrated into -next that would allow these automated patches to be better vetted and increase the acceptance rate of these automated patches. > Long term, a c/i system would keep the tree clean by running the switch-semi checker/fixer. > And we can all move onto the next problem. Good idea... I hope a scripted patches mechanism will be established.