All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Gong <richard.gong@linux.intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: trix@redhat.com, gregkh@linuxfoundation.org,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	dinguyen@kernel.org, sridhar.rajagopal@intel.com,
	Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv3 4/6] fpga: of-fpga-region: add authenticate-fpga-config property
Date: Tue, 26 Jan 2021 08:03:40 -0600	[thread overview]
Message-ID: <a4c874a4-fd7b-d0c3-fde0-783e52055c7b@linux.intel.com> (raw)
In-Reply-To: <YA+kQ2unznKRqp8p@epycbox.lan>


Hi Moritz,

On 1/25/21 11:10 PM, Moritz Fischer wrote:
> On Mon, Jan 25, 2021 at 02:56:26PM -0600, richard.gong@linux.intel.com wrote:
>> From: Richard Gong <richard.gong@intel.com>
>>
>> Add authenticate-fpga-config property to support FPGA bitstream
>> authentication, which makes sure a signed bitstream has valid signatures.
>>
>> Signed-off-by: Richard Gong <richard.gong@intel.com>
>> ---
>> v3: no change
>> v2: changed in alphabetical order
>> ---
>>   drivers/fpga/of-fpga-region.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
>> index e405309..3840883 100644
>> --- a/drivers/fpga/of-fpga-region.c
>> +++ b/drivers/fpga/of-fpga-region.c
>> @@ -219,6 +219,9 @@ static struct fpga_image_info *of_fpga_region_parse_ov(
>>   	info->overlay = overlay;
>>   
>>   	/* Read FPGA region properties from the overlay */
>> +	if (of_property_read_bool(overlay, "authenticate-fpga-config"))
>> +		info->flags |= FPGA_MGR_BITSTREM_AUTHENTICATION;
>> +
> Should you check here that no new nodes are being added as you *only*
> authenticate?

Sure, I will add additional checks in next submission.

> 
>>   	if (of_property_read_bool(overlay, "partial-fpga-config"))
>>   		info->flags |= FPGA_MGR_PARTIAL_RECONFIG;
>>   
>> -- 
>> 2.7.4
>>
> 
> Thanks,
> Moritz
> 
Regards,
Richard

  reply	other threads:[~2021-01-26 13:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 20:56 [PATCHv3 0/6] [PATCHv3 0/6] Extend Intel service layer, FPGA manager and region richard.gong
2021-01-25 20:56 ` [PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag richard.gong
2021-01-25 22:56   ` Tom Rix
2021-01-26  2:16     ` Richard Gong
2021-01-27 12:04   ` Greg KH
2021-01-27 13:05     ` Richard Gong
2021-01-27 21:41       ` Moritz Fischer
2021-01-27 23:02         ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 2/6] firmware: stratix10-svc: extend SVC driver to get the firmware version richard.gong
2021-01-26  5:01   ` Moritz Fischer
2021-01-26 13:37     ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 3/6] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag richard.gong
2021-01-26  5:04   ` Moritz Fischer
2021-01-26 13:38     ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 4/6] fpga: of-fpga-region: add authenticate-fpga-config property richard.gong
2021-01-26  5:10   ` Moritz Fischer
2021-01-26 14:03     ` Richard Gong [this message]
2021-01-25 20:56 ` [PATCHv3 5/6] dt-bindings: fpga: " richard.gong
2021-01-26  5:05   ` Moritz Fischer
2021-01-26 13:58     ` Richard Gong
2021-01-25 20:56 ` [PATCHv3 6/6] fpga: stratix10-soc: extend driver for bitstream authentication richard.gong
2021-01-26  5:09   ` Moritz Fischer
2021-01-26 14:00     ` Richard Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4c874a4-fd7b-d0c3-fde0-783e52055c7b@linux.intel.com \
    --to=richard.gong@linux.intel.com \
    --cc=dinguyen@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=richard.gong@intel.com \
    --cc=sridhar.rajagopal@intel.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.