From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA35C433FE for ; Mon, 6 Sep 2021 10:13:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50A6B6101C for ; Mon, 6 Sep 2021 10:13:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241868AbhIFKO1 (ORCPT ); Mon, 6 Sep 2021 06:14:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46844 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241852AbhIFKOZ (ORCPT ); Mon, 6 Sep 2021 06:14:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630923200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6w6LAFexoBEaduWz7q8eyw7xCDoy2E5zTIuRR/QZtqk=; b=Jz93mwJ+QVRQbG5Bd6BeuVzlmfBfB9vWMuLD7TqG6s79a5eaiejaPHdm1ynxAACYtpI8LW NasJnL3Ha3FdXTZQ5vHtYhXMKWCQhHp17KcKxWfvJwNPDSSOPe0Sk+w7P0y3ACMET25KLr yjZJboC4VR2UTMtlkssU+L0R466MpJA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-TQgVxGzWNe6M84K0F4ycAg-1; Mon, 06 Sep 2021 06:13:19 -0400 X-MC-Unique: TQgVxGzWNe6M84K0F4ycAg-1 Received: by mail-wm1-f69.google.com with SMTP id k5-20020a7bc3050000b02901e081f69d80so2159832wmj.8 for ; Mon, 06 Sep 2021 03:13:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6w6LAFexoBEaduWz7q8eyw7xCDoy2E5zTIuRR/QZtqk=; b=YDpsUyMR4cTojp5Y8R2tp6PEAEm+583ASFtue3poGtjxxJW9WI4Q0Espp4tLR56HrJ Ge1B+Sj6zHTYtctqdAUe7cpzD9QcoMg8U/1cYwhqRg9UqH0bkd90rEy/azFuJrWLOPwm kV+aMBgHhkA9/zbZRL6vivnxZ++2WtwQZj7u/GLaz+Z5BNOX860eihWR2cbg9eNPhYt7 g9qrfOKpE4lzNU2hG3MZZSD/kFtNbgG/BdU/2fxuMFz8u+8SAk7gPKx7TOl0Jzjgh4w+ 1ecVFuRBoAhR/is6qc0LMb/SFKpxtTbPbfH7fVoxHfiS+8qqZfeS5W0+sskf/1BkMN1P QTNw== X-Gm-Message-State: AOAM5302xTKdc5mZmBl1UW5S1Rryi9cdRvrMdbQGvqqod4Mzv7yXhY/7 oly2nGkxluzzIGO1xRF9IQM94VE9Uzer/7gHXyNyzrG6Eg7fclqCDx2WAigsZ6JiOPco3HmT+Ih WAarLVYbwx6hOQNMUN0m/Cbnph6L6LUdU2RfjHc9PWUBw6U+5wAridaXJ4HfU0nFaro0JZCj48o PD X-Received: by 2002:adf:f00f:: with SMTP id j15mr12767455wro.265.1630923198319; Mon, 06 Sep 2021 03:13:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWNKIJirwR0n4MrIYuHA/BoWJh22sJ26zsj+XcsKpsxVGIHDHCEpJzatFFAPC9c5KeqDfNLw== X-Received: by 2002:adf:f00f:: with SMTP id j15mr12767420wro.265.1630923198005; Mon, 06 Sep 2021 03:13:18 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h11sm8796814wrx.9.2021.09.06.03.13.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 03:13:17 -0700 (PDT) Subject: Re: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page To: Jia He , Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210830145336.27183-1-justin.he@arm.com> From: Paolo Bonzini Message-ID: Date: Mon, 6 Sep 2021 12:13:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210830145336.27183-1-justin.he@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/08/21 16:53, Jia He wrote: > After reverting and restoring the fast tlb invalidation patch series, > the mmio_cached is not removed. Hence a unused field is left in > kvm_mmu_page. > > Cc: Sean Christopherson > Signed-off-by: Jia He > --- > arch/x86/kvm/mmu/mmu_internal.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h > index 35567293c1fd..3e6f21c1871a 100644 > --- a/arch/x86/kvm/mmu/mmu_internal.h > +++ b/arch/x86/kvm/mmu/mmu_internal.h > @@ -37,7 +37,6 @@ struct kvm_mmu_page { > > bool unsync; > u8 mmu_valid_gen; > - bool mmio_cached; > bool lpage_disallowed; /* Can't be replaced by an equiv large page */ > > /* > Queued, thanks. Paolo