All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: ice: ptp: fix compilation warning if PTP_1588_CLOCK is disabled
@ 2021-06-15 14:14 Lorenzo Bianconi
  2021-06-15 19:10 ` Keller, Jacob E
  0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2021-06-15 14:14 UTC (permalink / raw)
  To: netdev; +Cc: lorenzo.bianconi, jacob.e.keller

Fix the following compilation warning if PTP_1588_CLOCK is not enabled

drivers/net/ethernet/intel/ice/ice_ptp.h:149:1:
   error: return type defaults to ‘int’ [-Werror=return-type]
   ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)

Fixes: ea9b847cda647 ("ice: enable transmit timestamps for E810 devices")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/ethernet/intel/ice/ice_ptp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h b/drivers/net/ethernet/intel/ice/ice_ptp.h
index 41e14f98f0e6..d01507eba036 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp.h
+++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
@@ -145,7 +145,7 @@ static inline int ice_get_ptp_clock_index(struct ice_pf *pf)
 	return -1;
 }
 
-static inline
+static inline s8
 ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
 {
 	return -1;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [PATCH net-next] net: ice: ptp: fix compilation warning if PTP_1588_CLOCK is disabled
  2021-06-15 14:14 [PATCH net-next] net: ice: ptp: fix compilation warning if PTP_1588_CLOCK is disabled Lorenzo Bianconi
@ 2021-06-15 19:10 ` Keller, Jacob E
  0 siblings, 0 replies; 2+ messages in thread
From: Keller, Jacob E @ 2021-06-15 19:10 UTC (permalink / raw)
  To: Lorenzo Bianconi, netdev; +Cc: lorenzo.bianconi



> -----Original Message-----
> From: Lorenzo Bianconi <lorenzo@kernel.org>
> Sent: Tuesday, June 15, 2021 7:14 AM
> To: netdev@vger.kernel.org
> Cc: lorenzo.bianconi@redhat.com; Keller, Jacob E <jacob.e.keller@intel.com>
> Subject: [PATCH net-next] net: ice: ptp: fix compilation warning if
> PTP_1588_CLOCK is disabled
> 
> Fix the following compilation warning if PTP_1588_CLOCK is not enabled
> 
> drivers/net/ethernet/intel/ice/ice_ptp.h:149:1:
>    error: return type defaults to ‘int’ [-Werror=return-type]
>    ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
> 
> Fixes: ea9b847cda647 ("ice: enable transmit timestamps for E810 devices")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>


Hah. Thanks. This is obviously correct.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> ---
>  drivers/net/ethernet/intel/ice/ice_ptp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h
> b/drivers/net/ethernet/intel/ice/ice_ptp.h
> index 41e14f98f0e6..d01507eba036 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
> @@ -145,7 +145,7 @@ static inline int ice_get_ptp_clock_index(struct ice_pf *pf)
>  	return -1;
>  }
> 
> -static inline
> +static inline s8
>  ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
>  {
>  	return -1;
> --
> 2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-15 19:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 14:14 [PATCH net-next] net: ice: ptp: fix compilation warning if PTP_1588_CLOCK is disabled Lorenzo Bianconi
2021-06-15 19:10 ` Keller, Jacob E

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.