From: "Cédric Le Goater" <clg@kaod.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-block@nongnu.org, Andrew Jeffery <andrew@aj.id.au>,
Alistair Francis <alistair@alistair23.me>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
qemu-arm@nongnu.org, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 1/3] m25p80: Convert to support tracing
Date: Wed, 5 Feb 2020 18:10:44 +0100 [thread overview]
Message-ID: <a4ee58d2-0642-b4f4-2756-84d9f08b08a9@kaod.org> (raw)
In-Reply-To: <20200205163520.GE25403@roeck-us.net>
On 2/5/20 5:35 PM, Guenter Roeck wrote:
> On Wed, Feb 05, 2020 at 11:05:04AM +0100, Cédric Le Goater wrote:
>> On 2/3/20 7:09 PM, Guenter Roeck wrote:
>>> While at it, add some trace messages to help debug problems
>>> seen when running the latest Linux kernel.
>>
>> In case you resend, It would be nice to printout a flash id in the tracing
>> else I have a patch for it on top of yours. It helped me track a squashfs
>> corruption on the Aspeed witherspoon-bmc machine which we were after since
>> 2017 or so. It seems to be a kernel bug.
>>
>
> I'll send a new version to split patch 2. Not sure I understand what you mean
> with the above. If you send me your patch I'll be happy to merge it into mine,
> otherwise we can just keep it as follow-ip patch.
Here is the idea :
https://github.com/legoater/qemu/commit/a07727e9cfc8447ea18249ff68a561f7e8883584
You can merge and maybe extend to all traces.
In the issue we had, two CS could be selected at the same time
and the SPI transfers were getting mixed. Printing out which
CS is doing what is interesting for debug.
Thanks,
C.
next prev parent reply other threads:[~2020-02-05 17:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 18:09 [PATCH 1/3] m25p80: Convert to support tracing Guenter Roeck
2020-02-03 18:09 ` [PATCH 2/3] m25p80: Improve command handling for Jedec and unsupported commands Guenter Roeck
2020-02-04 8:53 ` Cédric Le Goater
2020-02-04 12:27 ` Philippe Mathieu-Daudé
2020-02-04 14:28 ` Guenter Roeck
2020-02-05 10:08 ` Cédric Le Goater
2020-02-05 17:43 ` Guenter Roeck
2020-02-06 7:04 ` Joel Stanley
2020-02-06 14:26 ` Guenter Roeck
2020-02-04 12:13 ` Philippe Mathieu-Daudé
2020-02-03 18:09 ` [PATCH 3/3] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command Guenter Roeck
2020-02-04 7:45 ` Cédric Le Goater
2020-02-04 14:19 ` Guenter Roeck
2020-02-18 11:38 ` Francisco Iglesias
2020-02-03 18:44 ` [PATCH 1/3] m25p80: Convert to support tracing Alistair Francis
2020-02-04 7:16 ` Cédric Le Goater
2020-02-04 14:18 ` Guenter Roeck
2020-02-04 12:08 ` Philippe Mathieu-Daudé
2020-02-05 10:05 ` Cédric Le Goater
2020-02-05 16:35 ` Guenter Roeck
2020-02-05 17:10 ` Cédric Le Goater [this message]
2020-02-05 18:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4ee58d2-0642-b4f4-2756-84d9f08b08a9@kaod.org \
--to=clg@kaod.org \
--cc=alistair@alistair23.me \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=kwolf@redhat.com \
--cc=linux@roeck-us.net \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.