From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0601.outbound.protection.outlook.com [IPv6:2a01:111:f400:fc10::1:601]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0ABF81A1E0A for ; Tue, 21 Jun 2016 23:20:46 -0700 (PDT) Subject: Re: [PATCH v4 3/5] um: track 'parent' device in a local variable References: <146654196111.34694.7735150373057824399.stgit@dwillia2-desk3.amr.corp.intel.com> <146654197737.34694.9376917839573236856.stgit@dwillia2-desk3.amr.corp.intel.com> From: Bart Van Assche Message-ID: Date: Wed, 22 Jun 2016 08:20:04 +0200 MIME-Version: 1.0 In-Reply-To: <146654197737.34694.9376917839573236856.stgit@dwillia2-desk3.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams , "axboe@fb.com" Cc: "linux-nvdimm@lists.01.org" , Richard Weinberger , Jeff Dike , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@lst.de" List-ID: On 06/21/2016 10:47 PM, Dan Williams wrote: > In preparation for the removal of 'driverfs_dev' from 'struct gendisk' > use a local variable to track the parented vs un-parented case in > ubd_disk_register(). > > Cc: Jeff Dike > Cc: Richard Weinberger > Reported-by: Bart Van Assche > Signed-off-by: Dan Williams > --- > arch/um/drivers/ubd_kern.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c > index ef6b4d960bad..8ec7b4112f55 100644 > --- a/arch/um/drivers/ubd_kern.c > +++ b/arch/um/drivers/ubd_kern.c > @@ -801,6 +801,7 @@ static void ubd_device_release(struct device *dev) > static int ubd_disk_register(int major, u64 size, int unit, > struct gendisk **disk_out) > { > + struct device *dev = NULL; > struct gendisk *disk; > > disk = alloc_disk(1 << UBD_SHIFT); > @@ -823,12 +824,12 @@ static int ubd_disk_register(int major, u64 size, int unit, > ubd_devs[unit].pdev.dev.release = ubd_device_release; > dev_set_drvdata(&ubd_devs[unit].pdev.dev, &ubd_devs[unit]); > platform_device_register(&ubd_devs[unit].pdev); > - disk->driverfs_dev = &ubd_devs[unit].pdev.dev; > + dev = &ubd_devs[unit].pdev.dev; > } > > disk->private_data = &ubd_devs[unit]; > disk->queue = ubd_devs[unit].queue; > - add_disk(disk); > + device_add_disk(dev, disk); > > *disk_out = disk; > return 0; Hello Dan, The Reported-by tag is intended to give people credit who find bugs in the upstream kernel. What I reported was a bug not in the upstream kernel but in a previous version of this patch series so I think the "Reported-by" tag can be left out from this patch. Additionally, please consider to use a more descriptive name instead of "dev", e.g. "parent". Thanks, Bart. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bl2on0082.outbound.protection.outlook.com ([65.55.169.82]:2320 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751782AbcFVGUQ (ORCPT ); Wed, 22 Jun 2016 02:20:16 -0400 Subject: Re: [PATCH v4 3/5] um: track 'parent' device in a local variable To: Dan Williams , "axboe@fb.com" References: <146654196111.34694.7735150373057824399.stgit@dwillia2-desk3.amr.corp.intel.com> <146654197737.34694.9376917839573236856.stgit@dwillia2-desk3.amr.corp.intel.com> CC: "linux-nvdimm@lists.01.org" , "Richard Weinberger" , Jeff Dike , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@lst.de" From: Bart Van Assche Message-ID: Date: Wed, 22 Jun 2016 08:20:04 +0200 MIME-Version: 1.0 In-Reply-To: <146654197737.34694.9376917839573236856.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 06/21/2016 10:47 PM, Dan Williams wrote: > In preparation for the removal of 'driverfs_dev' from 'struct gendisk' > use a local variable to track the parented vs un-parented case in > ubd_disk_register(). > > Cc: Jeff Dike > Cc: Richard Weinberger > Reported-by: Bart Van Assche > Signed-off-by: Dan Williams > --- > arch/um/drivers/ubd_kern.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c > index ef6b4d960bad..8ec7b4112f55 100644 > --- a/arch/um/drivers/ubd_kern.c > +++ b/arch/um/drivers/ubd_kern.c > @@ -801,6 +801,7 @@ static void ubd_device_release(struct device *dev) > static int ubd_disk_register(int major, u64 size, int unit, > struct gendisk **disk_out) > { > + struct device *dev = NULL; > struct gendisk *disk; > > disk = alloc_disk(1 << UBD_SHIFT); > @@ -823,12 +824,12 @@ static int ubd_disk_register(int major, u64 size, int unit, > ubd_devs[unit].pdev.dev.release = ubd_device_release; > dev_set_drvdata(&ubd_devs[unit].pdev.dev, &ubd_devs[unit]); > platform_device_register(&ubd_devs[unit].pdev); > - disk->driverfs_dev = &ubd_devs[unit].pdev.dev; > + dev = &ubd_devs[unit].pdev.dev; > } > > disk->private_data = &ubd_devs[unit]; > disk->queue = ubd_devs[unit].queue; > - add_disk(disk); > + device_add_disk(dev, disk); > > *disk_out = disk; > return 0; Hello Dan, The Reported-by tag is intended to give people credit who find bugs in the upstream kernel. What I reported was a bug not in the upstream kernel but in a previous version of this patch series so I think the "Reported-by" tag can be left out from this patch. Additionally, please consider to use a more descriptive name instead of "dev", e.g. "parent". Thanks, Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbcFVGUV (ORCPT ); Wed, 22 Jun 2016 02:20:21 -0400 Received: from mail-bl2on0082.outbound.protection.outlook.com ([65.55.169.82]:2320 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751782AbcFVGUQ (ORCPT ); Wed, 22 Jun 2016 02:20:16 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; fb.com; dkim=none (message not signed) header.d=none;fb.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-353ff70000000bcf-ba-576a2cdebef9 Subject: Re: [PATCH v4 3/5] um: track 'parent' device in a local variable To: Dan Williams , "axboe@fb.com" References: <146654196111.34694.7735150373057824399.stgit@dwillia2-desk3.amr.corp.intel.com> <146654197737.34694.9376917839573236856.stgit@dwillia2-desk3.amr.corp.intel.com> CC: "linux-nvdimm@lists.01.org" , "Richard Weinberger" , Jeff Dike , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@lst.de" From: Bart Van Assche Message-ID: Date: Wed, 22 Jun 2016 08:20:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <146654197737.34694.9376917839573236856.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsWyRoxnke4jnaxwgxcnWC3+7znGZjF96gVG i5WrjzJZrN/zkN1i7y1ti8u75rBZNE+8zW4xeecbRgcOj1//LrN7TGx+x+6xeM9LJo/u2f9Y PHbfbGDzuDmv0OPzJrkA9igum5TUnMyy1CJ9uwSujNNr5Qsm8lf0L1rK3MC4mqeLkZNDQsBE ovHhWvYuRi4OIYG5TBL3n/QxQTg7GCXunupghql6vHE3M0RiKaPEx1/b2UASwgKeEo927mYF sUUEvCSmtV+HKlrPKDF12mwwh1lgHpPE7QtTGEGq2ASMJL69n8kCYvMK2EnsOP8ArJtFQFVi +cbjYHFRgQiJ3l9LoGoEJU7OfAJmcwrESpz7vA/MZhawkJg5/zwjhC0vsf3tHLBlEgJXWSX6 v25gB0kICahLnFwyn2kCo/AsJLNmIemfhaR/ASPzKkax3Myc4tz01AJDU73ixLyUzOJsveT8 3E2MkIjK3MF494n3IUYBDkYlHt6InsxwIdbEsuLK3EOMEhzMSiK83tpZ4UK8KYmVValF+fFF pTmpxYcYpTlYlMR53e59CRMSSE8sSc1OTS1ILYLJMnFwSjUwmhvN3n5ynxOPxgYV7m8bVTf2 ZzzRaFOIYWJ1jOoJe9f4/HtjQq6a6ZfCiRelDnwsb/dMSN1scf3yp/Sd0iIrjAScsksnJJpv qbrGs12ubAbTyjrbG78VY4s82Ds7K9gL5daetRdJvbr0Cavv1UpDJb5Pvo5R+ce/MPtfbnX1 s//Yd+RjUIgSS3FGoqEWc1FxIgDWQ89CpAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjluLIzCtJLcpLzFFi42Lh2siRoiuhlxVucPedkMX/PcfYLKZPvcBo sXL1USaL9XseslvsvaVtcXnXHDaL5om32S0m73zD6MDh8evfZXaPic3v2D0W73nJ5NE9+x+L x+6bDWweN+cVenzeJBfAHsVlk5Kak1mWWqRvl8CVcXqtfMFE/or+RUuZGxhX83QxcnJICJhI PN64m7mLkYtDSGAxo0Tzz0WsIAlhAU+JRzt3g9kiAl4S09qvQxWtZ5SYOm02mMMsMI9JYv6l D8wgVWwCRhLf3s9kAbF5Bewkdpx/ANbNIqAqsXzjcbC4qECERO+vJVA1ghInZz4BszkFYiXO fd4HZjMLmEnM2/yQGcKWl9j+dg7zBEa+WUhaZiEpm4WkbAEj8ypGsdzMnOLc9MwCQ0O94sS8 lMzibL3k/NxNjOCQ5ozcwfh0ovkhRiYOTqkGxvzMK+ldCVV7e1MvmflO3WWuq7F3evGkq/6L XJj+TSk6K7l3Y9oltb5anxmbbq0MsdA7tPasgdDr73vP3054KdJ853bkZB9N1/6f+WcUHlzq nnF8x3/LRfe4DXIbXmrvcO+M5fmV6Jl3+I+7uvyxBuPuWV4fZNgSEz40fjros+i60gUv30pB GSWW4oxEQy3mouJEALx9mggZAgAA X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(24454002)(377454003)(199003)(189002)(31686004)(31696002)(189998001)(65956001)(53416004)(65806001)(47776003)(33646002)(77096005)(230700001)(2501003)(50986999)(7846002)(356003)(19580405001)(19580395003)(76176999)(54356999)(5003600100003)(2270400002)(36756003)(7696003)(68736007)(69596002)(83506001)(8936002)(23676002)(50466002)(4326007)(2906002)(97736004)(4001350100001)(586003)(86362001)(5001770100001)(92566002)(64126003)(87936001)(6806005)(81166006)(81156014)(8676002)(2950100001)(106466001)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB1771;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD005;1:ehAVLYs5wf6a8aMXKnzYmZcsIC9EG613xNYh8DDHDHhbyAAJTgta4+NdMGg+1WqRz1bt/vxK/pO++DwPz4ujDawuLPi0aNNInGnmjg+pZM6M6giG1nfpseTcSsytlQCC98YItzYiYyIHWXBS+OXtf3mmWAUESCQxTboLI9ESXHMaNpsD9+QIKRYuoiI12uV817SBJsCeqMEPzaTWZEPi+V7udRPB2VRLCu/PPtv0sC2xqre1kXuiA94VdBzYRJJ40Vu/GpAW+TxobF4ZUmstov0LXyxtybix/76Z6ywnJA8aFz9qxejd9hZS+fyhd/v6wiQMBvprncdCr/SBrk2GB9PtTWP/b3PpcadQHLNlhKORj55Qp0W1dkZQOGPR53SRv2Z9NUKfUj0thi/RwVm4u2spmX/pxx28FhGbVjsTCjKnB8qDrlkRz5uUjkrg8+VR5fEXkNNc2U8jbb9AJA9DU/OkMqBn/Ny9N/kg0DidCXPjMSFQhr3Z4GKJu2Ds3/nzknq5aBzp42CP4QqLT3iLCg== X-MS-Office365-Filtering-Correlation-Id: 00a957d8-c587-43b1-5fc4-08d39a654517 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1771;2:G6G14WI2BvlulUVbjRMfqCsRNcXxoqokAtt34FRX6lvAaXjR++XIjvPHKDiWxk1Eohs3BDJ8+tPm917i+dC+RYwxaCRRdxH9MdZpIv1XXH2FuvsiRzxEujbmXs6mR+CgkkgIRgHP4a5xOBvpdSYS/zeuXqRtttZjVxxNqEi3BfBZc+EytN23E5bQ0RJ2iSHL;3:7JtSopJti9GNfq7TbE9NHjq3r/jrX5tMP9hBlctXYmeok/ZeZVVuGL6cnCTozjiP9wU6gIcFxQBUuJmphF4gsTg9VsiM78nhO6vlHndwRhqlju+WP6QB6OgCGskN3vQoblTthGaVowis+CWtvZ53WpjRTxLpJ4wnXJt4czVz8M1B2wxI20qe/JwD/Up5gYJQPIaAa+MyJ1IxTx40OLPP31egAM+BXkDdHzohcEjHWk2OBfBi9OYrJ3etq4xGQIyPjrF0X9xOrz4sDlvW96wrvg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1PR0201MB1771; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1771;25:6Lr+ltBxig40p724iTckp/8p36j9OS7zkdEBrtDcWeYDEv19pGCqhioNMZZyyuD8qpgy+dQGHztPDRzDmhjc5Nik+DDYMAugXcqkgH5b2chn7DiSKFs28EdhC1yHfSjxfIDXxIppPD+ZkP8roSqDUsGw9XmZwfdrQKkC5NyUCawc8tMQH8GWPg+7HWoBfA6XMCcMitlb6bweN9GyQm+vR67OZAXslanjniEFI6m8CDlT1hLmSm3ry/Y1zDpMOYEXLI2xnJpvzxjSF/qDxiXJJgAsKQzU4y83nJ2SYlllJsKKg0Dkq2Te5cosEjBgLGPvlxsXyJPzzR2y5b0GS/4xlACwPtBViIK0NgB6HWZ3nP5j8OgQtuTHYJBnDzbJ4sbdz+thkIlAVtivKxk1sf2WT8OTmheuE9K2Y5NTXR1C9To+cZg62hEyUuMm+E55CFwjMzpoXCEKUKrm8uL0E4DHuULYAsEPrF3pF2HXME0j8I3qvzemWMp1qRL/g23It8vvkJI7qCnVZRWDr58o0PEgy/TMYl+VHOlwRYcnkP2fttD6zbg91IfVL45zY8TJNHWCD99uRfYBts/rs64YxIghBJjIyPEDVgMIIOG3r/ymMW6rZsHtaQg4UpQ95pOxa5heURpwIXOQsfhvJdWYDupYRvzs28KpR2GwyRGiAJHepkngbB7VrekBMlFYc89iPs9fy4Z56vElsYAjQqBCSjOqXvuC2iCEnzv0Tz1LWyZd7C7q3Yj3sDh+fZ3R0cD9qhV1Ja8CB6hI2nmfjiVhAIppMX7ZCibp1FL61dVeOE2D08I= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1771;20:MzECyam/Bt9gEeG1Qv9qQQFv1xOk1QpCf3qiPFWcjayHyklZudIEECnb+NcnlVZ8ggJzZGTQ7cuAtlj7nu7lLVY3pTamDQaP1y/jf0R/6AmcRzwB0QBUTXYMug5ROTn1psyWbxjWTFQ7Nvmka7eDol+zwJSntDliLSf6QWG9WJZ1Wi6dKKp0T0THOGRcug7Iths2inCUDcBD7kfpq8uoyV+sPzppWbVgxGF1bekVXFFuuBQpWaA0fz7bUHhN/kzbD1L6zCgKgLDST/+OVLszEZuJ3kYTSSIUL56SVDX7joRynO/K3I5Nl9nnIWPovT8CI6cWimeUR546dgF9j/HyaYJ5ETC/jhC/hoy4WUobl4Rfx8ZyK+hJNs9C0qtZhkerq7FaHdYKqO8K0P8k3Y6WIcWObD7MJlp4BXMF3aIKS1TPo1vL+KAm67I+1CAJafE+Adyv3ddrRhOgjFqL/INzVUPwyO870axtmVD+xvG2Cuih/kTD401Q44w0tzmUu3Fh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13016025)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CY1PR0201MB1771;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1771; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1771;4:ZJS9mKyyn6Lh8JWOXM9DE8BUjIQWo6QSZK0zljVnBcRMDvy08dKaV74rRXlNFm0HVa08rxpCvOu28HP9Gyax7sFXBbBrpQaO58pzmcYyDipHBbt0Ypu1gYtkKLsAnxFPnsYM+17U9gD1ALWQy+icdokOw59lAgS1teZMvKscFVXCoOZ5HWTv0HvhEEHslKqYw4g/2Lkgu6dbbvJW9VZPngxbGGQDYYMVO+/Wxzg8fsUhu4Q1SiSd0eUCG40OQvBCYHBC5arrB6dFxr/HQyqHmEcuauHBzHE0RK0UWRNSmpKVI+lrL9B0GP1WzIXJP5sb5Lj7sjJxWwSpl+TM7dK3crlULG4zIiZnQxp2DhqCsUm0cPmt7VgQgHnpazH0/jYLgHWYvOQwS3rFExdA9dA1h7veqhNV2UWr93q4vxBoZ6Rnn/wcngvt4qenJ1weRJQdugzJ5fk/0P6KQyTJxBm5M3d2nJbRpmU91uWtshrW0eJO+oItxSAIlNYGsPOvwYb/ X-Forefront-PRVS: 0981815F2F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAyMDFNQjE3NzE7MjM6dTZ3V1BmTWtJZ0VHOGJFZXUydndZaVlG?= =?utf-8?B?elhkNjUxWnBtazVSbWhDN09VdkJPTFVibndQR0JXenVpbHA4ZnF6SWVnbHZw?= =?utf-8?B?UHVObHVETmRsbVZ2R0N1WmJOUDdCcGpXL0g4SFhYMmlQU0lUQ1ZBTFlKRlcx?= =?utf-8?B?V3EvK1lla3VXU1hGaDBrcHBFSFdHVHB2RFBaNm85VEVxeThwdFJJMUNlV003?= =?utf-8?B?QVJMVDI0K25HYUlhd3pHVXNGeWVUdm0wVHNMSkdHN2YvRzJIS2ZZWTc2aFpP?= =?utf-8?B?aVpiMHhpK042YWxRbTU1M1hyRmpJazZEZ3d1U0h2MlJoQ0ZkVVVNRW9sN0RX?= =?utf-8?B?NXpVaWx2elRtcisycGhseXEvd0VRVmx6RVM1WHd3dThBdmUycmdkb09KcC81?= =?utf-8?B?STV4QU4wemU2Z1FTam40VmZPNWZ1NzZwb3hQaFAxUVRlY3lGakZydDdjd0lp?= =?utf-8?B?NTdja1hqdFl5NXhCWUtrZENYMjVxZ1pvbEZTVTdZNTRaR1NjZ3JHeTM4ZldU?= =?utf-8?B?LzZQSzY4VnR6V0hvd0MyR3RoZmR2SjNLQjV0eHh6MnBRdVdRKzJlcFZNY1Rx?= =?utf-8?B?ZklpTHdnalVjQWNIVUExSkhrdUtjbWVIb2VBV082T3FtYno1bkdUNzJRc3RE?= =?utf-8?B?b0M4YW03N0k3eDNpaXdkbzFRbVRqeStJSE84SEtMVTI2em56UkMvVk9HWHc3?= =?utf-8?B?OWRvbkoyUXU0bTI3Zjh2aE91UjJNMHpYYmY0K0tyWFo5NmE0cERqaXNBcENF?= =?utf-8?B?Y0hDVVZ2YnFvZ2N0azlZT1hJK1U0dng0QXBpZU1WU1Eyck8ycENaMGo4cFhm?= =?utf-8?B?TVNpOEJMRWdRSDM5SXV2aFNWeTdxSEE1R3V0STRoTWJwUWhCSTdBY1JWTUNL?= =?utf-8?B?VFVFQlQ1TDFERlA2Mm84VmVvOHgzc3JxaFNhYjc5dXE4dm96U0JmV3c4bzlj?= =?utf-8?B?OW0yMHFzOTd4NlRFQnZHRXZ2eXhFUnd5T0hlOGRuZmJRN1BveWFLUW96amlk?= =?utf-8?B?cHczSG1Cb3pMNGM3OWRvSjdaZ3ZoRWFMMFIreWhyZmJXUVBOT3g4SUV3RFNX?= =?utf-8?B?aS9GUHNDZ0xuR3Z2bEdIWHdQWmQ3NWVOeHJOaUc5MGtmME5PZldtUm83eEdi?= =?utf-8?B?S0VOUkFkN3ZaWlljWnBZdXd4NmU2V3crNDZwZUtZZHMzcGdpcUI1eEhuTUNL?= =?utf-8?B?aHFBL1QzamVoTG0raDZkMmtKTlBXcGJMam5MZjlwYlFIcldpYlcvQ1hLc1JQ?= =?utf-8?B?ZEJIMEh1dkhkUUJybnBrc0FUeUZ0Q21SNDVudEdDeFVXb0RLUmpDSkdNK2p4?= =?utf-8?B?bmsvQlM0Zng0TXN1bm55Tkh5MUhld0JRbEJYK0t4dlRzdXhDUk1HOW9jWWFJ?= =?utf-8?B?RzJPNmZVR3JqZDhGNG90VXc2aE0xMVdibVdkVFVnU2lMS1ZEcFpsaHdZR1Yr?= =?utf-8?B?RFZndVFMOGc1cFBsSlVOMnEzRVhXNXNBKy9mTG4rTHp3alovSEJmRi9oMWtZ?= =?utf-8?B?aWk1WTFoOFdYZm8vSjlXNkVDRTY5MG1FV0UvYk5vMzhTaVdQRE5kQ2hySG9l?= =?utf-8?B?aGwyck5EM3FoMVdyYUZ2K1VxMzg0enlndlNTc3pFeS9FY3pVWDNhWWlodTFj?= =?utf-8?B?MWJRd05PclRFNFpYdmhHR0F5NWtHY2V5RzFTOTNsaEVtZTFnOGRhVnZ1dzRT?= =?utf-8?Q?2VlT8DeoyGv+yyXrLEZC0+t5Nc6pq/AHTJKIVCNWn?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1771;6:RqFcdvkZvne0k6X1l6gyAxrOyxqZ4FgHpYRt/AeWY2B9QypMuj4vteP7PTbMPp1ivUqvj7ED/+t9t264IDju1VERs4bEIVxYC7UFejGaCGeGW1elNbim9uU63pQgahTO9sOB9TimIQ7zDEmWfP4DK26M53o9MSScBXHzceejE/qyLusapY9W6szMRRx0qzfsfeobDCEsQWHmGnyc21nOeaMug4bHkr1k3as2D/GHOl0rcf6toSPQrHRwUbpavHXKvMSpDAoUkO3clwhfM/C2docjOkxfzm6kubkklxv+X41njfcTYlv38MhKs4Bjb2REUZIcZ06fi0rM8683FPhzsdeqTbcwQDWeI1+ECrJN16k=;5:yriDvirgLgDxCXbVgYrpNS7PjUox89tCGnG3j/URPCRlnHCzmhMaFFS+4QaRomxaiAVaBJtR9dO2RQz6btvqJ0/iG/sZvcm5CmSPn5zDvbwiWtaNpAhZgWbRDM0VZvFTRXBVEhK1BTjZUFQR0irAAw==;24:v2PYTPPyfo2tsC38Lfk/dsD1aIJ5pp06HyKUDkC8UQ90KDZIesIXk8ILfSquXeht5Onl9D7YeSDitLD0Fhk9RYFQaOeEiXgtkYmCTGKIapw=;7:5zghshutXdqzUZG6yId3AdagtcM78PoGabn/PXPmI14pGqDbVji8brL++FyzXvGu/raMLx5hfh+0vejatT5lXbMdnNe6+WhrAd6JqRYelqrIXy3WBJLCRUk7tPQUaJSMleK0Xz7UVVbcz9RgvZvPIBa0NjTOBtOQoNfMZ0TbD6jw90YU/vi7Bb98Xb7tQNvlk+0lqxofIgaTJFZQtpKmmENnZhlVgezfghHJBZo25RwZMwCpQMGdNvQl+aC9BT6ILOKwSiApU9kdk2m2cRfqVA== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1771;20:vZeTFrbYpxPF0f2tZ/QJVJq9gqpk+jDKhZ9PQowMCPk5umMaDvs5krxceue+Flkql453lL7G76mcxK8+Xb5OMm+aQ85wDNmeUAeqhdQGCR9OKNvYtQuD8kTMmu+Th8e0YW1PwI0gvSqfcbUv4ySlgpeWyo6UTxblY1Qn5PQMCkgjK7pjsP9EfRotiWk8eDVKcwUqOHEAUisPNQ3qAti+XDFZRjcU1uX5q79bno+XCXAT6KPb3L8Uq73nBBx5Oizg X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 06:20:12.3730 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1771 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/21/2016 10:47 PM, Dan Williams wrote: > In preparation for the removal of 'driverfs_dev' from 'struct gendisk' > use a local variable to track the parented vs un-parented case in > ubd_disk_register(). > > Cc: Jeff Dike > Cc: Richard Weinberger > Reported-by: Bart Van Assche > Signed-off-by: Dan Williams > --- > arch/um/drivers/ubd_kern.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c > index ef6b4d960bad..8ec7b4112f55 100644 > --- a/arch/um/drivers/ubd_kern.c > +++ b/arch/um/drivers/ubd_kern.c > @@ -801,6 +801,7 @@ static void ubd_device_release(struct device *dev) > static int ubd_disk_register(int major, u64 size, int unit, > struct gendisk **disk_out) > { > + struct device *dev = NULL; > struct gendisk *disk; > > disk = alloc_disk(1 << UBD_SHIFT); > @@ -823,12 +824,12 @@ static int ubd_disk_register(int major, u64 size, int unit, > ubd_devs[unit].pdev.dev.release = ubd_device_release; > dev_set_drvdata(&ubd_devs[unit].pdev.dev, &ubd_devs[unit]); > platform_device_register(&ubd_devs[unit].pdev); > - disk->driverfs_dev = &ubd_devs[unit].pdev.dev; > + dev = &ubd_devs[unit].pdev.dev; > } > > disk->private_data = &ubd_devs[unit]; > disk->queue = ubd_devs[unit].queue; > - add_disk(disk); > + device_add_disk(dev, disk); > > *disk_out = disk; > return 0; Hello Dan, The Reported-by tag is intended to give people credit who find bugs in the upstream kernel. What I reported was a bug not in the upstream kernel but in a previous version of this patch series so I think the "Reported-by" tag can be left out from this patch. Additionally, please consider to use a more descriptive name instead of "dev", e.g. "parent". Thanks, Bart.