From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0DFC4167B for ; Fri, 9 Dec 2022 15:19:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbiLIPT1 (ORCPT ); Fri, 9 Dec 2022 10:19:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbiLIPTZ (ORCPT ); Fri, 9 Dec 2022 10:19:25 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E63C686F69 for ; Fri, 9 Dec 2022 07:19:23 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id f16so5229344ljc.8 for ; Fri, 09 Dec 2022 07:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cUqxyT1clmDwn9Zro9D+5wDVpGHXxnFJou8ChYK956o=; b=yqUAlzbOfp2h1Yly7SCMDl7vy1sjcTlMrzPPb+6GWRQTgEXcGrspmSiRh2H4SLbbG8 9czrZSSrhqK4PMyPoGfvZc1LPseUaujdwvVZXiyfusWWCiW+20KVIhwIUz/ahQuC6OCQ YDPRNPy43NFsyrZkX15D4QFKq66C5PLLN5sCk6dNP0CSk6uZgpmRoUuTcc+0vOrNtkAg 5Mkt5N3WWwJnM2OS8KqmyWaJACoGGiBsOdzTi/sCQmC+ajR/Lwfu0pQyPjrmFVICmPet Cl1G5TvhwcGInk7WtWTX4OARn/hUCEHNOHVWzFPcosYnOsTikoO83MPNVH2Cbmfx11iH qrew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cUqxyT1clmDwn9Zro9D+5wDVpGHXxnFJou8ChYK956o=; b=XMgWt5MJv5ctXJCf4x39123/7fx8UQ4aJjU+TUf0UtbUjy4Hv8eX0k6TK0XjQMZhLZ /d4dcKyXTEGMaN2j35wvxBj7VtJyccHoqIC3E0KcH/asl3dtaGMInbsPXhSPqSZrXqYv M+GxfSIcxO+Q9+U3CNv7w5bpABodDZSWHk0Fnik+XMexSKG4PCdeKfnRf6ORa8xuYnRx 4JnHKVSE4011MD2+VeunbhEq7JRX1nB+Zqtoo2VJPJ7P0t6FsFhSZ8bKGwZKeIhocCkS aJuMNRpSDtzCfAgoa4k3cKjttgM2aTmhfy1X0LuVYsYcXLszBJrBWgFtbJRMF0J7XMAo NFew== X-Gm-Message-State: ANoB5pmaHeDZYdktRp6A5rSZdM6MVdhzEiaKFvkHuNvZTzXxphGjX3Zv m18d/+890svsjL/bWzS5hpjEdg== X-Google-Smtp-Source: AA0mqf5f+iC1ajxI4MGe81943QW3HpslBZxD7S2QCV9T0YkIU4JpfAS0eNCTgGjB9xg7Zn00OIexUA== X-Received: by 2002:a05:651c:2118:b0:277:4c69:ee28 with SMTP id a24-20020a05651c211800b002774c69ee28mr3382419ljq.50.1670599162296; Fri, 09 Dec 2022 07:19:22 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id p20-20020a2eba14000000b002770566d642sm253305lja.17.2022.12.09.07.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 07:19:21 -0800 (PST) Message-ID: Date: Fri, 9 Dec 2022 16:19:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] dt-bindings: ufs: qcom: Add reg-names property for ICE Content-Language: en-US To: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Eric Biggers Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com> <24fa41d2-87d1-be19-af44-337784b0f0a4@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 09/12/2022 16:11, Luca Weiss wrote: > On Fri Dec 9, 2022 at 4:05 PM CET, Krzysztof Kozlowski wrote: >> On 09/12/2022 15:29, Luca Weiss wrote: >>> The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add this >>> in the bindings so the existing dts can validate successfully. >>> >>> Also sm8450 is using ICE since commit 276ee34a40c1 ("arm64: dts: qcom: >>> sm8450: add Inline Crypto Engine registers and clock") so move the >>> compatible to the correct if. >>> >>> Signed-off-by: Luca Weiss >>> --- >>> (no cover subject) >>> >>> The only remaining validation issues I see is the following on sc8280xp-crd.dtb >>> and sa8540p-ride.dtb: >>> >>> Unevaluated properties are not allowed ('required-opps', 'dma-coherent' were unexpected) >>> >>> Maybe someone who knows something about this can handle this? >>> >>> And the patch adding qcom,sm6115-ufshc hasn't been applied yet. >>> --- >>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >>> index f2d6298d926c..58a2fb2c83c3 100644 >>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >>> @@ -102,7 +102,6 @@ allOf: >>> - qcom,sc8280xp-ufshc >>> - qcom,sm8250-ufshc >>> - qcom,sm8350-ufshc >>> - - qcom,sm8450-ufshc >>> then: >>> properties: >>> clocks: >>> @@ -130,6 +129,7 @@ allOf: >>> - qcom,sdm845-ufshc >>> - qcom,sm6350-ufshc >>> - qcom,sm8150-ufshc >>> + - qcom,sm8450-ufshc >>> then: >>> properties: >>> clocks: >>> @@ -149,6 +149,12 @@ allOf: >>> reg: >>> minItems: 2 >>> maxItems: 2 >>> + reg-names: >> >> There are no reg-names in top-level, so it's surprising to see its >> customized here. It seems no one ever documented that usage... > > From what I can tell, from driver side all devices not using ICE don't > need reg-names, only the "ice" reg is referenced by name in the driver. > > I didn't add it top-level because with only one reg I think we're not > supposed to use reg-names, right? And you still won't need to use. Yet property should be rather described in top-level which also will unify the items here (so no different 2-item reg-names in variants). Just add it to top-level with minItems: 1 and per variant customize: 1. maxItems: 1 2. minItems: 2 + required The "required" is a bit questionable... this was never added by Eric to the bindings. Driver support and DTS were added completely skipping bindings... Best regards, Krzysztof