From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kumar, Abhijeet" Subject: Re: [PATCH 3/3] just some guess work to findout the culprit. If this breaks then we know what do. Date: Wed, 14 Feb 2018 10:23:57 +0530 Message-ID: References: <20180213192918.26331-2-chris@chris-wilson.co.uk> <1518581192-26400-1-git-send-email-abhijeet.kumar@intel.com> <1518581192-26400-3-git-send-email-abhijeet.kumar@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0223433516==" Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 79C56898F0 for ; Wed, 14 Feb 2018 04:54:00 +0000 (UTC) In-Reply-To: <1518581192-26400-3-git-send-email-abhijeet.kumar@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0223433516== Content-Type: multipart/alternative; boundary="------------0A1A9D60DD87FCB0452F99F2" Content-Language: en-US This is a multi-part message in MIME format. --------------0A1A9D60DD87FCB0452F99F2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 2/14/2018 9:36 AM, abhijeet.kumar@intel.com wrote: > From: Abhijeet Kumar > > --- > sound/pci/hda/hda_codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c > index 8c1b07e300a8..377d5719b4cd 100644 > --- a/sound/pci/hda/hda_codec.c > +++ b/sound/pci/hda/hda_codec.c > @@ -2714,7 +2714,7 @@ static unsigned int hda_sync_power_state(struct hda_codec *codec, > int count; > > for (count = 0;count < 500; count++) { > - state = snd_hda_codec_read(codec, fg, 0, > + state = snd_hdac_codec_read(&codec->core, fg, 0, > AC_VERB_GET_POWER_STATE, 0); > if (state & AC_PWRST_ERROR){ > msleep(20); Both tests are passing on hsw and bdw devices.I can conclude that none of my changes in "ALSA: hda: Make use of core codec functions to sync power state" is "*directly*" causing the regression. As this patch series changes the previously defined sync function similar to the latest one (the one defined in the defaulter patch). Sidenote- Sorry for the missing commit message, it was just a HACK patch. :) -Abhijeet --------------0A1A9D60DD87FCB0452F99F2 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit



On 2/14/2018 9:36 AM, abhijeet.kumar@intel.com wrote:
From: Abhijeet Kumar <abhijeet.kumar@intel.com>

---
 sound/pci/hda/hda_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 8c1b07e300a8..377d5719b4cd 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2714,7 +2714,7 @@ static unsigned int hda_sync_power_state(struct hda_codec *codec,
 	int count;
 
 	for (count = 0;count < 500; count++) {
-		state = snd_hda_codec_read(codec, fg, 0,
+		state = snd_hdac_codec_read(&codec->core, fg, 0,
 					   AC_VERB_GET_POWER_STATE, 0);
 		if (state & AC_PWRST_ERROR){
 			msleep(20);

Both tests are passing on hsw and bdw devices.I can conclude that none of my changes
in "ALSA: hda: Make use of core codec functions to sync power state" is "directly" causing the regression.
As this patch series changes the previously defined sync function similar to the latest one (the one defined
in the defaulter patch).

Sidenote- Sorry for the missing commit message, it was just a HACK patch. :)

-Abhijeet
--------------0A1A9D60DD87FCB0452F99F2-- --===============0223433516== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0223433516==--