Re: [PATCH 5/8] net/bnxt: add support for tx_descriptor_status

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 8/24/2017 5:29 PM, Ajit Khaparde wrote:
> add support for tx_descriptor_status dev_op
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

<...>

> +static int
> +bnxt_tx_descriptor_status_op(void *tx_queue, uint16_t offset)
> +{
> +	struct bnxt_tx_queue *txq = (struct bnxt_tx_queue *)tx_queue;
> +	struct bnxt_cp_ring_info *cpr;
> +	struct tx_pkt_cmpl *txcmp;
> +	uint32_t cons;
> +
> +	if (!txq)
> +		return -EINVAL;
> +
> +	cpr = txq->cp_ring;
> +
> +	if (offset >= txq->nb_tx_desc)
> +		return -EINVAL;
> +
> +	cons = RING_CMP(cpr->cp_ring_struct, offset);
> +	txcmp = (struct tx_pkt_cmpl *)&cpr->cp_desc_ring[cons];
> +
> +	if (CMP_VALID(txcmp, offset, cpr->cp_ring_struct))
> +		return RTE_ETH_TX_DESC_DONE;
> +
> +	return RTE_ETH_TX_DESC_FULL;

Same comment with Rx one, a check may be required to distinguish between
status FULL and UNAVAIL.

> +}
<...>