All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Masami Hiramatsu' <mhiramat@kernel.org>,
	Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Shuah Khan <shuah@kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Li Philip <philip.li@intel.com>,
	Liu Yiding <yidingx.liu@intel.com>
Subject: RE: [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo
Date: Mon, 11 May 2020 10:34:55 +0000	[thread overview]
Message-ID: <a53a35607015496986678713cd1899e8@AcuMS.aculab.com> (raw)
In-Reply-To: <20200511182752.c83f3454bcb3e205cf2bda4a@kernel.org>

From: Masami Hiramatsu
> Sent: 11 May 2020 10:28
...
> > We may not avoid fixing related failures after your change:
> > 1) We have to reuse built-in echo (do alias echo=echo) if we want to
> > test common_pid for histogram.
> > 2) We have to reuse built-in echo if some new tests want to interpret
> > backslash escapes in future.
> 
> 1) yes, that's what I need to do for avoiding "pid" key histogram
>   (but I think we should have better way to test it)
> 2) No, in that case you should use "/bin/echo -e" explicitly.
>    dash's built-in echo doesn't support it.
> 
> > Is it simple to provide two implementations of echo?(built-in echo and
> > echo command?) and then just apply echo command for kprobe_syntax_errors.tc?
> 
> Hmm, OK, there might be another reason we reconsider this patch.
> 
> - Alisasing echo (this patch) can avoid dash related issues but
>   this also makes "echo" running in another process implicitly.
> 
> - Using /bin/echo for backslash explicitly will be missed unless
>   user runs it on dash, but it will keep "echo" in same process.

Why not change to use printf - probably a builtin in both shells?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


  reply	other threads:[~2020-05-11 10:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 13:37 [PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for dash, etc Masami Hiramatsu
2020-05-01 13:37 ` [PATCH 1/3] selftests/ftrace: Make XFAIL green color Masami Hiramatsu
2020-05-01 14:15   ` Steven Rostedt
2020-05-01 13:37 ` [PATCH 2/3] selftests/ftrace: Pick only the first kprobe event to test Masami Hiramatsu
2020-05-01 14:17   ` Steven Rostedt
2020-05-01 15:38     ` shuah
2020-05-01 16:20       ` Steven Rostedt
2020-05-01 16:30         ` Shuah Khan
2020-05-02  3:05       ` Masami Hiramatsu
2020-05-01 13:38 ` [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo Masami Hiramatsu
2020-05-01 14:19   ` Steven Rostedt
2020-05-02  3:08     ` Masami Hiramatsu
2020-05-07 13:12       ` Steven Rostedt
2020-05-07 15:50         ` Masami Hiramatsu
2020-05-07 17:25           ` Steven Rostedt
2020-05-07 20:32             ` Zanussi, Tom
2020-05-08  7:11               ` Masami Hiramatsu
2020-05-07  6:45   ` Xiao Yang
2020-05-07  9:15     ` Masami Hiramatsu
2020-05-11  7:22       ` Xiao Yang
2020-05-11  9:27         ` Masami Hiramatsu
2020-05-11 10:34           ` David Laight [this message]
2020-05-11 12:01           ` [PATCH] selftests/ftrace: Use /bin/echo for backslash included command Masami Hiramatsu
2020-05-11 12:19             ` Andreas Schwab
2020-05-11 13:36               ` [PATCH v2] selftests/ftrace: Use printf " Masami Hiramatsu
2020-05-11 13:38                 ` Masami Hiramatsu
2020-05-11 13:46                   ` David Laight
2020-05-11 14:05                     ` Masami Hiramatsu
2020-05-11 14:59                   ` David Laight
2020-05-11 20:28                     ` Steven Rostedt
2020-05-11 13:42                 ` Andreas Schwab
2020-05-11 13:58                   ` Masami Hiramatsu
2020-05-25  9:59                 ` Masami Hiramatsu
2020-05-28 16:24                   ` Shuah Khan
2020-05-07  9:22   ` [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo Andreas Schwab
2020-05-07 15:52     ` Masami Hiramatsu
2020-05-01 14:21 ` [PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for dash, etc Steven Rostedt
2020-05-01 14:28   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a53a35607015496986678713cd1899e8@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=philip.li@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=tom.zanussi@linux.intel.com \
    --cc=yangx.jy@cn.fujitsu.com \
    --cc=yidingx.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.