From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B55C433B4 for ; Thu, 8 Apr 2021 13:26:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 624486113A for ; Thu, 8 Apr 2021 13:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229837AbhDHN0y (ORCPT ); Thu, 8 Apr 2021 09:26:54 -0400 Received: from linux.microsoft.com ([13.77.154.182]:36432 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231630AbhDHN0n (ORCPT ); Thu, 8 Apr 2021 09:26:43 -0400 Received: from [192.168.86.30] (c-73-38-52-84.hsd1.vt.comcast.net [73.38.52.84]) by linux.microsoft.com (Postfix) with ESMTPSA id 2CB1520B5680; Thu, 8 Apr 2021 06:26:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2CB1520B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1617888392; bh=wa/VfR5dOq9tsZ2NtAO+T057gx0rVmV0HzZysz7VXi8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TW7JW8Wyus+vBCg0hJy+26qz6yQC5fsyw16IF5PLU6shEx2Nohc/PGyE/34NIUqzS CD7igVEMeyaA+xC82MpP/0cYC0klCU9B7pOqV1ZlDHIwmAsTbw39gwn/Ie3n7T7AtW yBmL0yX0TnGMoyIeR0jv2EVlXRkaHdSZ6Pp9qhWo= Subject: Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM To: Sean Christopherson , Michael Kelley Cc: Tianyu Lan , Paolo Bonzini , vkuznets , Wanpeng Li , Jim Mattson , Joerg Roedel , Wei Liu , Stephen Hemminger , Haiyang Zhang , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , KY Srinivasan , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" References: From: Vineeth Pillai Message-ID: Date: Thu, 8 Apr 2021 09:26:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/7/21 6:48 PM, Sean Christopherson wrote: > On Wed, Apr 07, 2021, Michael Kelley wrote: >> >>> + pr_info("Hyper-V nested_features: 0x%x\n", >> Nit: Most other similar lines put the colon in a different place: >> >> pr_info("Hyper-V: nested features 0x%x\n", >> >> One of these days, I'm going to fix the ones that don't follow this >> pattern. :-) > Any reason not to use pr_fmt? Yes, that would be the best way to go. As Michael suggested, it would be better to fix the whole file as a cleanup patch. I shall fix this one to conform to the previous style and use pr_fmt as a separate fixup patch. Thanks, Vineeth