Re: [Qemu-devel] [PULL 01/14] ppc: Remove deprecated ppcemb target

[Thomas Huth <thuth@redhat.com>]

On 2018-09-10 06:25, David Gibson wrote:
> On Fri, Sep 07, 2018 at 08:39:52AM -0500, Eric Blake wrote:
>> On 09/07/2018 02:31 AM, David Gibson wrote:
>>> From: Thomas Huth <thuth@redhat.com>
>>>
>>> There is no known available OS for ppc around anymore that uses page
>>> sizes below 4k, so it does not make much sense that we keep wasting
>>> our time on building and testing the ppcemb-softmmu target. It has
>>> been deprecated since two releases, and nobody complained, so let's
>>> remove this now.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>>> ---
>>
>>> +++ b/qapi/common.json
>>> @@ -146,6 +146,6 @@
>>>     'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
>>>                'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64',
>>>                'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc',
>>> -             'ppc64', 'ppcemb', 'riscv32', 'riscv64', 's390x', 'sh4',
>>> +             'ppc64', 'riscv32', 'riscv64', 's390x', 'sh4',
>>>                'sh4eb', 'sparc', 'sparc64', 'tricore', 'unicore32',
>>>                'x86_64', 'xtensa', 'xtensaeb' ] }
>>
>> Can we also get documentation that this was deleted (probably as a followup,
>> since I'm only now noticing this in the pull request)?  See QKeyCode in
>> qapi/ui.json for an example of documenting 'altgr: dropped in 2.10'
> 
> So, it turns out Peter isn't able to process pull requests until late
> september, so I guess we can fix it inline after all.  I've now done
> so.
> 
> Since I won't be resending the pull request for a while, you can
> review the new version at:
> 
> https://github.com/dgibson/qemu/commit/9de3048e22f73824cc1920db17f7a166ef815090

Thanks, fine for me. Maybe just swap the order of the "Since: 3.0" and
the "ppcemb: dropped in 3.1" so that these entries are listed
chronologically?

 Thomas