From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goorO-0008Kk-6z for qemu-devel@nongnu.org; Wed, 30 Jan 2019 07:20:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goorM-0002Ba-6v for qemu-devel@nongnu.org; Wed, 30 Jan 2019 07:20:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44926) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1goorK-00029T-7A for qemu-devel@nongnu.org; Wed, 30 Jan 2019 07:20:51 -0500 References: <1548410831-19553-1-git-send-email-pbonzini@redhat.com> <1548410831-19553-3-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 30 Jan 2019 13:20:42 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/52] ide: split ioport registration to a separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: yang.zhong@intel.com, BALATON Zoltan On 30/01/19 13:07, Thomas Huth wrote: > I think adding ioport.o to IDE_PCI and IDE_VIA is wrong. The > ide_init_ioport() function is only used by isa.c and piix.c, so it > should only be added for IDE_ISA and IDE_PIIX here. Good idea, another one for Yang. :) Paolo