From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [PATCH] net: phy: dp83867: Do not check sgmii if rgmii is already used
Date: Tue, 11 Feb 2020 09:11:44 +0100 [thread overview]
Message-ID: <a5738f10-aba3-f297-352e-a822329b543d@xilinx.com> (raw)
In-Reply-To: <5ecc9571-160f-a85d-8f17-67b78cc4ba9d@ti.com>
On 10. 02. 20 13:07, Grygorii Strashko wrote:
>
>
> On 07/02/2020 13:31, Michal Simek wrote:
>> There is no reason to check sgmii branch again when it is clear that phy
>> interface is rgmii.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> drivers/net/phy/dp83867.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
>> index 4d796e289c45..3178787ff1c7 100644
>> --- a/drivers/net/phy/dp83867.c
>> +++ b/drivers/net/phy/dp83867.c
>> @@ -327,9 +327,7 @@ static int dp83867_config(struct phy_device *phydev)
>> phy_write_mmd(phydev, DP83867_DEVADDR,
>> DP83867_RGMIIDCTL, delay);
>> - }
>> -
>> - if (phy_interface_is_sgmii(phydev)) {
>> + } else if (phy_interface_is_sgmii(phydev)) {
>> phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR,
>> (BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000));
>>
>
> From one side I have no objections, but from another - I'd prefer to
> keep as is.
Can you please be elaborate on this one more?
Thanks,
Michal
next prev parent reply other threads:[~2020-02-11 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 11:31 [PATCH] net: phy: dp83867: Do not check sgmii if rgmii is already used Michal Simek
2020-02-10 12:07 ` Grygorii Strashko
2020-02-11 8:11 ` Michal Simek [this message]
2020-02-12 20:24 ` Grygorii Strashko
2020-02-13 6:23 ` Michal Simek
2020-02-13 15:49 ` Grygorii Strashko
2020-02-13 16:05 ` Michal Simek
2020-02-19 16:36 ` Grygorii Strashko
2020-02-20 8:08 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5738f10-aba3-f297-352e-a822329b543d@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.