From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] block: flush: fix IO hang in case of flood fua req To: Ming Lei , linux-kernel@vger.kernel.org References: <1477472235-22845-1-git-send-email-tom.leiming@gmail.com> Cc: linux-block@vger.kernel.org, Christoph Hellwig , Kent Overstreet , Jens Axboe From: Jens Axboe Message-ID: Date: Wed, 26 Oct 2016 07:48:59 -0600 MIME-Version: 1.0 In-Reply-To: <1477472235-22845-1-git-send-email-tom.leiming@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed List-ID: On 10/26/2016 02:57 AM, Ming Lei wrote: > This patch fixes one issue reported by Kent, which can > be triggered in bcachefs over sata disk. Actually it > is a generic issue in block flush vs. blk-tag. Looks good to me. Had to double check we don't get there for the mq path, but we have our own end_io for that path. Applied. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933208AbcJZNtn (ORCPT ); Wed, 26 Oct 2016 09:49:43 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:41834 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbcJZNth (ORCPT ); Wed, 26 Oct 2016 09:49:37 -0400 Subject: Re: [PATCH] block: flush: fix IO hang in case of flood fua req To: Ming Lei , References: <1477472235-22845-1-git-send-email-tom.leiming@gmail.com> CC: , Christoph Hellwig , "Kent Overstreet" , Jens Axboe From: Jens Axboe Message-ID: Date: Wed, 26 Oct 2016 07:48:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477472235-22845-1-git-send-email-tom.leiming@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CO1PR15CA0011.namprd15.prod.outlook.com (10.166.26.149) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: 4703115e-a7b4-42cd-3613-08d3fda6d9c5 X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;2:YQtNDxA5MUxzYGDhnx5+KT0yczzvRkMnCQj7kwegtJp78DOip1VsjfwK56rzUnGWloJjisuCrszfpir2QOpu+2OMacgfMs+XidDl6SchTWUvOZVtd1MQf9L8NwLaCVTmYqyXaihKsdIwN/NKHXJydpxBQTHu8kFFZtWyZL5CROZFGW3XEaNZEu4DvWj7UXzNpg2awwhz/kx6oPlfgB+EKA==;3:4QO1yzEOhH1WIKxNS7mYRDU7ceryR9OM15V1HMGlzDHVvdxE2qx6geMJvT2XmySm3HrKA+zWFH9PsrctTxGWowfR4BkVrmONm/+TThmBb4Wmwj7fwW1fOj9kdIVNE6miGke14YrwvSX2x4khcQ2PjA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;25:VGRJYfxdgxQT0OJ5ZhIhenDi61r8hkU8fIrE+oIlay/Q4WZrF+bhAiMgEIYAiHH+zVGyIMhsAOh6u6KvusCaqhqZ1lzlzBT6/jdE416hvQQwMdvri24YVENke2aR7xj6XVjLFW8lPbu74dYJVXJD9ULcidJNpROrrV3Q9+R4AwNEL0yulZ+VOzs01bziW2wUe1unUYZtM9Yq8r6Jb+AVYrBjpXanSc3JbzROEl4SMlzbTrfE4CSgUKR/hiTSBzIFd5sDa/AVcrPB5B1n0pumnCrXGU9csMuPWBDGw0vgdc/EpBwNTQjTU3otw98y3SwKg0hkRNy4+jcY1ENbDUa1dG6IT7WIIIP/JgaNRZIqcQvQJAneU9Bp6NbLx8XqmCLRhzQGFfV1k59CJcJCb9aMvibU08lnXEnvr6IfxRmSCX5OwH9f9vHi9157wGPqLnNHmL2em6KO6y5XZlm6m46T6tP4v7AEG53kg6yp6Qo2R1wGjT6nwV3MYzx6zqaCtwP1EpHyF+zrimhVWfu+A1gEfALP6ECs7AGYICVgP7rUAx7mWiqsc6z713GjLVcpMtVqDfECgJRo1YTA070sY2ziV7ZMLrQF+Iq4uJ4UaClGUrmJYk08F3xQTiGIfOeFhIL91WaKPpVPSheSUknTp/wDP6RCApZAjzyMjsHbsME77QczOqY3sa9Ai3F5IOzX/jxhJNFn1BI5/tPDNUHNT3pQmirCnfXW5CkZAoRlrnONYCM= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;31:VNgk08YMlTG/Ax2f5Gx05CtL0OhL8bFBa7KD77OnY7RrLx33eMmUWIbYC2BT9HHVGMcZKu7Q5XMZoIUMdziBA8Qki6mxkKk2MySxYDW7VU8ydmRt5163CfMhj8ruDIQkWfT3WsyLIWP9Kdk/PMjIp9dzTZA9gUrs5EO3g9gNd64BdSNuXrCLOXU+oyaWDZxwRZA45VbdNAOyo2FLXKKAZIJpo87hKpoggxxiED3kOk/7qtx8msnVcYJfIbSjfETU7IOy9ZzXOF8BGe5Mad/LTA==;20:gbJgfB8/aj7dzL6CS3IfzRcYyp7Mc0JqWair9JCmWq/xrH+Vamn3OADpNLFqRJewoVEGbE54Ka6q5OuK+RV0bSeDMgFreNeEAIvXg1ftNN8jhwL4Koz/Rpel5rLTuhFRJc3xJ8pUNrjRrB+WRtMc7WJymI3U/jGT/M+UQmwgl2A=;4:IoRlbOW3FyKSWfIs/XZtSGgwZiYh8ymxOtnwpZW8E2t22nKlFCmseK0mJfRbKs9f5NrOhZ8Ck/e4xp6qyR6uPtUMwCwVKYnyCh+/lJX1YsAp5SP+Umo7n1p10u5Q+0X9TueeeqovjFb0O7xLy9fWJF7wBiRBaf2wpcO9cMJHO8OxJIQrC4zu+nERRpbP6nApRL368MllfOps0icoPvOgpgij4we25HSCGTN8LXffDXogQHMIrs2+FC9938uzMAsDNjm4QfbxqnpRvSvPdk0bJvE5jNAWKlImYZlV4aUwigiEnB/fVMtWGw7eJ03hRtKSQX5kWSjpnQbzlGVXITJt9WyJircxNhL1SKOKUSRrmL8wJ6w5O0AZYdEMa+40dHYY96BzS7bsXy90NjzXcvzu+Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Forefront-PRVS: 0107098B6C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(24454002)(377454003)(199003)(189002)(65826007)(31686004)(117156001)(6116002)(66066001)(5660300001)(65806001)(65956001)(54356999)(50986999)(42186005)(92566002)(81166006)(2950100002)(7846002)(106356001)(76176999)(83506001)(23746002)(8676002)(33646002)(3846002)(305945005)(7736002)(47776003)(81156014)(189998001)(97736004)(68736007)(4001350100001)(86362001)(31696002)(50466002)(105586002)(101416001)(4326007)(2906002)(6666003)(36756003)(77096005)(5001770100001)(586003)(64126003)(230700001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:DMs6j9gzsFyVLqqZNJyxRbm0ptAXSAWuZsOEN?= =?Windows-1252?Q?J1+UMsqSC61XjjdG5+sNIMipEj3Obfj4EAUy3z3bsMjuD7ADcT6cD3gJ?= =?Windows-1252?Q?VSvj7cNaaulA47vyJVCqtLPwX7JixK1QxP5Hwkn+KkFQfpn41VB00tBj?= =?Windows-1252?Q?lyWUPfX6x/Y1NXah6WbNePQtYEN2IjmagiHPdaL9/2N1Dzdtlcf5iNWY?= =?Windows-1252?Q?jgDDnIwN1jbeNrLfJ7MB5L73BOvXSdE/WX5oul5m2/9r8pmvbIV0B+1K?= =?Windows-1252?Q?VIspWYBdp65bsQ/O2x8iVyK1nWKG+RSw6Y9hPeV/37JXHby7ADJ2ts5y?= =?Windows-1252?Q?eQ6/cinmGAMwoKQ4UpLBZvfZmVV6/YyuAXQLHU7aeI1jFzjZWSWpDWco?= =?Windows-1252?Q?DRuU36Tw59F2+UvU7LUUAuBiOQO2IZaafl2WVzAeFwof4BGltTJ+CZDj?= =?Windows-1252?Q?XOxxwaoU8r0YThpk97+KgZ45OxYl59/KPeVJzrzceVkM8BA9df+pjjdP?= =?Windows-1252?Q?ltoj8IszmfaVxYtbtTfc94RUdaVCn8HZ1bIBxkp58sONu0TgjCQyXYte?= =?Windows-1252?Q?qiJ9FZjB3eo9G19tARpcxB/m088EUnYhRJ2fW3Ej+xrYTt3eJcZfiQVr?= =?Windows-1252?Q?ORL5QDyLjA17rRvZEiNLyN2whagxdrzLTwTpX/ECA2G0KwgY9Arw4rZP?= =?Windows-1252?Q?GCPBc47qDAN3M3CAPitghpvh9N80dtotuWi9qaLkdZe80pdsJqX5Fv+W?= =?Windows-1252?Q?JvxrTGl1Z2/BepVXjIOjcBNSzdt+P9pS5Ht8LCagtUggvQ3BgFx5GKA8?= =?Windows-1252?Q?xX3EOjXyEa7CCW48WVYZW/NEE2qyYRgBiPrAURz3dU8HgP6LotQO+kDQ?= =?Windows-1252?Q?/OJSqxtI43DWG1YIc2SAxWCE4B5X4ziTGmS9VgFo+H0VldOd830nYr7o?= =?Windows-1252?Q?gn6fnL5wzlj4zLdf2tPvFmcW25LdP2t2dsNe1Nw4Y4UguWhJUJeEMPVd?= =?Windows-1252?Q?c/vR0o+g7lsVp98phhjYXZG2VeQUOH0xMgCzxUbqIfLEjgfDZGjzrNSU?= =?Windows-1252?Q?rzRC1XeA3XrqQS0Ugngt9276fDsIPqwCSfk5LtvqSdJYPApAQtMZiAok?= =?Windows-1252?Q?UArLhiE1aqPaHjJOybOug2Jluo2/SXlb667wsVXKaYiAttij1PWLLov/?= =?Windows-1252?Q?mmr3HjDwGQ3sRsZq+KSbm7BLi1a0HXa94cmrfXtQPIhiRAFMctRSrzJG?= =?Windows-1252?Q?Ey+34zQViyv7sbpDgShgmOEvgYixu8Zqpw9HGnIbDpGYe0wZ3naOl21H?= =?Windows-1252?Q?o7SyP2tH3S3UAyOO69NI7wm237VT+MKt17cGUF0u3S7PHC3HOY+HFd9w?= =?Windows-1252?Q?FxSIu/AWwN5358Ls1AE2XQLMMnuZGU7RA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:+8CI98MQ8s20YMyw5JrREdy1yJg2E/+dCVpG8lIy4SUud1ghDSN+jon19QrVPFngmPWmbBCdy/vJxWIQHsc6GWzb/4/1035DUTSGGOJAx8KPNQscCrl4siICInPRnJw1atX6/csKbXX7FiZnGay45SJDThLMOOMyyJVrwnPXtWSf3xeXEBZ10P9XmcyaIEjZRe1i64fCEI8+dOtjv8H7IF95H8wB/r5LJVAxIfc5p5+jrEhLQ5frs8pOCqG442AEsN0/SHBTr+BMd2SOVy8Z9bvj39M/UuBs9SIH+PZ1VTWpxR4hcm5bsTHqy8vy0Ko/;5:PWfk9XTPDgLMP5Dasr1ge0EynMtVAGxJ5NVs9RLC0HupZX/RxbP94qFZCsGpv0dI1EDMwt86cuXpAeKmzQLFZTmj1Mxg6d6gvipRwFR0i+CI84Vqy0HwqYEa42QDoIUUraJFLeRNj+R0NnT4tSz4/NDBKVCeh9NCtMGZJcbjMws=;24:OF9E6nEimIA/wUvUznej1pgMZR7LGzjHotC5FXZopwY5QTijDqVQVzqQAtWTiO7u8VBtYwWWnMqt8EwpR5IQivI4N0rbg7zvNEgBsWxJ71Y=;7:x+zCZtXsadyJR403B/t0eKi1Nhrc/wge3IuNgr1qvDQ+ub7NDVnTP7nGpeApMotFUgTOaENrO/MWUf6fCGJ8+eKBDM9ac198i7NbQoRBPmGM+GD3qSPD7HJCnKZGbJLuqXLEIod0TpLpi9YUoh5UvX3EgqbslztXp1HYEaooETj/yWO3tEuRgmiMa9nLWarNpQkOd87dXatXsZL6vuopOIhgWA7OEMabgs3Qn00Kwrxf4R+eZ4UARHodKhWlSjY8SBZkdxb9/BqgyQNgnY+SgLaceXYYBXAzYAF4f5lZlDZpV4yE3Wq7gszGz5DMkly0pLgNSG8QZyaPNG+cSU8b7d0EGo9MEoQmNchXZVwMxKQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;20:DghNjTW7JVl7WWGQL+50ziEoIQvJ7u5r7y5QJKhZMrsiX0mW9JKR6bfq46h8A7MoaBp4a0dhXhHm/2g8bzi84sMyrNpo0dLSk8an3NYjuEqJI3uprfUpHCrw8Yy4S9vJkXouaInugI3VfhUzqGF2gOmDGMfktNhHRhG1sodIARk= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2016 13:49:04.3936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-26_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2016 02:57 AM, Ming Lei wrote: > This patch fixes one issue reported by Kent, which can > be triggered in bcachefs over sata disk. Actually it > is a generic issue in block flush vs. blk-tag. Looks good to me. Had to double check we don't get there for the mq path, but we have our own end_io for that path. Applied. -- Jens Axboe