From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E31DC433F5 for ; Sat, 21 May 2022 23:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347496AbiEUXvP (ORCPT ); Sat, 21 May 2022 19:51:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345028AbiEUXvI (ORCPT ); Sat, 21 May 2022 19:51:08 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DD9B23150 for ; Sat, 21 May 2022 16:51:04 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653177063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=117xuqHBOdhuOAsmwIJGI3P4mj0w/efp2m2gROWKZlA=; b=Jh+koRmI//BLkM/hoAgYAhNGC+0gspnLZjPA6+o3fL6M9HcD5jkU1bZ7PVoI39soZ+y8O1 QkoCAhHSilcjE+5A0ZtPA5RLcfrm853gS8dUZhguqQcYgPVaLa8qHG7yalDGxTAwXmDJsA jOioYqPpMqRFbKhcfQYOuEc9y71UGVs= From: andrey.konovalov@linux.dev To: Mark Rutland Cc: Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Catalin Marinas , Vincenzo Frascino , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH 2/2] arm64: stacktrace: use non-atomic __set_bit Date: Sun, 22 May 2022 01:50:59 +0200 Message-Id: In-Reply-To: <697e015e22ea78b021c2546f390ad5d773f3af86.1653177005.git.andreyknvl@google.com> References: <697e015e22ea78b021c2546f390ad5d773f3af86.1653177005.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrey Konovalov Use the non-atomic version of set_bit() in arch/arm64/kernel/stacktrace.c, as there is no concurrent accesses to frame->prev_type. This speeds up stack trace collection and improves the boot time of Generic KASAN by 2-5%. Suggested-by: Mark Rutland Signed-off-by: Andrey Konovalov --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 33e96ae4b15f..03593d451b0a 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -103,7 +103,7 @@ static int notrace unwind_frame(struct task_struct *tsk, if (fp <= frame->prev_fp) return -EINVAL; } else { - set_bit(frame->prev_type, frame->stacks_done); + __set_bit(frame->prev_type, frame->stacks_done); } /* -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5EC9C433F5 for ; Sat, 21 May 2022 23:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=32pJuCZMHt8EECHv4rJWt/9cXny5E/LekCqDOa+O2xo=; b=teIqPBLsntbEIw Wvj3z0wFWN9X/LFi99jiAAe+Do6DF80fG0iLoU0dYUGGtBdjX9fmQ5qmU0RyUpgluqVpjaw2Vuk1t 36OgYYRi+ii5iIzsByFAlVUGdTfQWBZNb6IrlreBBDmFl+rljlcwZJxvb/wta8H6ima+sjzZUXBdH yEAdaaXUqJ2E0mf5i4gYBXdzIoJdwH0R7pNEMBvv/19XLgnjngvuou9uTJo4RtUM3GbCoKovv6pxA sNHB3hZZAmWG5ajjJnB2lZHNHpW+AI71yaL/fCszRFDlpmvHc7GhAvsP4CqC6Y/9Hb2/+fKdudQXc 1L2EdS+z6zud/Gyha6TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsYsN-000Af8-Uj; Sat, 21 May 2022 23:51:16 +0000 Received: from out2.migadu.com ([2001:41d0:2:aacc::]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsYsJ-000AdD-Ob for linux-arm-kernel@lists.infradead.org; Sat, 21 May 2022 23:51:14 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1653177063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=117xuqHBOdhuOAsmwIJGI3P4mj0w/efp2m2gROWKZlA=; b=Jh+koRmI//BLkM/hoAgYAhNGC+0gspnLZjPA6+o3fL6M9HcD5jkU1bZ7PVoI39soZ+y8O1 QkoCAhHSilcjE+5A0ZtPA5RLcfrm853gS8dUZhguqQcYgPVaLa8qHG7yalDGxTAwXmDJsA jOioYqPpMqRFbKhcfQYOuEc9y71UGVs= From: andrey.konovalov@linux.dev To: Mark Rutland Cc: Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Catalin Marinas , Vincenzo Frascino , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH 2/2] arm64: stacktrace: use non-atomic __set_bit Date: Sun, 22 May 2022 01:50:59 +0200 Message-Id: In-Reply-To: <697e015e22ea78b021c2546f390ad5d773f3af86.1653177005.git.andreyknvl@google.com> References: <697e015e22ea78b021c2546f390ad5d773f3af86.1653177005.git.andreyknvl@google.com> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220521_165112_756360_E4BB40BA X-CRM114-Status: GOOD ( 10.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Andrey Konovalov Use the non-atomic version of set_bit() in arch/arm64/kernel/stacktrace.c, as there is no concurrent accesses to frame->prev_type. This speeds up stack trace collection and improves the boot time of Generic KASAN by 2-5%. Suggested-by: Mark Rutland Signed-off-by: Andrey Konovalov --- arch/arm64/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 33e96ae4b15f..03593d451b0a 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -103,7 +103,7 @@ static int notrace unwind_frame(struct task_struct *tsk, if (fp <= frame->prev_fp) return -EINVAL; } else { - set_bit(frame->prev_type, frame->stacks_done); + __set_bit(frame->prev_type, frame->stacks_done); } /* -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel