All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 6/6] station: disable roaming logic for auto-roaming cards
Date: Wed, 10 Mar 2021 15:27:25 -0600	[thread overview]
Message-ID: <a5901a8f-9970-b381-1932-3362849e14b6@gmail.com> (raw)
In-Reply-To: <06fb951fa51a52fe564573044d38156018873b51.camel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

Hi James,

>> Hmm, isn't this completely opposite to the intent of adding this capability to
>> brcmfmac?
> 
> Unless there is a way to disable FW roaming we cannot allow station to roam 

Hm, why not?  Isn't the worst case that we run our roam logic as well?  In 
theory we could set the CQM threshold to be more aggressive and attempt roams 
before the firmware does...

> based on CQM events. We don't have any control when the FW roams so for cards 
> like this I figured it was needed to disable this roaming logic.
> 
> I've only tested this on my single brcmfmac card, which definitely will not work 

What fails?

> right if station reacts to CQM events. Plus station cannot even do FT on these 
> cards anyways.

Sure, and FT is a bit tricky.  But FT is not the only way to roam...

> 
> Maybe Alvin has some insight to this?
> 

Yeah, I'm actually curious why we haven't heard of any NL80211_CMD_ROAM related 
issues ?  I believe I remember Alvin reporting that iwd was working fine on his 
brcmfmac hardware + cqm reporting enabled kernel...

Regards,
-Denis

  reply	other threads:[~2021-03-10 21:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 20:27 [PATCH 1/6] netdev: use NL80211_STA_INFO_SIGNAL rather than average James Prestwood
2021-03-10 20:27 ` [PATCH 2/6] scan: allow 'faked' scan_bss results James Prestwood
2021-03-10 22:25   ` Denis Kenzior
2021-03-10 20:27 ` [PATCH 3/6] nl80211util: add WIPHY_FREQ to parse_attrs support James Prestwood
2021-03-10 21:08   ` Denis Kenzior
2021-03-10 20:27 ` [PATCH 4/6] netdev: station: support full mac roaming James Prestwood
2021-03-10 20:27 ` [PATCH 5/6] wiphy: parse NL80211_ATTR_ROAM_SUPPORT flag James Prestwood
2021-03-10 20:27 ` [PATCH 6/6] station: disable roaming logic for auto-roaming cards James Prestwood
2021-03-10 21:01   ` Denis Kenzior
2021-03-10 21:15     ` James Prestwood
2021-03-10 21:27       ` Denis Kenzior [this message]
2021-03-10 21:48         ` James Prestwood
2021-03-11  0:16           ` Alvin =?unknown-8bit?q?=C5=A0ipraga?=
2021-03-11  2:36             ` Denis Kenzior
2021-03-11 11:06               ` Alvin =?unknown-8bit?q?=C5=A0ipraga?=
2021-03-11 17:32                 ` James Prestwood
2021-03-11 18:18                   ` KeithG
2021-03-11 18:45                     ` James Prestwood
2021-03-11 19:02                   ` Alvin =?unknown-8bit?q?=C5=A0ipraga?=
2021-03-10 21:12 ` [PATCH 1/6] netdev: use NL80211_STA_INFO_SIGNAL rather than average Denis Kenzior
2021-03-10 21:16   ` James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5901a8f-9970-b381-1932-3362849e14b6@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.