All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v7 1/3] s390x: Give name to return value of tprot()
Date: Wed, 4 May 2022 15:23:51 +0200	[thread overview]
Message-ID: <a5b2fc92-6d7a-54c9-9fcc-dd9b137c4c40@redhat.com> (raw)
In-Reply-To: <20220502154101.3663941-2-scgl@linux.ibm.com>

On 02/05/2022 17.40, Janis Schoetterl-Glausch wrote:
> Improve readability by making the return value of tprot() an enum.
> 
> No functional change intended.
> 
> Signed-off-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> ---
>   lib/s390x/asm/arch_def.h | 11 +++++++++--
>   lib/s390x/sclp.c         |  6 +++---
>   s390x/tprot.c            | 24 ++++++++++++------------
>   3 files changed, 24 insertions(+), 17 deletions(-)

Looks fine!

Reviewed-by: Thomas Huth <thuth@redhat.com>


  reply	other threads:[~2022-05-04 13:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 15:40 [kvm-unit-tests PATCH v7 0/3] s390x: Test effect of storage keys on some instructions Janis Schoetterl-Glausch
2022-05-02 15:40 ` [kvm-unit-tests PATCH v7 1/3] s390x: Give name to return value of tprot() Janis Schoetterl-Glausch
2022-05-04 13:23   ` Thomas Huth [this message]
2022-05-02 15:41 ` [kvm-unit-tests PATCH v7 2/3] s390x: Test effect of storage keys on some instructions Janis Schoetterl-Glausch
2022-05-04 12:46   ` Janosch Frank
2022-05-04 13:29   ` Thomas Huth
2022-05-02 15:41 ` [kvm-unit-tests PATCH v7 3/3] Disable s390x skey test in GitLab CI Janis Schoetterl-Glausch
2022-05-05 13:16 ` [kvm-unit-tests PATCH v7 0/3] s390x: Test effect of storage keys on some instructions Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5b2fc92-6d7a-54c9-9fcc-dd9b137c4c40@redhat.com \
    --to=thuth@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=scgl@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.