From: Paulo Alcantara <pc@manguebit.com>
To: nspmangalore@gmail.com, smfrench@gmail.com,
bharathsm.hsk@gmail.com, linux-cifs@vger.kernel.org
Cc: Shyam Prasad N <sprasad@microsoft.com>
Subject: Re: [PATCH 12/14] cifs: handle when server stops supporting multichannel
Date: Wed, 08 Nov 2023 13:35:03 -0300 [thread overview]
Message-ID: <a5bb61ab36adbee983a4b1106ee63ec7.pc@manguebit.com> (raw)
In-Reply-To: <20231030110020.45627-12-sprasad@microsoft.com>
nspmangalore@gmail.com writes:
> From: Shyam Prasad N <sprasad@microsoft.com>
>
> When a server stops supporting multichannel, we will
> keep attempting reconnects to the secondary channels today.
> Avoid this by freeing extra channels when negotiate
> returns no multichannel support.
>
> Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
> ---
> fs/smb/client/cifsglob.h | 1 +
> fs/smb/client/cifsproto.h | 2 ++
> fs/smb/client/connect.c | 10 ++++++
> fs/smb/client/sess.c | 64 ++++++++++++++++++++++++++++++-----
> fs/smb/client/smb2pdu.c | 70 ++++++++++++++++++++++++++++++++++++++-
> fs/smb/client/transport.c | 2 +-
> 6 files changed, 139 insertions(+), 10 deletions(-)
Several reconnect tests are triggering this when running against
for-next branch
[ 360.487827] dftest>> [*] mount opts: vers=3.1.1,echo_interval=10,nohandlecache,noserverino
[ 361.570676] dftest>> [*] mount opts: vers=3.1.1,echo_interval=10,nohandlecache,noserverino
[ 361.572133] dftest>> [*] TEST: mount //gandalf.test/dfstest3 , cd /mnt/dfs/link , ls ., expect:["target\d_file" "tsub"]
[ 361.572133] disconnect /mnt/dfs/link , ls#1 . (fail here is ok), ls#2 (fail here NOT ok)
[ 361.613964] CIFS: Attempting to mount //gandalf.test/dfstest3
[ 361.637663] virtio_net virtio1 enp1s0: entered promiscuous mode
[ 362.262990] CIFS: Attempting to mount //gandalf.test/dfstest3/link
[ 362.483166] ls (978) used greatest stack depth: 21904 bytes left
[ 398.362399] CIFS: VFS: \\w22-root2.gandalf.test has not responded in 30 seconds. Reconnecting...
[ 398.364632] BUG: sleeping function called from invalid context at kernel/workqueue.c:3344
[ 398.366399] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 981, name: cifsd
[ 398.367318] preempt_count: 1, expected: 0
[ 398.367826] RCU nest depth: 0, expected: 0
[ 398.368414] 1 lock held by cifsd/981:
[ 398.368905] #0: ffffffffc028fb58 (&cifs_tcp_ses_lock){+.+.}-{2:2}, at: cifs_mark_tcp_ses_conns_for_reconnect+0x5f/0x3b0 [cifs]
[ 398.371053] CPU: 3 PID: 981 Comm: cifsd Not tainted 6.6.0 #1
[ 398.371720] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.2-3-gd478f380-rebuilt.opensuse.org 04/01/2014
[ 398.373072] Call Trace:
[ 398.373404] <TASK>
[ 398.373700] dump_stack_lvl+0x64/0x80
[ 398.374188] __might_resched+0x23c/0x360
[ 398.374708] ? __pfx___might_resched+0x10/0x10
[ 398.375188] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.375688] ? __might_sleep+0x2b/0xb0
[ 398.376086] ? __flush_work+0xc5/0x640
[ 398.376539] __flush_work+0xfd/0x640
[ 398.377019] ? __flush_work+0xc5/0x640
[ 398.377524] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.378155] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.378798] ? __pfx___flush_work+0x10/0x10
[ 398.379408] ? hlock_class+0x32/0xc0
[ 398.379840] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.380355] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.380959] ? mark_held_locks+0x5d/0x90
[ 398.381537] __cancel_work_timer+0x210/0x2c0
[ 398.382117] ? __pfx___cancel_work_timer+0x10/0x10
[ 398.382757] ? do_raw_spin_trylock+0xd1/0x120
[ 398.383363] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.383921] ? do_raw_spin_unlock+0x9b/0x100
[ 398.384382] cifs_mark_tcp_ses_conns_for_reconnect+0x227/0x3b0 [cifs]
[ 398.385834] reconnect_dfs_server+0x162/0x6b0 [cifs]
[ 398.387107] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.387715] ? __mutex_unlock_slowpath+0x11e/0x400
[ 398.388219] ? __pfx___mutex_lock+0x10/0x10
[ 398.388736] ? __pfx_reconnect_dfs_server+0x10/0x10 [cifs]
[ 398.390057] ? __pfx____ratelimit+0x10/0x10
[ 398.390637] cifs_readv_from_socket+0x335/0x490 [cifs]
[ 398.391898] ? __pfx_cifs_readv_from_socket+0x10/0x10 [cifs]
[ 398.393084] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.393730] cifs_read_from_socket+0xb5/0x100 [cifs]
[ 398.394985] ? __pfx_cifs_read_from_socket+0x10/0x10 [cifs]
[ 398.396176] ? __pfx_mempool_alloc+0x10/0x10
[ 398.396734] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.397386] ? cifs_small_buf_get+0x53/0x70 [cifs]
[ 398.398619] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.399245] ? allocate_buffers+0xa7/0x1d0 [cifs]
[ 398.400294] cifs_demultiplex_thread+0x274/0x1270 [cifs]
[ 398.401346] ? __pfx_cifs_demultiplex_thread+0x10/0x10 [cifs]
[ 398.402680] ? __pfx_lock_release+0x10/0x10
[ 398.403053] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.403464] ? mark_held_locks+0x1a/0x90
[ 398.403813] ? lockdep_hardirqs_on_prepare+0x136/0x210
[ 398.404250] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.404663] ? srso_alias_return_thunk+0x5/0xfbef5
[ 398.405079] ? __kthread_parkme+0xce/0xf0
[ 398.405433] ? __pfx_cifs_demultiplex_thread+0x10/0x10 [cifs]
[ 398.406293] kthread+0x18d/0x1d0
[ 398.406582] ? kthread+0xdb/0x1d0
[ 398.406885] ? __pfx_kthread+0x10/0x10
[ 398.407237] ret_from_fork+0x34/0x60
[ 398.407551] ? __pfx_kthread+0x10/0x10
[ 398.407881] ret_from_fork_asm+0x1b/0x30
[ 398.408258] </TASK>
next prev parent reply other threads:[~2023-11-08 16:35 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 11:00 [PATCH 01/14] cifs: print server capabilities in DebugData nspmangalore
2023-10-30 11:00 ` [PATCH 02/14] cifs: add xid to query server interface call nspmangalore
2023-10-31 5:35 ` Bharath SM
2023-10-30 11:00 ` [PATCH 03/14] cifs: reconnect helper should set reconnect for the right channel nspmangalore
2023-10-31 15:27 ` Paulo Alcantara
2023-10-31 18:29 ` Steve French
2023-10-30 11:00 ` [PATCH 04/14] cifs: do not reset chan_max if multichannel is not supported at mount nspmangalore
2023-11-01 2:57 ` Steve French
2023-11-01 3:14 ` Steve French
2023-10-30 11:00 ` [PATCH 05/14] cifs: force interface update before a fresh session setup nspmangalore
2023-11-01 3:14 ` Steve French
2023-10-30 11:00 ` [PATCH 06/14] cifs: handle cases where a channel is closed nspmangalore
2023-11-01 3:09 ` Steve French
2023-11-02 12:26 ` Shyam Prasad N
2023-10-30 11:00 ` [PATCH 07/14] cifs: distribute channels across interfaces based on speed nspmangalore
2023-10-30 11:00 ` [PATCH 08/14] cifs: account for primary channel in the interface list nspmangalore
2023-11-08 15:44 ` Paulo Alcantara
2023-11-08 18:16 ` Steve French
2023-11-08 19:03 ` Paulo Alcantara
2023-10-30 11:00 ` [PATCH 09/14] cifs: add a back pointer to cifs_sb from tcon nspmangalore
2023-11-01 3:30 ` Steve French
2023-11-03 21:03 ` Paulo Alcantara
2023-11-06 16:12 ` Shyam Prasad N
2023-11-06 17:04 ` Shyam Prasad N
[not found] ` <CAH2r5msQLTcdiHBrOKd+q6LPPHW_Jj3QbpFZyZ48CJbrtDqC5w@mail.gmail.com>
[not found] ` <CAH2r5mt4hC5x2w2D46y13j_OtjkJk9_ZaeGXbb7YKukffBk2LQ@mail.gmail.com>
2023-11-06 19:36 ` Fwd: " Steve French
2023-11-08 15:24 ` Paulo Alcantara
2023-11-08 16:11 ` Steve French
2023-10-30 11:00 ` [PATCH 10/14] cifs: reconnect work should have reference on server struct nspmangalore
2023-11-16 17:10 ` Paulo Alcantara
[not found] ` <CAH2r5mtDeP323Z8=9WjCCYVVb9B2AmO5Q4PDtcMz8wxVUCVRBA@mail.gmail.com>
2023-11-16 19:35 ` Paulo Alcantara
2023-10-30 11:00 ` [PATCH 11/14] cifs: handle when server starts supporting multichannel nspmangalore
2023-11-01 3:30 ` Steve French
2023-11-01 15:52 ` Paulo Alcantara
2023-11-04 7:50 ` Shyam Prasad N
2023-11-02 20:28 ` Paulo Alcantara
2023-11-03 0:43 ` Steve French
2023-11-03 20:32 ` Paulo Alcantara
[not found] ` <notmuch-sha1-c3bfa7f4ae0bb24c5ee7cfddb408c2fbeca5d8f7>
2023-11-08 16:02 ` Paulo Alcantara
2023-11-08 19:25 ` Steve French
2023-11-08 19:31 ` Paulo Alcantara
2023-10-30 11:00 ` [PATCH 12/14] cifs: handle when server stops " nspmangalore
2023-11-08 16:35 ` Paulo Alcantara [this message]
[not found] ` <notmuch-sha1-9ed0289358ca5c90903408ad9c0ac0310afee598>
2023-11-08 19:13 ` Paulo Alcantara
2023-11-08 19:41 ` Paulo Alcantara
2023-11-09 11:44 ` Shyam Prasad N
2023-11-09 13:28 ` Paulo Alcantara
2023-11-09 13:49 ` Shyam Prasad N
2023-11-10 4:09 ` Shyam Prasad N
2023-11-11 17:23 ` Paulo Alcantara
2023-11-12 18:52 ` Steve French
[not found] ` <CAH2r5mvG3zLBxknPOuaz9=GarZO6n6bhcduiZHHfiqVYZYJiVQ@mail.gmail.com>
2023-11-12 19:32 ` Paulo Alcantara
2023-10-30 11:00 ` [PATCH 13/14] cifs: display the endpoint IP details in DebugData nspmangalore
2023-10-31 15:18 ` Paulo Alcantara
[not found] ` <notmuch-sha1-260ef7fe7af7face0e1486229c0fda5149fe14e2>
2023-11-01 14:12 ` Paulo Alcantara
2023-11-01 14:19 ` Steve French
2023-11-04 7:44 ` Shyam Prasad N
2023-11-04 19:00 ` Paulo Alcantara
2023-10-30 12:34 ` [PATCH 01/14] cifs: print server capabilities " Bharath SM
2023-10-30 12:40 ` Shyam Prasad N
2023-10-30 12:51 ` Shyam Prasad N
2023-10-30 14:54 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5bb61ab36adbee983a4b1106ee63ec7.pc@manguebit.com \
--to=pc@manguebit.com \
--cc=bharathsm.hsk@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
--cc=sprasad@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.