From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 03/14] sh_eth: simplify link auto-negotiation by ethtool Date: Fri, 6 Jul 2018 21:48:05 +0300 Message-ID: References: <20180704081245.7395-1-vladimir_zapolskiy@mentor.com> <20180704081245.7395-4-vladimir_zapolskiy@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , Geert Uytterhoeven , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org To: Vladimir Zapolskiy , "David S . Miller" Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:33627 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934276AbeGFSsJ (ORCPT ); Fri, 6 Jul 2018 14:48:09 -0400 Received: by mail-wr1-f68.google.com with SMTP id k7-v6so5066849wrq.0 for ; Fri, 06 Jul 2018 11:48:08 -0700 (PDT) In-Reply-To: <20180704081245.7395-4-vladimir_zapolskiy@mentor.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 07/04/2018 11:12 AM, Vladimir Zapolskiy wrote: > There is no need to call a heavyweight phy_start_aneg() for phy > auto-negotiation by ethtool, the phy is already initialized and > link auto-negotiation is started by calling phy_start() from > sh_eth_phy_start() when a network device is opened. > > Signed-off-by: Vladimir Zapolskiy [...] Reviewed-by: Sergei Shtylyov MBR, Sergei