From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: laurent@vivier.eu
Subject: Re: [PATCH 2/4] linux-user: Always use flexible arrays for dirent d_name
Date: Mon, 8 Nov 2021 08:40:33 +0100 [thread overview]
Message-ID: <a5be987c-9c57-26a6-a973-cf0b14a5ccbe@amsat.org> (raw)
In-Reply-To: <20211107124845.1174791-3-richard.henderson@linaro.org>
On 11/7/21 13:48, Richard Henderson wrote:
> We currently use a flexible array member for target_dirent,
> but use incorrectly fixed length arrays for target_dirent64,
> linux_dirent and linux_dirent64.
>
> This requires that we adjust the definition of the VFAT READDIR
> ioctls which hard-code the 256 namelen size into the ioctl constant.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/syscall_defs.h | 6 +++---
> linux-user/syscall.c | 6 ++++--
> 2 files changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-11-08 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 12:48 [PATCH 0/4] linux-user: Fix getdents alignment issues (#704) Richard Henderson
2021-11-07 12:48 ` [PATCH 1/4] linux-user: Split out do_getdents, do_getdents64 Richard Henderson
2021-11-08 7:42 ` Philippe Mathieu-Daudé
2021-11-09 16:45 ` Warner Losh
2021-11-07 12:48 ` [PATCH 2/4] linux-user: Always use flexible arrays for dirent d_name Richard Henderson
2021-11-08 7:40 ` Philippe Mathieu-Daudé [this message]
2021-11-09 16:43 ` Warner Losh
2021-11-07 12:48 ` [PATCH 3/4] linux-user: Fix member types of target_dirent64 Richard Henderson
2021-11-08 7:40 ` Philippe Mathieu-Daudé
2021-11-09 16:44 ` Warner Losh
2021-11-07 12:48 ` [PATCH 4/4] linux-user: Rewrite do_getdents, do_getdents64 Richard Henderson
2021-11-09 16:46 ` [PATCH 0/4] linux-user: Fix getdents alignment issues (#704) Warner Losh
2021-11-10 9:27 ` Richard Henderson
2021-11-10 10:24 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5be987c-9c57-26a6-a973-cf0b14a5ccbe@amsat.org \
--to=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.