All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
Cc: Ch Sai Gowtham <sai.gowtham.ch@intel.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [igt-dev] [PATCH v3 10/12] code_cov_parse_info: fix --show-lines logic
Date: Thu, 14 Apr 2022 14:25:00 +0200	[thread overview]
Message-ID: <a5c0609c589b33fd6f8c546313a4ce5cc19fd38e.1649939026.git.mchehab@kernel.org> (raw)
In-Reply-To: <cover.1649939026.git.mchehab@kernel.org>

From: Mauro Carvalho Chehab <mchehab@kernel.org>

print_code_coverage function needs to first read the number
of lines and then simplify the $file by removing its prefix.

Without that, it ends trying to access an uninitiated value,
leading to warnings and not doing what's expected.

While here, also check if the ln data is valid, just in case
the .info file might have some FN field(s) missing.

Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v3 00/12] at: https://lore.kernel.org/all/cover.1649939026.git.mchehab@kernel.org/

 scripts/code_cov_parse_info | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/code_cov_parse_info b/scripts/code_cov_parse_info
index c8284a297b33..0d9bac38cea9 100755
--- a/scripts/code_cov_parse_info
+++ b/scripts/code_cov_parse_info
@@ -378,8 +378,10 @@ sub print_code_coverage($$$)
 			}
 
 			if ($show_lines) {
+				my $ln = $all_func{$func}{$file}->{ln};
 				$file =~ s,$prefix,linux/,;
-				$name = "$func() from $file:" . $all_func{$func}{$file}->{ln};
+				$name = "$func() from $file";
+				$name .= ":" . $ln if ($ln);
 			} elsif (scalar @keys > 1) {
 				$file =~ s,$prefix,linux/,;
 				$name = "$func() from $file:";
-- 
2.35.1

  parent reply	other threads:[~2022-04-14 12:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 12:24 [igt-dev] [PATCH v3 00/12] code coverage: some improvements Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 01/12] scripts/code_cov*: remove the extensions from them Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 02/12] scripts/code_cov_parse_info: add a tool to parse code coverage info files Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 03/12] scripts/code_cov_gen_report: add support for filtering " Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 04/12] runner: execute code coverage script also from PATH Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 05/12] scripts/meson.build: install code coverage scripts Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 06/12] scripts/code_cov_selftest.sh: test if IGT code coverage is working Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 07/12] docs/code_coverage.md: document the code coverage filter script Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 08/12] scripts/code_cov_parse_info: better handle test name Mauro Carvalho Chehab
2022-04-14 12:24 ` [igt-dev] [PATCH v3 09/12] code_cov_parse_info: fix error handling when opening files Mauro Carvalho Chehab
2022-04-14 12:25 ` Mauro Carvalho Chehab [this message]
2022-04-14 12:25 ` [igt-dev] [PATCH v3 11/12] code_cov_parse_info: add support for exclude filters Mauro Carvalho Chehab
2022-04-14 12:25 ` [igt-dev] [PATCH v3 12/12] code_cov_parse_info: add support for generating html reports Mauro Carvalho Chehab
2022-04-14 12:59 ` [igt-dev] ✗ GitLab.Pipeline: warning for code coverage: some improvements (rev4) Patchwork
2022-04-14 13:17 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-04-14 15:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-04-14 15:49   ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5c0609c589b33fd6f8c546313a4ce5cc19fd38e.1649939026.git.mchehab@kernel.org \
    --to=mauro.chehab@linux.intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    --cc=sai.gowtham.ch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.