From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D6FFC433FE for ; Fri, 15 Oct 2021 14:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 016C560EE5 for ; Fri, 15 Oct 2021 14:47:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240869AbhJOOtf (ORCPT ); Fri, 15 Oct 2021 10:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240967AbhJOOsu (ORCPT ); Fri, 15 Oct 2021 10:48:50 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 285FAC061762; Fri, 15 Oct 2021 07:46:44 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id t11so6526734plq.11; Fri, 15 Oct 2021 07:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iKrtrnYSDksMWdgmUznUR/Q64gwdi8mvvQO4UVqOm9E=; b=Inc1Q7qKweM0tGJP+CWhPMXm+v1Axi75stMnqo37FnW41/u8uhJxSram8OfhxWJmx7 ingaTUh91Stnkx0O8obZeD0ODKeAEBTvLoxyuFRrCsHd8M66Gg9ny36i7KlXtQxFB34I bu13sSJTRQ+p1DB2XGXPOl23hHG9V93RWK/KXQc8Q+KMejYlj1Nj0VaMOdSAfrGUZvhi iIujdDQUwH2Ev7bP2bKX4VAELQlWe/tMlrj6FSetMmjSJRxYctzqpkO9jeE8voBVMUx5 O+EjlmJhNBiUt0b7PGFLNmO6W5v4ZYluSBFJonLeVVk7BM3MtPWUX/bBkdQaGdPiqtKZ FnAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iKrtrnYSDksMWdgmUznUR/Q64gwdi8mvvQO4UVqOm9E=; b=A16bMRT8OeARl4TEYflkaun/Dgs9n+nZfC0FIUb/ZuB9m8Za5IerJbLSv6kpTa4dso m12Ml61rnhZ0Jc9WiTvetuMBmflmXdoSNy645nF41LdVfRn2B4xm6cTEh+K6o/UOzEBA 1Wm2DDeX/+F6WqEYD/ozHAYuzQJcFkVYUbvPrnx3Mpd9xaPT0PqwLicsPivjLBg3E+tX hXVyPDjA7ScAqePinl53iqqymc8a4zY/A+/wLjAPsu1hXVg6SeSfP2ukJzHJh9RPKlA8 0/XHyzKoDFVpDQVta0dx9kppKw/KpPaxzhvuJlCWsF+3b7aOYsHVtPq4EUhVM7IM73/j 9lGA== X-Gm-Message-State: AOAM5304oUnBC2Cmq7ZXxlPiK3NmEbRWwDNBu0906M1H0jo7ceA4RRHE JOM/mtKCL9LvA4GehhGREmI= X-Google-Smtp-Source: ABdhPJyJ8FQ16vD47i4rGFglTPo9H74I0SPwjWN0ikhEg5awUxLojaILYXXw4ixmXnGPJB0ufC3kUw== X-Received: by 2002:a17:90a:c6:: with SMTP id v6mr28477261pjd.172.1634309203633; Fri, 15 Oct 2021 07:46:43 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:4806:9a51:7f4b:9b5c:337a]) by smtp.gmail.com with ESMTPSA id f18sm5293491pfa.60.2021.10.15.07.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 07:46:43 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Jingoo Han , Marc Zyngier , Kishon Vijay Abraham I Subject: [PATCH v2 22/24] PCI: keystone: Use PCI_ERROR_RESPONSE to specify hardware error Date: Fri, 15 Oct 2021 20:09:03 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include PCI_ERROR_RESPONSE along with 0xffffffff in the comment to specify a hardware error. This helps finding where MMIO read error occurs easier to find. Signed-off-by: Naveen Naidu --- drivers/pci/controller/dwc/pci-keystone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 865258d8c53c..25b11610b500 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -748,8 +748,8 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) #ifdef CONFIG_ARM /* * When a PCI device does not exist during config cycles, keystone host gets a - * bus error instead of returning 0xffffffff. This handler always returns 0 - * for this kind of faults. + * bus error instead of returning 0xffffffff (PCI_ERROR_RESPONSE). + * This handler always returns 0 for this kind of faults. */ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE43BC4332F for ; Fri, 15 Oct 2021 14:46:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B70C161041 for ; Fri, 15 Oct 2021 14:46:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B70C161041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9261040586; Fri, 15 Oct 2021 14:46:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YtBUCWTreQMo; Fri, 15 Oct 2021 14:46:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 730D0401BE; Fri, 15 Oct 2021 14:46:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4CB1DC000F; Fri, 15 Oct 2021 14:46:46 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id C9866C000D for ; Fri, 15 Oct 2021 14:46:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AC1DA40806 for ; Fri, 15 Oct 2021 14:46:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LAkJXyIl2CyE for ; Fri, 15 Oct 2021 14:46:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3646040801 for ; Fri, 15 Oct 2021 14:46:44 +0000 (UTC) Received: by mail-pl1-x631.google.com with SMTP id y1so6525580plk.10 for ; Fri, 15 Oct 2021 07:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iKrtrnYSDksMWdgmUznUR/Q64gwdi8mvvQO4UVqOm9E=; b=Inc1Q7qKweM0tGJP+CWhPMXm+v1Axi75stMnqo37FnW41/u8uhJxSram8OfhxWJmx7 ingaTUh91Stnkx0O8obZeD0ODKeAEBTvLoxyuFRrCsHd8M66Gg9ny36i7KlXtQxFB34I bu13sSJTRQ+p1DB2XGXPOl23hHG9V93RWK/KXQc8Q+KMejYlj1Nj0VaMOdSAfrGUZvhi iIujdDQUwH2Ev7bP2bKX4VAELQlWe/tMlrj6FSetMmjSJRxYctzqpkO9jeE8voBVMUx5 O+EjlmJhNBiUt0b7PGFLNmO6W5v4ZYluSBFJonLeVVk7BM3MtPWUX/bBkdQaGdPiqtKZ FnAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iKrtrnYSDksMWdgmUznUR/Q64gwdi8mvvQO4UVqOm9E=; b=dsKWXyx3KkefwM1v78mfKbH5Nko24QsQRFHeCUMgrH8fiBBByxFWPtu+BTGaRw9VDS 6rwjZwcPyj6/BcP313fuIpqzUifwikw/fEjGmfgvQKnXSzcED4mFdK9Y6Eh6yjzBDK32 lbG0cEl8Pu7HmA9RV7tQiljDjUvLlNAUeoPnsPa54p+LqLvYyZXlr11XKF0wuF1WWRIH 09szHt1B/wSoqfNJx9hBMVRM31Wr4L2ErBOr+mCxsrCQj5FKjKhzhYHodGsljz/sWhFo XKXz2+E+cGTU+bkPs33Oq12s/TNQgRk1SSrGX2aarws+GqzXPp8/dy0Z0gH+oP29Nai0 Ewhw== X-Gm-Message-State: AOAM531tleH0hi3TVVOWOD1QJIaszqTRcfDmaUIpJ8Cc/qoyVTcY2Cl0 JDbCm2HUXtMPBAWUeh8gIUc= X-Google-Smtp-Source: ABdhPJyJ8FQ16vD47i4rGFglTPo9H74I0SPwjWN0ikhEg5awUxLojaILYXXw4ixmXnGPJB0ufC3kUw== X-Received: by 2002:a17:90a:c6:: with SMTP id v6mr28477261pjd.172.1634309203633; Fri, 15 Oct 2021 07:46:43 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:4806:9a51:7f4b:9b5c:337a]) by smtp.gmail.com with ESMTPSA id f18sm5293491pfa.60.2021.10.15.07.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 07:46:43 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com Subject: [PATCH v2 22/24] PCI: keystone: Use PCI_ERROR_RESPONSE to specify hardware error Date: Fri, 15 Oct 2021 20:09:03 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Cc: Rob Herring , Lorenzo Pieralisi , Marc Zyngier , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Jingoo Han , linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Include PCI_ERROR_RESPONSE along with 0xffffffff in the comment to specify a hardware error. This helps finding where MMIO read error occurs easier to find. Signed-off-by: Naveen Naidu --- drivers/pci/controller/dwc/pci-keystone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c index 865258d8c53c..25b11610b500 100644 --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -748,8 +748,8 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) #ifdef CONFIG_ARM /* * When a PCI device does not exist during config cycles, keystone host gets a - * bus error instead of returning 0xffffffff. This handler always returns 0 - * for this kind of faults. + * bus error instead of returning 0xffffffff (PCI_ERROR_RESPONSE). + * This handler always returns 0 for this kind of faults. */ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs) -- 2.25.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees