From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84522C433EF for ; Thu, 7 Oct 2021 13:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A1B661090 for ; Thu, 7 Oct 2021 13:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241122AbhJGNMq (ORCPT ); Thu, 7 Oct 2021 09:12:46 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:35766 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233155AbhJGNMh (ORCPT ); Thu, 7 Oct 2021 09:12:37 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F14223FFE9 for ; Thu, 7 Oct 2021 13:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1633612242; bh=JhSvZ4bZ9XDCLRxn5WXaBJyzQncLRhcDh11CxYaApWU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Ssev8JtnHQHs3Uo1y0JyESJ1LF0vVKOGk7MddSRvqDn1nKPgVjgtKjsZrSTUSHV1p rr5ea6VPIqhHsrL0SWS9DZib+ous1r7eLD6KdzjHUq3J1iDFCQloN3kmPF/x+Otfqg pTObyuAR+rIQIq6FZWZoNfS+vSBvaB2PFC+U6EGFaA2k1+5Zz1IP4PCNR9WHpf+SZX d17+NZDC2KRpWsQuI2zv3tb1EYNf7c8ThrfdNsqPxxxIWyUYU8Tv4/LkKEcQcoZhND TIxfGlQjVf8cR53n4vfCYWsqRPC5t9b2uaEtuBTOm4zgZDClUo1bKe653iyZKCiAlG zyMVHjmXTsQaA== Received: by mail-wr1-f69.google.com with SMTP id a10-20020a5d508a000000b00160723ce588so4648472wrt.23 for ; Thu, 07 Oct 2021 06:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JhSvZ4bZ9XDCLRxn5WXaBJyzQncLRhcDh11CxYaApWU=; b=ZnZlOfAciEK9q5BE1PooHTGYXJlyJJIoZVXwMzTktFVwlj21Bg5fSVQHSAZyTceZIM goe1xtQZn3pC7G2on3yTlT9uCggASUfE/RZjmccr7GHF9VkQ2NsszJjGs3hp+CZ3/aqE L8BNVMKVoJ9mI2oH2eTaKv0AxGIVt21QpbSLYIk7FCTQJvUgHwWTOf4rukkLkClJBz8J 1OAPrHxdGd7Vp9L0L/GDZkz1eY+N9s6YG/QEFCtvEbSKXMFCkuYagLqJxGY5PAbg3tM4 yH2prGLrpG0bZCgSydVNUKzwwGYh7Ieep8ypyKSBbP5N5E4afkE/YHnuClVHjsn9Sn/N Nyyw== X-Gm-Message-State: AOAM530zzXrfZWu+nu8uQIW8rK12+gVL+VH2EUv8+sPIP/u2JrkS605n s+JjixAY4tWg/GHclUWMmTU32MHYAf+0rzH3cMIuCm53K4pH3+onKYhdYestnJccy7IEhjfsS4n /btQtOcp31MvB8D7TH+KRBhMMYPyJ2rGcelwvQKvt4A== X-Received: by 2002:a1c:ac86:: with SMTP id v128mr4569222wme.3.1633612241869; Thu, 07 Oct 2021 06:10:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLwRYPKIpB+6rBu8rzxazPdAbZRZWVT14g4gFsnMg69geQZ9M20oFRASa/T2iiTTB4yzVtpw== X-Received: by 2002:a1c:ac86:: with SMTP id v128mr4568961wme.3.1633612239499; Thu, 07 Oct 2021 06:10:39 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-186-13.adslplus.ch. [188.155.186.13]) by smtp.gmail.com with ESMTPSA id v16sm2571457wrq.39.2021.10.07.06.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Oct 2021 06:10:39 -0700 (PDT) Subject: Re: [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , Greg Kroah-Hartman , Mark Kettenis , Philipp Zabel , "Rafael J. Wysocki" , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20211005155923.173399-1-marcan@marcan.st> <20211005155923.173399-2-marcan@marcan.st> <18818eff-87d7-6a53-a4fd-7f3cbf625a0e@canonical.com> <57991dac-196e-a76d-831a-d4ac166bfe29@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Thu, 7 Oct 2021 15:10:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <57991dac-196e-a76d-831a-d4ac166bfe29@marcan.st> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2021 17:26, Hector Martin wrote: > On 06/10/2021 15.56, Krzysztof Kozlowski wrote: >>> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml >>> new file mode 100644 >>> index 000000000000..0304164e4140 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml >>> @@ -0,0 +1,74 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/arm/apple/apple,pmgr.yaml# >> >> Please don't store all Apple-related bindings in bindings/arm/apple, but >> instead group per device type like in most of other bindings. In this >> case - this looks like something close to power domain controller, so it >> should be in bindings/power/ > > This is a controller that, right now, is only used to instantiate device > power management controls, but the controller itself is just a generic > syscon device. Depending on the register range, it could conceivably > encompass other register types (e.g. clock selects) within it, though > I'm not sure I want to do that right now. Apple calls several of these > different register sets as a whole a "PMGR". So I'm not sure if it > really qualifies as "just" a power domain controller. If we want to > restrict this to the power state portion of PMGR, then it might make > sense to call it something more specific... > > See arm/rockchip/pmu.yaml for the setup this is modeled after. > Makes sense now and actually few other designs including Samsung Exynos have it as well. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6BCCC433FE for ; Thu, 7 Oct 2021 13:13:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 893F861090 for ; Thu, 7 Oct 2021 13:13:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 893F861090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QpNGgzEsvd/SGDuufS447QW2d+NaxDWVAczxyG/wD38=; b=PHb4Ka8Ek2MRTi2R6IoKyU7/cv eg32OwL/T2HGy+Qq53anjHr+eFgYbvSWnKIkKOP/4uExwlcojpdJZV3HaXBnvkOKRsJBBsB4L8irU CofPc3U1wGzO9AiWW/vkVzIQN+B4mHKSCydS4+FW6r3kudj8ctIcElUVKCMZ6nXSfaZdRckxbmh0e w8JwmZyhn4ovyrwNOlYglOlRaRkqfJDpJ3547KESM7ifeNo3kHJVsLlDr+V14DRYTwgNGc8dWAlnX J1Ays1750gBs89CC5/PkapQaG7gt0N2uvsdiY9LV+CHJk+vjvV/K7xnAfbJWEC/tE3y99NPP87Hj3 i8DHdBwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYTAm-00HRYw-MN; Thu, 07 Oct 2021 13:10:56 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYTAi-00HRY7-GD for linux-arm-kernel@lists.infradead.org; Thu, 07 Oct 2021 13:10:54 +0000 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id F1AE73FFED for ; Thu, 7 Oct 2021 13:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1633612242; bh=JhSvZ4bZ9XDCLRxn5WXaBJyzQncLRhcDh11CxYaApWU=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Ssev8JtnHQHs3Uo1y0JyESJ1LF0vVKOGk7MddSRvqDn1nKPgVjgtKjsZrSTUSHV1p rr5ea6VPIqhHsrL0SWS9DZib+ous1r7eLD6KdzjHUq3J1iDFCQloN3kmPF/x+Otfqg pTObyuAR+rIQIq6FZWZoNfS+vSBvaB2PFC+U6EGFaA2k1+5Zz1IP4PCNR9WHpf+SZX d17+NZDC2KRpWsQuI2zv3tb1EYNf7c8ThrfdNsqPxxxIWyUYU8Tv4/LkKEcQcoZhND TIxfGlQjVf8cR53n4vfCYWsqRPC5t9b2uaEtuBTOm4zgZDClUo1bKe653iyZKCiAlG zyMVHjmXTsQaA== Received: by mail-wr1-f70.google.com with SMTP id o2-20020a5d4a82000000b00160c6b7622aso4568940wrq.12 for ; Thu, 07 Oct 2021 06:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JhSvZ4bZ9XDCLRxn5WXaBJyzQncLRhcDh11CxYaApWU=; b=F/AFkq1lAJ429k9iGc4h9oCpvVEUohqb+lB+HWRVDZXSXDztKT4zkITf5TjK6gAz0i 1oSpJoZr/bsWonI96pN+tiz180oEPqQXLEv9vnrsuk2D6AYVZl+DA5dv+iQNa2FngEhJ bxMqi6CmrzcUQfz5C4jDn5TbFCQC5Uq4bPy62rR+MB1O/+3zRJq5PtuSTxVzqc5TTu3I mJk5MdgaUDfWNBK8e65oNPFC9iDyOWSdPWZ5qibS/cFXI3Ypl3wArYflcKPwShOtTS8C 7rDdV7YaNGZEgnhoSaY5cg1WQoMmcxiT51YXr5SREHRdk4mWrV/FjNDu42m+9AcYMmwd hi8A== X-Gm-Message-State: AOAM5328vrp/uqT2Q/oFf0J7w3/NyXiIo4yYHzCSmCkqLnn78yirVKCS PusEOKeZB2ln87y2EoIKi8VF7/M6BP+rAOBjL+gm8s0dt618/WFjfKG2a5leScgKRB42X20xTa1 XFz29WFkpPOMztdWpu4PnE8l8YFNUju11RGUALxwkyxZ8Nv64eAke X-Received: by 2002:a1c:ac86:: with SMTP id v128mr4569224wme.3.1633612241870; Thu, 07 Oct 2021 06:10:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLwRYPKIpB+6rBu8rzxazPdAbZRZWVT14g4gFsnMg69geQZ9M20oFRASa/T2iiTTB4yzVtpw== X-Received: by 2002:a1c:ac86:: with SMTP id v128mr4568961wme.3.1633612239499; Thu, 07 Oct 2021 06:10:39 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-186-13.adslplus.ch. [188.155.186.13]) by smtp.gmail.com with ESMTPSA id v16sm2571457wrq.39.2021.10.07.06.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Oct 2021 06:10:39 -0700 (PDT) Subject: Re: [PATCH 1/7] dt-bindings: arm: apple: Add apple,pmgr binding To: Hector Martin , linux-arm-kernel@lists.infradead.org Cc: Marc Zyngier , Rob Herring , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , Greg Kroah-Hartman , Mark Kettenis , Philipp Zabel , "Rafael J. Wysocki" , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20211005155923.173399-1-marcan@marcan.st> <20211005155923.173399-2-marcan@marcan.st> <18818eff-87d7-6a53-a4fd-7f3cbf625a0e@canonical.com> <57991dac-196e-a76d-831a-d4ac166bfe29@marcan.st> From: Krzysztof Kozlowski Message-ID: Date: Thu, 7 Oct 2021 15:10:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <57991dac-196e-a76d-831a-d4ac166bfe29@marcan.st> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_061052_735379_3D953921 X-CRM114-Status: GOOD ( 24.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/10/2021 17:26, Hector Martin wrote: > On 06/10/2021 15.56, Krzysztof Kozlowski wrote: >>> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml >>> new file mode 100644 >>> index 000000000000..0304164e4140 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml >>> @@ -0,0 +1,74 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/arm/apple/apple,pmgr.yaml# >> >> Please don't store all Apple-related bindings in bindings/arm/apple, but >> instead group per device type like in most of other bindings. In this >> case - this looks like something close to power domain controller, so it >> should be in bindings/power/ > > This is a controller that, right now, is only used to instantiate device > power management controls, but the controller itself is just a generic > syscon device. Depending on the register range, it could conceivably > encompass other register types (e.g. clock selects) within it, though > I'm not sure I want to do that right now. Apple calls several of these > different register sets as a whole a "PMGR". So I'm not sure if it > really qualifies as "just" a power domain controller. If we want to > restrict this to the power state portion of PMGR, then it might make > sense to call it something more specific... > > See arm/rockchip/pmu.yaml for the setup this is modeled after. > Makes sense now and actually few other designs including Samsung Exynos have it as well. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel