From: Heinz Mauelshagen <heinzm@redhat.com>
To: heinzm@redhat.com, dm-devel@redhat.com
Subject: [PATCH 5/5] dm-raid: disable bitmap when journaled
Date: Wed, 5 Sep 2018 19:36:45 +0200 [thread overview]
Message-ID: <a5d728db7e1123e0626d44a9c8cf0e2e4ecefe16.1536167421.git.heinzm@redhat.com> (raw)
In-Reply-To: <cover.1536167421.git.heinzm@redhat.com>
In-Reply-To: <cover.1536167421.git.heinzm@redhat.com>
When a journal device for raid4/5/6 is used,
don't create a mutually exclusive write intent bitmap.
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
---
drivers/md/dm-raid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 9754ef24fd0b..1f0e85f6f7e6 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -2472,7 +2472,7 @@ static int super_validate(struct raid_set *rs, struct md_rdev *rdev)
}
/* Enable bitmap creation for RAID levels != 0 */
- mddev->bitmap_info.offset = rt_is_raid0(rs->raid_type) ? 0 : to_sector(4096);
+ mddev->bitmap_info.offset = (rt_is_raid0(rs->raid_type) || rs->journal_dev.dev) ? 0 : to_sector(4096);
mddev->bitmap_info.default_offset = mddev->bitmap_info.offset;
if (!test_and_clear_bit(FirstUse, &rdev->flags)) {
--
2.17.1
prev parent reply other threads:[~2018-09-05 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 17:36 [PATCH 0/5] dm raid: deadlock/corruptor fixes Heinz Mauelshagen
2018-09-05 17:36 ` [PATCH 1/5] dm-raid: fix reshape race on small devices Heinz Mauelshagen
2018-09-05 17:36 ` [PATCH 2/5] dm-raid: fix stripe adding reshape deadlock Heinz Mauelshagen
2018-09-05 17:36 ` [PATCH 3/5] dm-raid: correct explicit superblock update requests Heinz Mauelshagen
2018-09-05 17:36 ` [PATCH 4/5] dm-raid: share decipher_sync_action Heinz Mauelshagen
2018-09-05 17:36 ` Heinz Mauelshagen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5d728db7e1123e0626d44a9c8cf0e2e4ecefe16.1536167421.git.heinzm@redhat.com \
--to=heinzm@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.