From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B619C433EF for ; Tue, 26 Apr 2022 11:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349667AbiDZLwt (ORCPT ); Tue, 26 Apr 2022 07:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236247AbiDZLwt (ORCPT ); Tue, 26 Apr 2022 07:52:49 -0400 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [IPv6:2001:4b7a:2000:18::171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1C8B3C4B8 for ; Tue, 26 Apr 2022 04:49:39 -0700 (PDT) Received: from [10.1.250.9] (riviera.nat.ds.pw.edu.pl [194.29.137.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 66FBB3F67B; Tue, 26 Apr 2022 13:49:35 +0200 (CEST) Message-ID: Date: Tue, 26 Apr 2022 13:49:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 10/10] ARM: dts: msm: Add tpdm mm/prng for sm8250 To: Mao Jinlong , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, Bjorn Andersson References: <20220425040304.37487-1-quic_jinlmao@quicinc.com> <20220425040304.37487-11-quic_jinlmao@quicinc.com> From: Konrad Dybcio In-Reply-To: <20220425040304.37487-11-quic_jinlmao@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25/04/2022 06:03, Mao Jinlong wrote: > Add tpdm mm and tpdm prng for sm8250. > > +---------------+ +-------------+ > | tpdm@6c08000 | |tpdm@684C000 | > +-------|-------+ +------|------+ > | | > +-------|-------+ | > | funnel@6c0b000| | > +-------|-------+ | > | | > +-------|-------+ | > |funnel@6c2d000 | | > +-------|-------+ | > | | > | +---------------+ | > +----- tpda@6004000 -----------+ > +-------|-------+ > | > +-------|-------+ > |funnel@6005000 | > +---------------+ > > Signed-off-by: Mao Jinlong > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 170 +++++++++++++++++++++++++++ > 1 file changed, 170 insertions(+) Hi, some of the previous comments (uppercase hex instead of lowercase and wrong commit title) still haven't been addressed. Konrad > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 53ab2b457a2f..ce558a2639e7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -4703,6 +4703,73 @@ > }; > }; > > + tpda@6004000 { > + compatible = "arm,primecell"; > + reg = <0 0x06004000 0 0x1000>; > + reg-names = "tpda-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + reg = <0>; > + tpda_out_funnel_qatb: endpoint { > + remote-endpoint = <&funnel_qatb_in_tpda>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@9 { > + reg = <9>; > + tpda_9_in_tpdm_mm: endpoint { > + remote-endpoint = <&tpdm_mm_out_tpda9>; > + }; > + }; > + > + port@23 { > + reg = <23>; > + tpda_23_in_tpdm_prng: endpoint { > + remote-endpoint = <&tpdm_prng_out_tpda_23>; > + }; > + }; > + }; > + }; > + > + funnel@6005000 { > + compatible = "arm,primecell"; > + > + reg = <0 0x06005000 0 0x1000>; > + reg-names = "funnel-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + funnel_qatb_out_funnel_in0: endpoint { > + remote-endpoint = <&funnel_in0_in_funnel_qatb>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + funnel_qatb_in_tpda: endpoint { > + remote-endpoint = <&tpda_out_funnel_qatb>; > + }; > + }; > + }; > + }; > + > funnel@6041000 { > compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > reg = <0 0x06041000 0 0x1000>; > @@ -4722,6 +4789,13 @@ > #address-cells = <1>; > #size-cells = <0>; > > + port@6 { > + reg = <6>; > + funnel_in0_in_funnel_qatb: endpoint { > + remote-endpoint = <&funnel_qatb_out_funnel_in0>; > + }; > + }; > + > port@7 { > reg = <7>; > funnel0_in7: endpoint { > @@ -4836,6 +4910,23 @@ > }; > }; > > + tpdm@684C000 { > + compatible = "arm,primecell"; > + reg = <0 0x0684C000 0 0x1000>; > + reg-names = "tpdm-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + tpdm_prng_out_tpda_23: endpoint { > + remote-endpoint = <&tpda_23_in_tpdm_prng>; > + }; > + }; > + }; > + }; > + > funnel@6b04000 { > compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > arm,primecell-periphid = <0x000bb908>; > @@ -4920,6 +5011,85 @@ > }; > }; > > + tpdm@6c08000 { > + compatible = "arm,primecell"; > + reg = <0 0x06c08000 0 0x1000>; > + reg-names = "tpdm-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + tpdm_mm_out_funnel_dl_mm: endpoint { > + remote-endpoint = <&funnel_dl_mm_in_tpdm_mm>; > + }; > + }; > + }; > + }; > + > + funnel@6c0b000 { > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > + > + reg = <0 0x06c0b000 0 0x1000>; > + reg-names = "funnel-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + funnel_dl_mm_out_funnel_dl_center: endpoint { > + remote-endpoint = <&funnel_dl_center_in_funnel_dl_mm>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@3 { > + reg = <3>; > + funnel_dl_mm_in_tpdm_mm: endpoint { > + remote-endpoint = <&tpdm_mm_out_funnel_dl_mm>; > + }; > + }; > + }; > + }; > + > + funnel@6c2d000 { > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > + > + reg = <0 0x06c2d000 0 0x1000>; > + reg-names = "funnel-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port { > + tpdm_mm_out_tpda9: endpoint { > + remote-endpoint = <&tpda_9_in_tpdm_mm>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@2 { > + reg = <2>; > + funnel_dl_center_in_funnel_dl_mm: endpoint { > + remote-endpoint = <&funnel_dl_mm_out_funnel_dl_center>; > + }; > + }; > + }; > + }; > + > etm@7040000 { > compatible = "arm,coresight-etm4x", "arm,primecell"; > reg = <0 0x07040000 0 0x1000>; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2BEDC433EF for ; Tue, 26 Apr 2022 11:50:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SySy098FJ0dL/Gap+79HCFPN/6noQezEDPUBEJALz84=; b=sirXbbaRSjvXLm 5qoMd3eIwUXGDjElk2r1jgS6wR5Tlb1LLxWiXznbgMOM6Q/EedtjDsaxrKgKdNocyaTR3lX1N5FsF vYzFe5yNRbZv2omEtZ+zGHs60jl+kP4KOYDVTi5s8FvmPKGo8EFJmrP9HLO3qaA41LxbdGFfTzEJR AsER1OUuKddxmsfqzuw+u1W03/0zhjn51fPrK2dS4l4iycCgZ1G8KrWcTOMnC1rwG/0XAWZ+oFD0W AzpVR4RchtVQowU8zCrgGDz/9tAqinhmiLy3G5SJS0/lT6vZJgIRWniEcgDo6tGNrDVovFfxDFb/a 9wlzvSf/yQ4DYUOhQIxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njJhW-00E8lK-0E; Tue, 26 Apr 2022 11:49:50 +0000 Received: from m-r2.th.seeweb.it ([5.144.164.171]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njJhR-00E8h2-Ja for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 11:49:48 +0000 Received: from [10.1.250.9] (riviera.nat.ds.pw.edu.pl [194.29.137.1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 66FBB3F67B; Tue, 26 Apr 2022 13:49:35 +0200 (CEST) Message-ID: Date: Tue, 26 Apr 2022 13:49:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 10/10] ARM: dts: msm: Add tpdm mm/prng for sm8250 To: Mao Jinlong , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org, Bjorn Andersson References: <20220425040304.37487-1-quic_jinlmao@quicinc.com> <20220425040304.37487-11-quic_jinlmao@quicinc.com> From: Konrad Dybcio In-Reply-To: <20220425040304.37487-11-quic_jinlmao@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_044946_003368_DE443AE2 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/04/2022 06:03, Mao Jinlong wrote: > Add tpdm mm and tpdm prng for sm8250. > > +---------------+ +-------------+ > | tpdm@6c08000 | |tpdm@684C000 | > +-------|-------+ +------|------+ > | | > +-------|-------+ | > | funnel@6c0b000| | > +-------|-------+ | > | | > +-------|-------+ | > |funnel@6c2d000 | | > +-------|-------+ | > | | > | +---------------+ | > +----- tpda@6004000 -----------+ > +-------|-------+ > | > +-------|-------+ > |funnel@6005000 | > +---------------+ > > Signed-off-by: Mao Jinlong > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 170 +++++++++++++++++++++++++++ > 1 file changed, 170 insertions(+) Hi, some of the previous comments (uppercase hex instead of lowercase and wrong commit title) still haven't been addressed. Konrad > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 53ab2b457a2f..ce558a2639e7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -4703,6 +4703,73 @@ > }; > }; > > + tpda@6004000 { > + compatible = "arm,primecell"; > + reg = <0 0x06004000 0 0x1000>; > + reg-names = "tpda-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + reg = <0>; > + tpda_out_funnel_qatb: endpoint { > + remote-endpoint = <&funnel_qatb_in_tpda>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@9 { > + reg = <9>; > + tpda_9_in_tpdm_mm: endpoint { > + remote-endpoint = <&tpdm_mm_out_tpda9>; > + }; > + }; > + > + port@23 { > + reg = <23>; > + tpda_23_in_tpdm_prng: endpoint { > + remote-endpoint = <&tpdm_prng_out_tpda_23>; > + }; > + }; > + }; > + }; > + > + funnel@6005000 { > + compatible = "arm,primecell"; > + > + reg = <0 0x06005000 0 0x1000>; > + reg-names = "funnel-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + funnel_qatb_out_funnel_in0: endpoint { > + remote-endpoint = <&funnel_in0_in_funnel_qatb>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + funnel_qatb_in_tpda: endpoint { > + remote-endpoint = <&tpda_out_funnel_qatb>; > + }; > + }; > + }; > + }; > + > funnel@6041000 { > compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > reg = <0 0x06041000 0 0x1000>; > @@ -4722,6 +4789,13 @@ > #address-cells = <1>; > #size-cells = <0>; > > + port@6 { > + reg = <6>; > + funnel_in0_in_funnel_qatb: endpoint { > + remote-endpoint = <&funnel_qatb_out_funnel_in0>; > + }; > + }; > + > port@7 { > reg = <7>; > funnel0_in7: endpoint { > @@ -4836,6 +4910,23 @@ > }; > }; > > + tpdm@684C000 { > + compatible = "arm,primecell"; > + reg = <0 0x0684C000 0 0x1000>; > + reg-names = "tpdm-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + tpdm_prng_out_tpda_23: endpoint { > + remote-endpoint = <&tpda_23_in_tpdm_prng>; > + }; > + }; > + }; > + }; > + > funnel@6b04000 { > compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > arm,primecell-periphid = <0x000bb908>; > @@ -4920,6 +5011,85 @@ > }; > }; > > + tpdm@6c08000 { > + compatible = "arm,primecell"; > + reg = <0 0x06c08000 0 0x1000>; > + reg-names = "tpdm-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + tpdm_mm_out_funnel_dl_mm: endpoint { > + remote-endpoint = <&funnel_dl_mm_in_tpdm_mm>; > + }; > + }; > + }; > + }; > + > + funnel@6c0b000 { > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > + > + reg = <0 0x06c0b000 0 0x1000>; > + reg-names = "funnel-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + funnel_dl_mm_out_funnel_dl_center: endpoint { > + remote-endpoint = <&funnel_dl_center_in_funnel_dl_mm>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@3 { > + reg = <3>; > + funnel_dl_mm_in_tpdm_mm: endpoint { > + remote-endpoint = <&tpdm_mm_out_funnel_dl_mm>; > + }; > + }; > + }; > + }; > + > + funnel@6c2d000 { > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > + > + reg = <0 0x06c2d000 0 0x1000>; > + reg-names = "funnel-base"; > + > + clocks = <&aoss_qmp>; > + clock-names = "apb_pclk"; > + > + out-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port { > + tpdm_mm_out_tpda9: endpoint { > + remote-endpoint = <&tpda_9_in_tpdm_mm>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@2 { > + reg = <2>; > + funnel_dl_center_in_funnel_dl_mm: endpoint { > + remote-endpoint = <&funnel_dl_mm_out_funnel_dl_center>; > + }; > + }; > + }; > + }; > + > etm@7040000 { > compatible = "arm,coresight-etm4x", "arm,primecell"; > reg = <0 0x07040000 0 0x1000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel