From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5D36C6FD1F for ; Wed, 22 Mar 2023 15:19:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9330710E97F; Wed, 22 Mar 2023 15:19:26 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 205AD10E97F for ; Wed, 22 Mar 2023 15:19:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 376E9CE1DE0; Wed, 22 Mar 2023 15:19:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8301DC433D2; Wed, 22 Mar 2023 15:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679498358; bh=EEErT/PnRAtdQE0xsUp/GkoJjA2tZIOlkEavkERihSA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=biz9bCMNpkK2ZEQa+eaU+sNLjl7taEonfLGWnhALLtgkorM899mr4nkh/IxFNN3nN nJ8zf6kd9ma1XWWQN723hJBFbunjh7bWY6cNcMki8eHBAltLh6IIJI508urmj1MapD JTUNJwewzxCeo4W5xDNfWE9SRxilevfEGZeplSUxKR8eK6JDEGdZGqtC1yaB/GX/d5 Hm4YlBRnG9Uo9db85S4u3R8JymPLotvxLSzr/8NbFvPABTfLD1D9ZdxDncX/1SKkhB J8j13I8QXDyGwrgpvNRQ/GUh8VH55YjjyNRF38nHR9RbQQi71Z28jdsata/N9enUg3 lfo4mo3dbV8dA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230322100153.gzyznaukbdngcvko@houat> References: <20221018-clk-range-checks-fixes-v2-0-f6736dec138e@cerno.tech> <20230322100153.gzyznaukbdngcvko@houat> Subject: Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes From: Stephen Boyd To: Maxime Ripard Date: Wed, 22 Mar 2023 08:19:16 -0700 User-Agent: alot/0.10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Prashant Gaikwad , Geert Uytterhoeven , Sekhar Nori , Alexandre Torgue , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Paul Cercueil , Max Filippov , Thierry Reding , linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Abel Vesa , Kishon Vijay Abraham I , Samuel Holland , Chunyan Zhang , Takashi Iwai , linux-tegra@vger.kernel.org, Jernej Skrabec , Jonathan Hunter , Chen-Yu Tsai , NXP Linux Team , Orson Zhai , Ulf Hansson , linux-mips@vger.kernel.org, Luca Ceresoli , Michael Turquette , Maxime Coquelin , linux-rtc@vger.kernel.org, linux-clk@vger.kernel.org, Charles Keepax , David Lechner , alsa-devel@alsa-project.org, Manivannan Sadhasivam , linux-kernel@vger.kernel.org, Sascha Hauer , Nicolas Ferre , linux-actions@lists.infradead.org, Richard Fitzgerald , Mark Brown , linux-mediatek@lists.infradead.org, Baolin Wang , Matthias Brugger , Pengutronix Kernel Team , nel.org@freedesktop.org, AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-sunxi@lists.linux.dev, patches@opensource.cirrus.com, Peter De Schrijver , Liam Girdwood , Andreas =?utf-8?q?F=C3=A4rber?= , Dinh Nguyen , Vinod Koul , linux-renesas-soc@vger.ker, Shawn Guo , Claudiu Beznea Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Maxime Ripard (2023-03-22 03:01:53) > Hi Stephen, >=20 > On Tue, Mar 21, 2023 at 04:55:03PM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2022-11-04 06:17:17) > > > Hi, > > >=20 > > > This is a follow-up to a previous series that was printing a warning > > > when a mux has a set_parent implementation but is missing > > > determine_rate(). > > >=20 > > > The rationale is that set_parent() is very likely to be useful when > > > changing the rate, but it's determine_rate() that takes the parenting > > > decision. If we're missing it, then the current parent is always going > > > to be used, and thus set_parent() will not be used. The only exception > > > being a direct call to clk_set_parent(), but those are fairly rare > > > compared to clk_set_rate(). > > >=20 > > > Stephen then asked to promote the warning to an error, and to fix up = all > > > the muxes that are in that situation first. So here it is :) > > >=20 > > > Let me know what you think, > >=20 > > What's the plan here? Are you going to resend? >=20 > It wasn't clear to me whether or not this was something that you wanted, > and I got some pushback on the drivers so I kind of forgot about it. >=20 > If you do want it (and it looks like you do), I'll resend it. Let me read the whole series first. I was ignoring it because I was assuming it was going to be resent. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC148C01 for ; Wed, 22 Mar 2023 15:19:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8301DC433D2; Wed, 22 Mar 2023 15:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679498358; bh=EEErT/PnRAtdQE0xsUp/GkoJjA2tZIOlkEavkERihSA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=biz9bCMNpkK2ZEQa+eaU+sNLjl7taEonfLGWnhALLtgkorM899mr4nkh/IxFNN3nN nJ8zf6kd9ma1XWWQN723hJBFbunjh7bWY6cNcMki8eHBAltLh6IIJI508urmj1MapD JTUNJwewzxCeo4W5xDNfWE9SRxilevfEGZeplSUxKR8eK6JDEGdZGqtC1yaB/GX/d5 Hm4YlBRnG9Uo9db85S4u3R8JymPLotvxLSzr/8NbFvPABTfLD1D9ZdxDncX/1SKkhB J8j13I8QXDyGwrgpvNRQ/GUh8VH55YjjyNRF38nHR9RbQQi71Z28jdsata/N9enUg3 lfo4mo3dbV8dA== Message-ID: Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230322100153.gzyznaukbdngcvko@houat> References: <20221018-clk-range-checks-fixes-v2-0-f6736dec138e@cerno.tech> <20230322100153.gzyznaukbdngcvko@houat> Subject: Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes From: Stephen Boyd Cc: Abel Vesa , Alessandro Zummo , Alexandre Belloni , Alexandre Torgue , Andreas =?utf-8?q?F=C3=A4rber?= , Baolin Wang , Charles Keepax , Chen-Yu Tsai , Chunyan Zhang , Claudiu Beznea , Daniel Vetter , David Airlie , David Lechner , Dinh Nguyen , Fabio Estevam , Geert Uytterhoeven , Jaroslav Kysela , Jernej Skrabec , Jonathan Hunter , Kishon Vijay Abraham I , Liam Girdwood , Linus Walleij , Luca Ceresoli , Manivannan Sadhasivam , Mark Brown
, Matthias Brugger , Max Filippov , Maxime Coquelin , Michael Turquette , NXP Linux Team , Nicolas Ferre , Orson Zhai , Paul Cercueil , Pengutronix Kernel Team , Peter De Schrijver , Prashant Gaikwad , Richard Fitzgerald , Samuel Holland , Sascha Hauer , Sekhar Nori , Shawn Guo , Takashi Iwai , Thierry Reding , Ulf Hansson , Vinod Koul , linux-stm32@st-md-mailman.stormreply.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.ker nel.org, linux-actions@lists.infradead.org, linux-clk@vger.kernel.org, AngeloGioacchino Del Regno , patches@opensource.cirrus.com, linux-tegra@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org To: Maxime Ripard Date: Wed, 22 Mar 2023 08:19:16 -0700 User-Agent: alot/0.10 Quoting Maxime Ripard (2023-03-22 03:01:53) > Hi Stephen, >=20 > On Tue, Mar 21, 2023 at 04:55:03PM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2022-11-04 06:17:17) > > > Hi, > > >=20 > > > This is a follow-up to a previous series that was printing a warning > > > when a mux has a set_parent implementation but is missing > > > determine_rate(). > > >=20 > > > The rationale is that set_parent() is very likely to be useful when > > > changing the rate, but it's determine_rate() that takes the parenting > > > decision. If we're missing it, then the current parent is always going > > > to be used, and thus set_parent() will not be used. The only exception > > > being a direct call to clk_set_parent(), but those are fairly rare > > > compared to clk_set_rate(). > > >=20 > > > Stephen then asked to promote the warning to an error, and to fix up = all > > > the muxes that are in that situation first. So here it is :) > > >=20 > > > Let me know what you think, > >=20 > > What's the plan here? Are you going to resend? >=20 > It wasn't clear to me whether or not this was something that you wanted, > and I got some pushback on the drivers so I kind of forgot about it. >=20 > If you do want it (and it looks like you do), I'll resend it. Let me read the whole series first. I was ignoring it because I was assuming it was going to be resent. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8547FC6FD1C for ; Thu, 23 Mar 2023 13:11:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4A5CBEEF; Thu, 23 Mar 2023 14:11:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4A5CBEEF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1679577112; bh=EEErT/PnRAtdQE0xsUp/GkoJjA2tZIOlkEavkERihSA=; h=In-Reply-To:References:Subject:From:To:Date:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=FGd0ygh1a4zQBye2xRuI3wMd04RPQOUdFtmXYD228avsaeizccG+4b6ZzGQIwqxKu IJF1iJT0YFiNMKX0dXIxXo5mPxlAgWQGeEbg0Le/BEGTXqU6+2YELfg+xQ7XYiC3Tb JkYTASw3LfDWrLUe2nLWFSMHM6gQyfkuA7AzvM7w= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 31ED6F8055B; Thu, 23 Mar 2023 14:10:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 51122F802E8; Wed, 22 Mar 2023 16:19:30 +0100 (CET) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 37E9FF80254 for ; Wed, 22 Mar 2023 16:19:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 37E9FF80254 Authentication-Results: alsa1.perex.cz; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=biz9bCMN Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 376E9CE1DE0; Wed, 22 Mar 2023 15:19:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8301DC433D2; Wed, 22 Mar 2023 15:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679498358; bh=EEErT/PnRAtdQE0xsUp/GkoJjA2tZIOlkEavkERihSA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=biz9bCMNpkK2ZEQa+eaU+sNLjl7taEonfLGWnhALLtgkorM899mr4nkh/IxFNN3nN nJ8zf6kd9ma1XWWQN723hJBFbunjh7bWY6cNcMki8eHBAltLh6IIJI508urmj1MapD JTUNJwewzxCeo4W5xDNfWE9SRxilevfEGZeplSUxKR8eK6JDEGdZGqtC1yaB/GX/d5 Hm4YlBRnG9Uo9db85S4u3R8JymPLotvxLSzr/8NbFvPABTfLD1D9ZdxDncX/1SKkhB J8j13I8QXDyGwrgpvNRQ/GUh8VH55YjjyNRF38nHR9RbQQi71Z28jdsata/N9enUg3 lfo4mo3dbV8dA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230322100153.gzyznaukbdngcvko@houat> References: <20221018-clk-range-checks-fixes-v2-0-f6736dec138e@cerno.tech> <20230322100153.gzyznaukbdngcvko@houat> Subject: Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes From: Stephen Boyd To: Maxime Ripard Date: Wed, 22 Mar 2023 08:19:16 -0700 User-Agent: alot/0.10 X-MailFrom: sboyd@kernel.org X-Mailman-Rule-Hits: max-recipients X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-size; news-moderation; no-subject; digests; suspicious-header Message-ID-Hash: NNEINF7TBJMVA6JLTRS2GI5IAQJMIUPQ X-Message-ID-Hash: NNEINF7TBJMVA6JLTRS2GI5IAQJMIUPQ X-Mailman-Approved-At: Thu, 23 Mar 2023 13:10:00 +0000 CC: Abel Vesa , Alessandro Zummo , Alexandre Belloni , Alexandre Torgue , Andreas =?utf-8?q?F=C3=A4rber?= , Baolin Wang , Charles Keepax , Chen-Yu Tsai , Chunyan Zhang , Claudiu Beznea , Daniel Vetter , David Airlie , David Lechner , Dinh Nguyen , Fabio Estevam , Geert Uytterhoeven , Jernej Skrabec , Jonathan Hunter , Kishon Vijay Abraham I , Liam Girdwood , Linus Walleij , Luca Ceresoli , Manivannan Sadhasivam , Mark Brown , Matthias Brugger , Max Filippov , Maxime Coquelin , Michael Turquette , NXP Linux Team , Nicolas Ferre , Orson Zhai , Paul Cercueil , Pengutronix Kernel Team , Peter De Schrijver , Prashant Gaikwad , Richard Fitzgerald , Samuel Holland , Sascha Hauer , Sekhar Nori , Shawn Guo , Takashi Iwai , Thierry Reding , Ulf Hansson , Vinod Koul , linux-stm32@st-md-mailman.stormreply.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-mips@vger.kernel.org, linux-renesas-soc@vger.ker, nel.org@alsa-project.org, linux-actions@lists.infradead.org, linux-clk@vger.kernel.org, AngeloGioacchino Del Regno , patches@opensource.cirrus.com, linux-tegra@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Quoting Maxime Ripard (2023-03-22 03:01:53) > Hi Stephen, >=20 > On Tue, Mar 21, 2023 at 04:55:03PM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2022-11-04 06:17:17) > > > Hi, > > >=20 > > > This is a follow-up to a previous series that was printing a warning > > > when a mux has a set_parent implementation but is missing > > > determine_rate(). > > >=20 > > > The rationale is that set_parent() is very likely to be useful when > > > changing the rate, but it's determine_rate() that takes the parenting > > > decision. If we're missing it, then the current parent is always going > > > to be used, and thus set_parent() will not be used. The only exception > > > being a direct call to clk_set_parent(), but those are fairly rare > > > compared to clk_set_rate(). > > >=20 > > > Stephen then asked to promote the warning to an error, and to fix up = all > > > the muxes that are in that situation first. So here it is :) > > >=20 > > > Let me know what you think, > >=20 > > What's the plan here? Are you going to resend? >=20 > It wasn't clear to me whether or not this was something that you wanted, > and I got some pushback on the drivers so I kind of forgot about it. >=20 > If you do want it (and it looks like you do), I'll resend it. Let me read the whole series first. I was ignoring it because I was assuming it was going to be resent.