* [PATCH] staging: rtl8723bs: convert function to static
@ 2021-06-23 13:01 Fabio Aiuto
2021-06-23 13:08 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Aiuto @ 2021-06-23 13:01 UTC (permalink / raw)
To: gregkh; +Cc: hdegoede, Larry.Finger, linux-staging, linux-kernel
function chk_sta_is_alive() is used only inside core/rtw_ap.c
so remove the prototype and convert it to static.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 23bbdf084631..3e2d8b735fc8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -164,8 +164,7 @@ static void update_BCNTIM(struct adapter *padapter)
pnetwork_mlmeext->IELength = offset + remainder_ielen;
}
-u8 chk_sta_is_alive(struct sta_info *psta);
-u8 chk_sta_is_alive(struct sta_info *psta)
+static u8 chk_sta_is_alive(struct sta_info *psta)
{
sta_update_last_rx_pkts(psta);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: convert function to static
2021-06-23 13:01 [PATCH] staging: rtl8723bs: convert function to static Fabio Aiuto
@ 2021-06-23 13:08 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-06-23 13:08 UTC (permalink / raw)
To: Fabio Aiuto, gregkh; +Cc: Larry.Finger, linux-staging, linux-kernel
Hi,
On 6/23/21 3:01 PM, Fabio Aiuto wrote:
> function chk_sta_is_alive() is used only inside core/rtw_ap.c
> so remove the prototype and convert it to static.
>
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 23bbdf084631..3e2d8b735fc8 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -164,8 +164,7 @@ static void update_BCNTIM(struct adapter *padapter)
> pnetwork_mlmeext->IELength = offset + remainder_ielen;
> }
>
> -u8 chk_sta_is_alive(struct sta_info *psta);
> -u8 chk_sta_is_alive(struct sta_info *psta)
> +static u8 chk_sta_is_alive(struct sta_info *psta)
> {
> sta_update_last_rx_pkts(psta);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-23 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 13:01 [PATCH] staging: rtl8723bs: convert function to static Fabio Aiuto
2021-06-23 13:08 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.