From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969883AbdIZSGZ (ORCPT ); Tue, 26 Sep 2017 14:06:25 -0400 Received: from mail-bl2nam02on0076.outbound.protection.outlook.com ([104.47.38.76]:23915 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964775AbdIZSGV (ORCPT ); Tue, 26 Sep 2017 14:06:21 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; balister.org; dkim=none (message not signed) header.d=none;balister.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs To: Philip Balister , Moritz Fischer , Michal Simek CC: , , , , , , , , Arnd Bergmann References: <20170911232223.91894-1-mdf@kernel.org> <314acb1f-1f0f-7893-70a8-9379c01112ac@xilinx.com> <20170925161136.GA12943@tyrael.ni.corp.natinst.com> <6b87e902-3201-6710-4921-d465dea19dcd@xilinx.com> <20170926175018.GA14962@tyrael.ni.corp.natinst.com> From: Michal Simek Message-ID: Date: Tue, 26 Sep 2017 20:06:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23352.004 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(376002)(346002)(2980300002)(438002)(377454003)(199003)(24454002)(189002)(110136005)(5660300001)(31686004)(64126003)(8936002)(2950100002)(6246003)(33646002)(4326008)(47776003)(50986999)(77096006)(65956001)(76176999)(65806001)(106466001)(54356999)(229853002)(23746002)(50466002)(81166006)(8676002)(230700001)(63266004)(189998001)(81156014)(356003)(2906002)(36756003)(7416002)(316002)(9786002)(305945005)(6666003)(65826007)(83506001)(86362001)(478600001)(93886005)(53546010)(54906003)(31696002)(58126008)(36386004)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB1932;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT060;1:sgcevhc7XZBsQPHKEz7tKkysVuGZpujxIyy5f4i9r2LcYYINSBTE3zQLI29LITyolEpd6M4/M4tPEzRCLWee2yxHvhA2FqTgRZVbcqPAsZZ8tsVtV0rNVNezU3taEX+w X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 981ca105-ecec-4d9b-176f-08d50509485c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(8251501002)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0201MB1932; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1932;3:j5kkLCZMcG/LbVxrPusK5tHH0V803rtHv0yUJFDwwYtoyw1hX43XCQzAOnll2yykron5HxP+zlarvH9kPrnMcp3gigRtKPQd/3zGKdA+7pbk1dhYX0dNigTxU16LPnErLKwbVNn/NBjbYl6VqN3Y9BxOUeMt7K2NJEdxPimpgGbIkWwKIqCLUEI5aj+53gfhc9FbUTi+8qZSmX3HrBp1ugmZXKypFNttIwIu4Y4fPM68t980IU2aBexqx9/8xpptpYMpnWwnfW536CddMNPdL1MGJWjlvucCefhS5XdJwQhtQXbp+wV3pGEBcpM6EvSqrCeQpUMDDxkC1rMh5nzcUCMNp+Ad7Iq3q42zJlZxqBM=;25:SGqfsByexVdctvlvYXZeOVNAL9oWcAsE9KneD/yWSlF1Op9wlyy1SlmZ203CKfJC/JbTNKOxspAR1YD+ksOeONHc6EyUyzdVQ2COBrUb/191rVstDjOavBX0S2J2Js5MztsMcJJkVwkMlMH+WFGRFsdxdt6IqdwRDj6vXfbZp3IwilR9xweEBLg8jd0ctwJeIh7Z/xb/obVXqYQpPU/uy6s58JOH33znrM9GnQZbtXeI3Ga0GEIRv5Wb6Ll5Wp5++25pTfeKtgD5JZGb0BqP2zgCW3KBuyB+Ji1cyRi/oF27h017L6uQvVgF6jJQ5hLHkIZEEaHRWax9iyyyiFVAcQ== X-MS-TrafficTypeDiagnostic: CY1PR0201MB1932: X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1932;31:GhGWkhT5voCzImGYxdnYxD7IOGcyPcrtNhZCHlkg4kwVjDYcNcIbNNBU67z1B0WT+I0g7/ZjSItw5me/78i+/wCdWAeZk2leujfsEq1Pk9IGuREfuO6AWdD3JWq7fi8VKwR+NlV0wGd1JmfXaW5YVXhGL4arTIa5Tyem6jck7virLPDOcXFNTVe1RQuBUnDhRwmJy3DmSlPjMqSaM36mf19XT0+35o7HfZAfP20hHkA=;20:XRTM+X0AQnomM/mUXnJlGS0Ff7rPOJf/8jJS6Lp7ZjBJPkASBmn1KAIycSRxWKad8ZTNr8EyOtKqZkkSlfceORqHSIl2tK4q2OgrB4xxobwEWe3V8U2u4bwtjN6QoiaSh9k85asdASd6ghRbbxk4+pfk5fW/4Lj3PhoKLIz+BQrl/A6H6x6bJjzc2hpO8ufupAD8XYHvSf/MPwpmdFVIN/rL6nujJ3DMZ3gLaDC2jQGCpJnsv8r1kdQsQTY1sDPA0U1uUWUYtcaJaLtkL0E2fkM2Q4cBhyN6rPtXKPzFI2rME34033U8a9r+VNkjxFYUhvizkG5rWVWbgJxy7/VGW6UJhKXrHszmMa+SNMCTll9t1IH2846hPMG1NEImK7QBw4jnynzUJoU5ZP+9zlgptlb/8+hOA//zydluLJRb6s84i98MkRMX6zmIv4PxXIWQfqAGsEoAfkxOC6U9LbDWI7seN+fEBNvWbukftFaoCC1oJF7k6s8JwSDGeadHyhSN X-Exchange-Antispam-Report-Test: UriScan:(21532816269658); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93004095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0201MB1932;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0201MB1932; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1932;4:swuiPqqceDko/W4aQy9tpIh377JcgireGHDeRO5qkrJPRhGo+f/kyxEVZir90TgRQ1wzdhTLwqMG8QskWVHpn6LZBDSf4FyOj5+kX0L6ot6mszsPFMNnD9saLNUEFBwuuCsn+Jkq9bDXWDS0eHl8TdfOXdzjwueQXkDo82IFWffKRVVXr7ioBFfyiHXXW44DM+L++HQIrdmLBX1i2xyjtCsGbHJaf4UTHL47D0uqBHlaWPvOiGAHB5tEhfWHwd587lJN5/15odXW1UxUrfybA5k8pFczqxgF8LyaT72Oego= X-Forefront-PRVS: 0442E569BC X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR0201MB1932;23:urabnkEt81bjazvYuCm9LSY9vwE/gC/SwHw?= =?Windows-1252?Q?PsOc1yN9WIwutn86QUTLDzCFHec4nT44fYtq2R61Vd+3azBiEpmZI/bc?= =?Windows-1252?Q?nsoeSQc1PKaybn5eeApks3oTUiHuMuHSKiqIUztiHqjgc59NxSU3OGyv?= =?Windows-1252?Q?Mb5Mw+EsH9C6TH+/HO/7x+K27GJtSj3RltLreS2sz5dnf7rPzWDav9dr?= =?Windows-1252?Q?28hTOJIvx8OP00hQoF+8Jr7lirn8UWIWT4v3C5D+0P5WBhAbcz4ve4n3?= =?Windows-1252?Q?MiCOsG0AESehzC7hrJhLidchAJSz+myG0o3WbfAuuktOVyg+huPZ+5ZI?= =?Windows-1252?Q?+iF+D93hIulUbJMxun+f8xs8M8x/Eou34bfM/Eelv6GzPjtvOO1rVVqO?= =?Windows-1252?Q?fqjVWNGbv7jpcIlvZihRCWfkP76j+uwwoA4x4HQlVNLEMeaSaJTsAqCi?= =?Windows-1252?Q?03xczoKilPLXLngax23kEpv+Ejjj9q2g9uLCz8tkJVdjUbqAWRc/QLCI?= =?Windows-1252?Q?yt8plZFUZQHE4LDU3Y9QCLaBKd+FbgyEBf+Ko1vAqGgaTVaqnIsz72fj?= =?Windows-1252?Q?QBeDiZdk9TOHhYoq2S6jp/QnAcg3OpPHvwHPcpoiDaJ+3BgXTLChrGD7?= =?Windows-1252?Q?xyZ+RTs6coDWHEH91Jl28c/E+a0UtQw2ivnLcjmdHEI7C+0cNVubwNlQ?= =?Windows-1252?Q?SBRjiIT1+b6WjRLRf0S+heYdsm8HJ3W6bbUYIw1m3Xnd6bq9M/Yy3G5B?= =?Windows-1252?Q?oxB3WlTGmXGxMv78PlHkrqYqPlvNiQpMvOOJGED8JFNNBMMKRM6ITXzw?= =?Windows-1252?Q?VqeljBOqt1inhoNzRTWuH3A4ZS+TMMaub4ZIPaDuQn/BQqOTuGLe0OfY?= =?Windows-1252?Q?k4/uBJnT8DhDYYIHUNmabPS72lMqWNupgWn+c6iF8fEf2wYS/BXe+iNK?= =?Windows-1252?Q?KGMBhus337pFwPwp5fTUxGhTZJFG2RyvSUl1XgPLEFHF3zl/UyOv+q42?= =?Windows-1252?Q?lIJDXCXL2+xZ1k8njXEk5rRA8g0lVeQH7oUumEK6vTdb4WtEueOaWUC6?= =?Windows-1252?Q?mtIoWEiHIn0S1R4G02sr3zEvo6xj+GstOyFOOJPpksgbarJTkZsnLs0h?= =?Windows-1252?Q?N4iSLHyJZMA2wM+MoYHPE3zcKzYv+K8bYdNtxul2Rz4pkR8gxg+mbYnE?= =?Windows-1252?Q?WQBf62X8RLPoqM/gOgYDiXplkJGtntny/Ro2SHYvwfr1F4HSoY/kFNkn?= =?Windows-1252?Q?pr1lfDbjluMBbBEWlYLapeG/TQ4lGtafhfXHGeaRmEhavrDxQ03IzlnO?= =?Windows-1252?Q?vIpexZsP2p70N7b1D8xnhKRdVC+ip7J1QMxFo9+xHM197InYQQNKcSkC?= =?Windows-1252?Q?naAa0Ql3ZNjKZ3Rc9AnNcHM4AWowSwFej0Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB1932;6:+0jh3kXKAGnVcfVjppH+EEwpVChFeiP5RBb+4sUrFFIyf7QrAv2mmuftvMbaxoslSH13FfvfFdTkKocghJRtS/f7b6I5wRYYtx+iuz95yUbPwqRXwKMxbj/fFILyuddKy14rdQr6sFH7AtklGWQyzouMBY/cXAL5bOU60ALv8sPtUevQjAsgTV0c4Sr3i4CoReqagecsJi2n8PwuB6B1FwmD/y6YUHJ4pOK6Hs9WXaBwNUkokVZPM7BuYtegE/6pzFN6LDL0Az6zbvOSA+2hlyTYlhCq/V5tR6ND7xKOIDhQeoZYrh9ntI3VqlMswqQSPfeLWHjop6GBnRFbByilgA==;5:aqjBg6aU+CX/5S2MeADcviIEZO9yM+mH+VUKefFuP/JzgpyTFVoXc4NMYkBV7JgEAPN9iwI3MOxqQrbs0GPsJYOQPn5acdOOy9oBJaw2GKwc55Ew+4VBmvGnB4HY5apBo6rASHOODxGhdx/28UMhXg==;24:AT+0f3PU+Gz9RxLukhFTZIoArUG7xv9JcxOG2lOPe3ICRAArYegDxatEefsoKAsgmn62YyYuZUhszak/Xs1/AYBj+I6RtnC0PsplWeNp0qk=;7:sjk8eV+mwpxz4/R7g5Ig3UNNJ3W18wjTs53NRmuoFvqzw1Abm6zJVii6BVr5wVAYLJSyP8iHvafDi5kKmaT/1opfdlKRutv+jwi+CSUSjek5SEPkF/OBhgOSTQSGK6gJsd1mLbM7eZ7n7douu2SH0nsnmlDR7EUltxj/P0FD2uW6DudiIy17eBp9i6B3Krui2jDOuHgB97tZR6nzD7Gu58FAjWR7sAy+enYnTzJoyLA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 18:06:16.4632 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1932 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.9.2017 19:58, Philip Balister wrote: > On 09/26/2017 01:50 PM, Moritz Fischer wrote: >> Michal, >> >> On Tue, Sep 26, 2017 at 02:54:48PM +0200, Michal Simek wrote: >>> Hi, >>> >>> On 25.9.2017 18:11, Moritz Fischer wrote: >>>> Hi Michal, >>>> >>>> On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: >>>>> Hi Moritz >>>>> >>>>> sorry for delay. >>>> >>>> No problem. >>>> >>>>> >>>>> On 12.9.2017 01:22, Moritz Fischer wrote: >>>>>> Add support for the National Instruments Project Sulfur SDR >>>>>> motherboards Rev 2,3 and 4. >>>>>> >>>>>> Signed-off-by: Moritz Fischer >>>>>> --- >>>>>> arch/arm/boot/dts/Makefile | 3 + >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts | 84 +++++++++++++++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts | 118 ++++++++++++++++++++++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts | 26 ++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur.dtsi | 133 ++++++++++++++++++++++++++++++ >>>>>> 5 files changed, 364 insertions(+) >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur.dtsi >>>>> >>>>> Is this publicly available board? >>>> >>>> Will be in Q1 2018 was announced at GRCon'17 ([1]). >>>> Some of the Rev3s are currently deployed in Norway as part of a radar >>>> system. >>>> >>>>> I am not quite sure we should apply these dts files. There are a lot of >>>>> boards with zynq and there must be any strong argument for applying this >>>>> to the tree. For arm32 with even flat tree structure. >>>> >>>> What's the issue with merging them, except for having 3 more files? >>> >>> For me this is not a problem because on Linux side it is not increasing >>> build time. >>> I want to see the value for community. All xilinx platforms are >>> evaluation generic purpose boards which are showing how to connect stuff >>> together. >>> On the other hand this is real product. >> >> Uh. >> >>> I would let arm-soc maintainer to decide if this is fine or not. I >>> definitely don't want to end up in situation that we will have dts for >>> real products which are not bringing any value for others. >> >> Sure, it's the maintainers call. >> >> I do intend to have my customers run mainline on it eventually, currently >> I'm a handful of patches away from making that happen. So yes, running >> mainline is a usecase that matters to me. >> >> It is one thing to keep bitching about vendor kernels as a community >> continuously, but then if someone goes through the effort and actually >> tries to run mainline, you give them crap like that above. >> >> Our products usually come with full schematics [1], firmware, fpga code and all >> available, I don't know what makes them less useful to the community as a >> platform to experiment and develop on than Xilinx eval boards. >> >> There's several people that I know of both hobbyists and companies that >> build systems around these platforms, so I don't know ... > > I expect this product to be delivered with full source and a mainline > kernel, so lets make it easy for Moritz to do the right thing here. This > makes long term support of this product much easier. > > Acked-by: Philip Balister I think this is the right way to go. Get ACK from Arnd or Olof or Kevin and I will merge this. I am simply just afraid that if a lot of zynq customers will ask for it we can will end up with a lot of zynq/zynqmp based dts files in the kernel and arm-soc guys will stop this that it is simply too much and won't accept +1 case. Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs Date: Tue, 26 Sep 2017 20:06:08 +0200 Message-ID: References: <20170911232223.91894-1-mdf@kernel.org> <314acb1f-1f0f-7893-70a8-9379c01112ac@xilinx.com> <20170925161136.GA12943@tyrael.ni.corp.natinst.com> <6b87e902-3201-6710-4921-d465dea19dcd@xilinx.com> <20170926175018.GA14962@tyrael.ni.corp.natinst.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Philip Balister , Moritz Fischer , Michal Simek Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann List-Id: devicetree@vger.kernel.org On 26.9.2017 19:58, Philip Balister wrote: > On 09/26/2017 01:50 PM, Moritz Fischer wrote: >> Michal, >> >> On Tue, Sep 26, 2017 at 02:54:48PM +0200, Michal Simek wrote: >>> Hi, >>> >>> On 25.9.2017 18:11, Moritz Fischer wrote: >>>> Hi Michal, >>>> >>>> On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: >>>>> Hi Moritz >>>>> >>>>> sorry for delay. >>>> >>>> No problem. >>>> >>>>> >>>>> On 12.9.2017 01:22, Moritz Fischer wrote: >>>>>> Add support for the National Instruments Project Sulfur SDR >>>>>> motherboards Rev 2,3 and 4. >>>>>> >>>>>> Signed-off-by: Moritz Fischer >>>>>> --- >>>>>> arch/arm/boot/dts/Makefile | 3 + >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts | 84 +++++++++++++++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts | 118 ++++++++++++++++++++++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts | 26 ++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur.dtsi | 133 ++++++++++++++++++++++++++++++ >>>>>> 5 files changed, 364 insertions(+) >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur.dtsi >>>>> >>>>> Is this publicly available board? >>>> >>>> Will be in Q1 2018 was announced at GRCon'17 ([1]). >>>> Some of the Rev3s are currently deployed in Norway as part of a radar >>>> system. >>>> >>>>> I am not quite sure we should apply these dts files. There are a lot of >>>>> boards with zynq and there must be any strong argument for applying this >>>>> to the tree. For arm32 with even flat tree structure. >>>> >>>> What's the issue with merging them, except for having 3 more files? >>> >>> For me this is not a problem because on Linux side it is not increasing >>> build time. >>> I want to see the value for community. All xilinx platforms are >>> evaluation generic purpose boards which are showing how to connect stuff >>> together. >>> On the other hand this is real product. >> >> Uh. >> >>> I would let arm-soc maintainer to decide if this is fine or not. I >>> definitely don't want to end up in situation that we will have dts for >>> real products which are not bringing any value for others. >> >> Sure, it's the maintainers call. >> >> I do intend to have my customers run mainline on it eventually, currently >> I'm a handful of patches away from making that happen. So yes, running >> mainline is a usecase that matters to me. >> >> It is one thing to keep bitching about vendor kernels as a community >> continuously, but then if someone goes through the effort and actually >> tries to run mainline, you give them crap like that above. >> >> Our products usually come with full schematics [1], firmware, fpga code and all >> available, I don't know what makes them less useful to the community as a >> platform to experiment and develop on than Xilinx eval boards. >> >> There's several people that I know of both hobbyists and companies that >> build systems around these platforms, so I don't know ... > > I expect this product to be delivered with full source and a mainline > kernel, so lets make it easy for Moritz to do the right thing here. This > makes long term support of this product much easier. > > Acked-by: Philip Balister I think this is the right way to go. Get ACK from Arnd or Olof or Kevin and I will merge this. I am simply just afraid that if a lot of zynq customers will ask for it we can will end up with a lot of zynq/zynqmp based dts files in the kernel and arm-soc guys will stop this that it is simply too much and won't accept +1 case. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: michal.simek@xilinx.com (Michal Simek) Date: Tue, 26 Sep 2017 20:06:08 +0200 Subject: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs In-Reply-To: References: <20170911232223.91894-1-mdf@kernel.org> <314acb1f-1f0f-7893-70a8-9379c01112ac@xilinx.com> <20170925161136.GA12943@tyrael.ni.corp.natinst.com> <6b87e902-3201-6710-4921-d465dea19dcd@xilinx.com> <20170926175018.GA14962@tyrael.ni.corp.natinst.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26.9.2017 19:58, Philip Balister wrote: > On 09/26/2017 01:50 PM, Moritz Fischer wrote: >> Michal, >> >> On Tue, Sep 26, 2017 at 02:54:48PM +0200, Michal Simek wrote: >>> Hi, >>> >>> On 25.9.2017 18:11, Moritz Fischer wrote: >>>> Hi Michal, >>>> >>>> On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: >>>>> Hi Moritz >>>>> >>>>> sorry for delay. >>>> >>>> No problem. >>>> >>>>> >>>>> On 12.9.2017 01:22, Moritz Fischer wrote: >>>>>> Add support for the National Instruments Project Sulfur SDR >>>>>> motherboards Rev 2,3 and 4. >>>>>> >>>>>> Signed-off-by: Moritz Fischer >>>>>> --- >>>>>> arch/arm/boot/dts/Makefile | 3 + >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts | 84 +++++++++++++++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts | 118 ++++++++++++++++++++++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts | 26 ++++++ >>>>>> arch/arm/boot/dts/zynq-ni-sulfur.dtsi | 133 ++++++++++++++++++++++++++++++ >>>>>> 5 files changed, 364 insertions(+) >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur-rev4.dts >>>>>> create mode 100644 arch/arm/boot/dts/zynq-ni-sulfur.dtsi >>>>> >>>>> Is this publicly available board? >>>> >>>> Will be in Q1 2018 was announced at GRCon'17 ([1]). >>>> Some of the Rev3s are currently deployed in Norway as part of a radar >>>> system. >>>> >>>>> I am not quite sure we should apply these dts files. There are a lot of >>>>> boards with zynq and there must be any strong argument for applying this >>>>> to the tree. For arm32 with even flat tree structure. >>>> >>>> What's the issue with merging them, except for having 3 more files? >>> >>> For me this is not a problem because on Linux side it is not increasing >>> build time. >>> I want to see the value for community. All xilinx platforms are >>> evaluation generic purpose boards which are showing how to connect stuff >>> together. >>> On the other hand this is real product. >> >> Uh. >> >>> I would let arm-soc maintainer to decide if this is fine or not. I >>> definitely don't want to end up in situation that we will have dts for >>> real products which are not bringing any value for others. >> >> Sure, it's the maintainers call. >> >> I do intend to have my customers run mainline on it eventually, currently >> I'm a handful of patches away from making that happen. So yes, running >> mainline is a usecase that matters to me. >> >> It is one thing to keep bitching about vendor kernels as a community >> continuously, but then if someone goes through the effort and actually >> tries to run mainline, you give them crap like that above. >> >> Our products usually come with full schematics [1], firmware, fpga code and all >> available, I don't know what makes them less useful to the community as a >> platform to experiment and develop on than Xilinx eval boards. >> >> There's several people that I know of both hobbyists and companies that >> build systems around these platforms, so I don't know ... > > I expect this product to be delivered with full source and a mainline > kernel, so lets make it easy for Moritz to do the right thing here. This > makes long term support of this product much easier. > > Acked-by: Philip Balister I think this is the right way to go. Get ACK from Arnd or Olof or Kevin and I will merge this. I am simply just afraid that if a lot of zynq customers will ask for it we can will end up with a lot of zynq/zynqmp based dts files in the kernel and arm-soc guys will stop this that it is simply too much and won't accept +1 case. Thanks, Michal