From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v3 8/9] autotest: update autotest test case
	list
Date: Tue, 17 Jul 2018 11:10:51 +0100
Message-ID: <a60a64a7-2861-27c4-484a-db9ba8b1cf9d@intel.com>
References: <cover.1528404133.git.anatoly.burakov@intel.com>
 <1531750337-4708-9-git-send-email-reshma.pattan@intel.com>
 <e8b5eb1e-7cff-28d7-dc97-591f3c97d23b@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A373471@IRSMSX109.ger.corp.intel.com>
 <1cf3a907-a8e4-6675-bdd0-31176c01a7ff@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A3734C2@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3734C2@IRSMSX109.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 17-Jul-18 10:45 AM, Pattan, Reshma wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Burakov, Anatoly
>> Sent: Tuesday, July 17, 2018 10:23 AM
>> To: Pattan, Reshma <reshma.pattan@intel.com>; thomas@monjalon.net;
>> dev@dpdk.org
>> Cc: Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
>> stable@dpdk.org
>> Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list
>>
>> On 17-Jul-18 10:18 AM, Pattan, Reshma wrote:
>>> Hi,
>>>
>>>> -----Original Message-----
>>>> From: Burakov, Anatoly
>>>> Sent: Monday, July 16, 2018 4:16 PM
>>>> To: Pattan, Reshma <reshma.pattan@intel.com>; thomas@monjalon.net;
>>>> dev@dpdk.org
>>>> Cc: Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
>>>> stable@dpdk.org
>>>> Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list
>>>>
>>>>
>>>>> +        {
>>>>> +        "Name":    "Set rxtx mode",
>>>>> +        "Command": "set_rxtx_mode",
>>>>> +        "Func":    default_autotest,
>>>>> +        "Report":  None,
>>>>> +    },
>>>>> +    {
>>>>> +        "Name":    "Set rxtx anchor",
>>>>> +        "Command": "set_rxtx_anchor",
>>>>> +        "Func":    default_autotest,
>>>>> +        "Report":  None,
>>>>> +    },
>>>>> +    {
>>>>> +        "Name":    "Set rxtx sc",
>>>>> +        "Command": "set_rxtx_sc",
>>>>> +        "Func":    default_autotest,
>>>>> +        "Report":  None,
>>>>> +    },
>>>>
>>>> The above three tests don't look like autotests to me. I have no idea
>>>> what they are for, but either they need a special function, or they
>>>> need to be taken out.
>>>>
>>>
>>> These commands needs to be run manually from test cmd prompt to
>> various set rxtx mode, rxtx rate and rxtx direction .
>>> These can be used to verify pmd perf test  with vaiours set of above values.
>>>
>>> So this can be removed from autotest.
>>
>> We do have PMD perf tests in the script - do they call these functions?
>> If they are required for PMD autotests, maybe PMD autotests deserve a
>> special test function calling these commands before running the tests?
>>
>> (if they also work without these commands, then we can perhaps postpone
>> this to 18.11)
>>
> 
> I ran pmd perf test manually and it passes without having to use above set_rxtx commands.
> 
> Thanks,
> Reshma
> 
Great.

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly