From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2D50C43331 for ; Fri, 6 Sep 2019 12:20:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE9D8214E0 for ; Fri, 6 Sep 2019 12:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404648AbfIFMUf (ORCPT ); Fri, 6 Sep 2019 08:20:35 -0400 Received: from smtprelay0137.hostedemail.com ([216.40.44.137]:37610 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732863AbfIFMUe (ORCPT ); Fri, 6 Sep 2019 08:20:34 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 891AF52C8; Fri, 6 Sep 2019 12:20:33 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: hope21_3ed998ba99338 X-Filterd-Recvd-Size: 3203 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Fri, 6 Sep 2019 12:20:31 +0000 (UTC) Message-ID: Subject: Re: [PATCH] docs: license-rules.txt: cover SPDX headers on Python scripts From: Joe Perches To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , Linux Media Mailing List , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Jonathan Corbet , Jessica Yu , Federico Vaga , Thomas Gleixner , linux-doc@vger.kernel.org Date: Fri, 06 Sep 2019 05:20:30 -0700 In-Reply-To: <20190906083457.7e7934ec@coco.lan> References: <20190905055614.7958918b@coco.lan> <88e638eb959095ab6657d295f9f8c27169569bf2.1567675272.git.mchehab+samsung@kernel.org> <20190905092703.GA30899@kroah.com> <20190905090701.37dcf75e@coco.lan> <20190906083457.7e7934ec@coco.lan> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-09-06 at 08:34 -0300, Mauro Carvalho Chehab wrote: > I did some changes on it, plus one change at the pedantic mode of > scripts/spdxcheck.py, and placed the corresponding patches at: > > https://git.linuxtv.org/mchehab/experimental.git/log/?h=spdx_pedantic Overall seems very nice, thanks. Couple nits. Some of the scripts and py files move the author block into a description or add unnecessary blank comments. These may use some manual fixups. For instance: diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh index f12a4e2..ff610ec 100755 --- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh +++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh @@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # probe libc's inet_pton & backtrace it with ping # Installs a probe on libc's inet_pton function, that will use uprobes, @@ -6,8 +7,6 @@ # with the a backtrace 3 levels deep, check that it is what we expect. # This needs no debuginfo package, all is done using the libc ELF symtab # and the CFI info in the binaries. - -# SPDX-License-Identifier: GPL-2.0 # Arnaldo Carvalho de Melo , 2017 . $(dirname $0)/lib/probe.sh and diff --git a/tools/testing/selftests/bpf/tcp_client.py b/tools/testing/selftests/bpf/tcp_client.py index a53ed58..c2ee17d 100755 --- a/tools/testing/selftests/bpf/tcp_client.py +++ b/tools/testing/selftests/bpf/tcp_client.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 -# # SPDX-License-Identifier: GPL-2.0 # +# > what's the "very first line" where a > SPDX header tag should be on a man page? Beats me. This says man pages are documents, https://spdx.org/rdf/ontology/spdx-2-0-rev-7/individuals/usageType_document___85292652.html