All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] x86: baytrail: Use macros instead of magic numbers for FSP settings
Date: Wed, 31 May 2017 10:40:18 +0200	[thread overview]
Message-ID: <a612e0f7-85fc-e5b5-c6ac-6a5fe65f9d3d@denx.de> (raw)
In-Reply-To: <1496217855-8745-3-git-send-email-bmeng.cn@gmail.com>

On 31.05.2017 10:04, Bin Meng wrote:
> Introduce various meaningful macros for FSP settings and switch over
> to use them instead of magic numbers.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Looks very good, much more descriptive this way. Thanks for working
on this. :)

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

  reply	other threads:[~2017-05-31  8:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31  8:04 [U-Boot] [PATCH 1/4] x86: baytrail: Change "fsp, mrc-init-tseg-size" default value to 1 Bin Meng
2017-05-31  8:04 ` [U-Boot] [PATCH 2/4] x86: baytrail: Remove "serial-debug-port-*" settings Bin Meng
2017-05-31  8:18   ` Stefan Roese
2017-06-01  3:12   ` Simon Glass
2017-06-01  8:34     ` Bin Meng
2017-05-31  8:04 ` [U-Boot] [PATCH 3/4] x86: baytrail: Use macros instead of magic numbers for FSP settings Bin Meng
2017-05-31  8:40   ` Stefan Roese [this message]
2017-06-01  3:12   ` Simon Glass
2017-06-01  8:34     ` Bin Meng
2017-05-31  8:04 ` [U-Boot] [PATCH 4/4] x86: baytrail: Change lpe/lpss-sio/scc FSP properties to integer Bin Meng
2017-05-31  8:41   ` Stefan Roese
2017-06-01  3:12   ` Simon Glass
2017-06-01  8:34     ` Bin Meng
2017-05-31  8:18 ` [U-Boot] [PATCH 1/4] x86: baytrail: Change "fsp, mrc-init-tseg-size" default value to 1 Stefan Roese
2017-05-31  9:18   ` Bin Meng
2017-05-31  9:22     ` Stefan Roese
2017-06-01  3:12 ` Simon Glass
2017-06-01  8:34   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a612e0f7-85fc-e5b5-c6ac-6a5fe65f9d3d@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.