Re: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

On 01/04/2017 03:20 PM, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Jan 2, 2017 at 11:27 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
>>
>>
>> On 12/12/2016 23:42, Marc-André Lureau wrote:
>>>
>>> Note: this series has been tested with Linux and cross-building with
>>> mingw. It mostly breaks on other platforms,
>>
>> What breaks exactly?
>>
>>
> Not much that I know. I was afraid it would break on BSD (in particular the
> move to own file and last patch), so I tested on FreeBSD. The last version
> of the series works on win32, linux and freebsd. It can be found on
> https://github.com/elmarco/qemu/commits/chrfe It's slightly over 80 patches
> now, and needs some win32 fixes I sent earlier (subprocess tests, and
> main-loop busy loop fix)
> 
> Since Erik started reviewing the series, I suggest to resend the first part
> until "qom-ify" patch. Erik, feel free to review the remaining part of the
> WIP series, but more changes happened after iirc. What do you think?

It's Eric (but you're not the first, and probably not the last).  The
qom-ify patch is 15/54, right? Okay, I'll complete my review up to that
point, and then you can split the series into two: a v2 through qom-ify
(which should probably be ready to go, or only very little to change),
and the second half which is still the WIP.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]