All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Update min() to min_t()
Date: Tue, 21 Sep 2021 21:11:25 +0200	[thread overview]
Message-ID: <a6185b27-a461-84e4-1301-485b88cddd02@gmail.com> (raw)
In-Reply-To: <YUl1067kvLA5KkGC@kroah.com>

On 9/21/21 8:04 AM, Greg KH wrote:
> On Tue, Sep 21, 2021 at 07:52:46AM +0200, Philipp Hortmann wrote:
>> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
>> index 2dc58766273a..d87deee3e26e 100644
>> --- a/drivers/usb/usb-skeleton.c
>> +++ b/drivers/usb/usb-skeleton.c
>> @@ -363,7 +363,7 @@ static ssize_t skel_write(struct file *file, const char *user_buffer,
>>   	int retval = 0;
>>   	struct urb *urb = NULL;
>>   	char *buf = NULL;
>> -	size_t writesize = min(count, (size_t)MAX_TRANSFER);
>> +	size_t writesize = min_t(size_t, count, MAX_TRANSFER);
>>   
>>   	dev = file->private_data;
>>   
>> -- 
>> 2.25.1
>>
> 
> Has anyone actually built this driver in a while?
> 
> thanks,
> 
> greg k-h
> 
Hi,

I have build and loaded the driver. To me this seems OK.

dmesg from loading:
usb_skeleton: loading out-of-tree module taints kernel.
usb_skeleton: module verification failed: signature and/or required key 
missing - tainting kernel
usbcore: registered new interface driver skeleton

dmesg from unloading:
usbcore: deregistering interface driver skeleton

Used kernel 5.15.0-rc1+

Bye Philipp



  reply	other threads:[~2021-09-21 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21  5:52 [PATCH] Update min() to min_t() Philipp Hortmann
2021-09-21  6:04 ` Greg KH
2021-09-21 19:11   ` Philipp Hortmann [this message]
2021-09-22  5:58     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6185b27-a461-84e4-1301-485b88cddd02@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.