From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick DELAUNAY <patrick.delaunay@foss.st.com>
Date: Tue, 9 Feb 2021 20:51:26 +0100
Subject: [PATCH] usb: dwc2: change compatible st,stm32mp1-hsotg to
 st,stm32mp15-hsotg
In-Reply-To: <804006bd-a6bc-0352-374d-6d2b33e42db9@denx.de>
References: <20210209111438.1.If6218391a7cf47afdeda5e5e6c79937b4e8ab085@changeid>
 <804006bd-a6bc-0352-374d-6d2b33e42db9@denx.de>
Message-ID: <a64dfb56-e43c-5adf-4c07-8935f900a47f@foss.st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


On 2/9/21 11:39 AM, Marek Vasut wrote:
> On 2/9/21 11:14 AM, Patrick Delaunay wrote:
> Hi,
>
> [...]
>
>> diff --git a/drivers/usb/gadget/dwc2_udc_otg.c 
>> b/drivers/usb/gadget/dwc2_udc_otg.c
>> index e3871e381e..ecac80fc11 100644
>> --- a/drivers/usb/gadget/dwc2_udc_otg.c
>> +++ b/drivers/usb/gadget/dwc2_udc_otg.c
>> @@ -1176,7 +1176,7 @@ static int dwc2_udc_otg_remove(struct udevice 
>> *dev)
>> ? static const struct udevice_id dwc2_udc_otg_ids[] = {
>> ????? { .compatible = "snps,dwc2" },
>> ????? { .compatible = "brcm,bcm2835-usb" },
>> -??? { .compatible = "st,stm32mp1-hsotg",
>> +??? { .compatible = "st,stm32mp15-hsotg",
>> ??????? .data = (ulong)dwc2_set_stm32mp1_hsotg_params },
>
> I have to point out the obvious, DT is ABI, this breaks ABI. However, 
> do we care about out-of-tree DTs here ?


I know that the binding backward compatibility and "binary compatible" 
the is a key element of DT

for the Linux kernel (for example the latest kernel image should work 
with a old device tree).


I don't see the same requirement for U-Boot as external DT (with EXT_DTB 
option) is not common .


So today I assume that U-Boot use only in-tree DT for stm32mp15 
platforms until we have a

100% upstream level of the stm32mp1 platform with binding aligned with 
Linux kernel bindings

(for example we have some other pending issue for USBPHYC binding).


But if backward compatibility is really blocking for U-Boot user, I can 
change my mind.


PS: I correct a issue here, because I upstream the stm32mp downstream 
binding for dwc2,

but this compatible had be modified before accepted by Linux kernel DT 
maintaineers

=> today USB in Linux kernel can't work with the DT used by U-Boot


Regards


Patrick