From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Michał Winiarski" <michal.winiarski@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Upgrade printing test/subtest name to pr_info
Date: Tue, 5 Mar 2019 14:50:48 +0000 [thread overview]
Message-ID: <a65012ed-4498-c988-05c6-10817d753421@linux.intel.com> (raw)
In-Reply-To: <20190305144717.10000-1-michal.winiarski@intel.com>
On 05/03/2019 14:47, Michał Winiarski wrote:
> We're using pr_debug for things that we don't really want to see in the
> CI log, but we may find useful during test development.
> Let's upgrade the test name printer - we do want to see those in CI log.
>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/selftests/i915_selftest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
> index 10ef0e636a24..b18eaefef798 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
> @@ -133,7 +133,7 @@ static int __run_selftests(const char *name,
> if (signal_pending(current))
> return -EINTR;
>
> - pr_debug(DRIVER_NAME ": Running %s\n", st->name);
> + pr_info(DRIVER_NAME ": Running %s\n", st->name);
> if (data)
> err = st->live(data);
> else
> @@ -255,7 +255,7 @@ int __i915_subtests(const char *caller,
> if (!apply_subtest_filter(caller, st->name))
> continue;
>
> - pr_debug(DRIVER_NAME ": Running %s/%s\n", caller, st->name);
> + pr_info(DRIVER_NAME ": Running %s/%s\n", caller, st->name);
> GEM_TRACE("Running %s/%s\n", caller, st->name);
>
> err = st->func(data);
>
We are gathering momentum! :)
(20181120172839.25013-1-tvrtko.ursulin@linux.intel.com)
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-05 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 14:47 [PATCH] drm/i915/selftests: Upgrade printing test/subtest name to pr_info Michał Winiarski
2019-03-05 14:50 ` Tvrtko Ursulin [this message]
2019-03-05 15:23 ` Chris Wilson
2019-03-05 15:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-06 11:39 ` Tvrtko Ursulin
2019-03-05 17:37 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a65012ed-4498-c988-05c6-10817d753421@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.