[PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Alexander A Sverdlin]

From: Alexander Sverdlin <alexander.sverdlin@nokia.com>

According to datasheet both Dual and Quad Read is supported. The read test
shows x3.8 speed gain.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
 drivers/mtd/spi-nor/macronix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index d81a4cb..cad9112 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -77,7 +77,7 @@ static const struct flash_info macronix_nor_parts[] = {
 		NO_SFDP_FLAGS(SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
 		.fixups = &mx25l25635_fixups },
 	{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512)
-		NO_SFDP_FLAGS(SECT_4K)
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
 		FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
 	{ "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
-- 
2.10.2

[PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Alexander A Sverdlin]

From: Alexander Sverdlin <alexander.sverdlin@nokia.com>

According to datasheet both Dual and Quad Read is supported. The read test
shows x3.8 speed gain.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
 drivers/mtd/spi-nor/macronix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macronix.c
index d81a4cb..cad9112 100644
--- a/drivers/mtd/spi-nor/macronix.c
+++ b/drivers/mtd/spi-nor/macronix.c
@@ -77,7 +77,7 @@ static const struct flash_info macronix_nor_parts[] = {
 		NO_SFDP_FLAGS(SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
 		.fixups = &mx25l25635_fixups },
 	{ "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512)
-		NO_SFDP_FLAGS(SECT_4K)
+		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
 		FIXUP_FLAGS(SPI_NOR_4B_OPCODES) },
 	{ "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024)
 		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ)
-- 
2.10.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Michael Walle]

Hi,

Am 2022-05-13 11:47, schrieb Alexander A Sverdlin:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 
> According to datasheet both Dual and Quad Read is supported. The read 
> test
> shows x3.8 speed gain.

Does it have SFDP? Try adding PARSE_SFDP instead of the
NO_SFDP_FLAGS.

Please post an SFDP dump of this flash [1].

-michael

[1] 
https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@walle.cc/

Re: [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Michael Walle]

Hi,

Am 2022-05-13 11:47, schrieb Alexander A Sverdlin:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> 
> According to datasheet both Dual and Quad Read is supported. The read 
> test
> shows x3.8 speed gain.

Does it have SFDP? Try adding PARSE_SFDP instead of the
NO_SFDP_FLAGS.

Please post an SFDP dump of this flash [1].

-michael

[1] 
https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@walle.cc/

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Alexander Sverdlin]

Hello Michael,

>> According to datasheet both Dual and Quad Read is supported. The read test
>> shows x3.8 speed gain.
> 
> Does it have SFDP? Try adding PARSE_SFDP instead of the
> NO_SFDP_FLAGS.

Some issues with its SFDP were known:
https://patchwork.ozlabs.org/project/linux-mtd/patch/1492068234-9509-1-git-send-email-dev@kresin.me/
 
> Please post an SFDP dump of this flash [1].

>xxd -p /sys/bus/spi/devices/spi0.0/sfdp
53464450060102ff00060110300000ffc2000104100100ff84000102c000
00ffffffffffffffffffffffffffffffffffe520fbffffffff0f44eb086b
083b04bbfeffffffffff00ffffff44eb0c200f5210d800ff8749b50082d2
04d24403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffff7f8fffff215cdcffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffff002050169df9c06485cbffffffffffff

>md5sum /sys/bus/spi/devices/spi0.0/sfdp
bc360997e729ce1f77f1ff728621d94f /sys/bus/spi/devices/spi0.0/sfdp

>cat /sys/bus/spi/devices/spi0.0/jedec_id
c22539

>cat /sys/bus/spi/devices/spi0.0/partname
mx25u25635f

>cat /sys/bus/spi/devices/spi0.0/manufacturer
macronix

-- 
Best regards,
Alexander Sverdlin.

Re: [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Alexander Sverdlin]

Hello Michael,

>> According to datasheet both Dual and Quad Read is supported. The read test
>> shows x3.8 speed gain.
> 
> Does it have SFDP? Try adding PARSE_SFDP instead of the
> NO_SFDP_FLAGS.

Some issues with its SFDP were known:
https://patchwork.ozlabs.org/project/linux-mtd/patch/1492068234-9509-1-git-send-email-dev@kresin.me/
 
> Please post an SFDP dump of this flash [1].

>xxd -p /sys/bus/spi/devices/spi0.0/sfdp
53464450060102ff00060110300000ffc2000104100100ff84000102c000
00ffffffffffffffffffffffffffffffffffe520fbffffffff0f44eb086b
083b04bbfeffffffffff00ffffff44eb0c200f5210d800ff8749b50082d2
04d24403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffff7f8fffff215cdcffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
ffff002050169df9c06485cbffffffffffff

>md5sum /sys/bus/spi/devices/spi0.0/sfdp
bc360997e729ce1f77f1ff728621d94f /sys/bus/spi/devices/spi0.0/sfdp

>cat /sys/bus/spi/devices/spi0.0/jedec_id
c22539

>cat /sys/bus/spi/devices/spi0.0/partname
mx25u25635f

>cat /sys/bus/spi/devices/spi0.0/manufacturer
macronix

-- 
Best regards,
Alexander Sverdlin.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Michael Walle]

Hi,

Am 2022-05-13 18:09, schrieb Alexander Sverdlin:
>>> According to datasheet both Dual and Quad Read is supported. The read 
>>> test
>>> shows x3.8 speed gain.
>> 
>> Does it have SFDP? Try adding PARSE_SFDP instead of the
>> NO_SFDP_FLAGS.
> 
> Some issues with its SFDP were known:
> https://patchwork.ozlabs.org/project/linux-mtd/patch/1492068234-9509-1-git-send-email-dev@kresin.me/

That doesn't seem to be the case for your flash. The quad and
dual flags you've added, will enable SFDP parsing anyway. So
instead of adding these flags, just adding PARSE_SFDP should
work, too. We still have to keep the SPI_NOR_4B_OPCODES.

>> Please post an SFDP dump of this flash [1].

Thanks.

>> xxd -p /sys/bus/spi/devices/spi0.0/sfdp
> 53464450060102ff00060110300000ffc2000104100100ff84000102c000
> 00ffffffffffffffffffffffffffffffffffe520fbffffffff0f44eb086b
> 083b04bbfeffffffffff00ffffff44eb0c200f5210d800ff8749b50082d2
> 04d24403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffff7f8fffff215cdcffffffffffffffffffffff
                           ^^^^^^^^^^^^^^^^

That's the 4BAIT table.


> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffff002050169df9c06485cbffffffffffff

-michael

Re: [PATCH] mtd: spi-nor: Support Dual and Quad Read on Macronix mx25u25635f

[Michael Walle]

Hi,

Am 2022-05-13 18:09, schrieb Alexander Sverdlin:
>>> According to datasheet both Dual and Quad Read is supported. The read 
>>> test
>>> shows x3.8 speed gain.
>> 
>> Does it have SFDP? Try adding PARSE_SFDP instead of the
>> NO_SFDP_FLAGS.
> 
> Some issues with its SFDP were known:
> https://patchwork.ozlabs.org/project/linux-mtd/patch/1492068234-9509-1-git-send-email-dev@kresin.me/

That doesn't seem to be the case for your flash. The quad and
dual flags you've added, will enable SFDP parsing anyway. So
instead of adding these flags, just adding PARSE_SFDP should
work, too. We still have to keep the SPI_NOR_4B_OPCODES.

>> Please post an SFDP dump of this flash [1].

Thanks.

>> xxd -p /sys/bus/spi/devices/spi0.0/sfdp
> 53464450060102ff00060110300000ffc2000104100100ff84000102c000
> 00ffffffffffffffffffffffffffffffffffe520fbffffffff0f44eb086b
> 083b04bbfeffffffffff00ffffff44eb0c200f5210d800ff8749b50082d2
> 04d24403673830b030b0f7bdd55c4a9e29fff050f985ffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffff7f8fffff215cdcffffffffffffffffffffff
                           ^^^^^^^^^^^^^^^^

That's the 4BAIT table.


> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
> ffff002050169df9c06485cbffffffffffff

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/