From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB4ACC4338F for ; Fri, 30 Jul 2021 04:41:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF76960F9B for ; Fri, 30 Jul 2021 04:41:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF76960F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9336A831A9; Fri, 30 Jul 2021 06:41:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="k7pCxepK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 55635831A9; Fri, 30 Jul 2021 06:41:18 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20602.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::602]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 168EF831BB for ; Fri, 30 Jul 2021 06:41:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fb9LK0gnZ4360kQZhYcn8X024ApttMlN0Cmvagy//OsURj3GI3GsM2FswGf0PE9p5Y6E1bN/CeP/VgKHJEOKuokyDInb8eH0/cHwM82aOj3DqKgViYnqA5c114M061mRPnJzms8CmywgQ/nBxIif6iY5DUdSMsHY+8PUStf+d+NWAsim2p3XLCcCbCqHLDY1wMZzGcnUz4Z2abBrrRQq9x1EE9YYGZnyGlseSQ8udjYZWCflt6RXHuKEwUelBHHHHQUYS0pMnDqkq7SJ7snTiOKiYbfSDqPlD2Ul6fCpPr9LxpB7KiaYVdYb7esNOnrisDbDasUENrp9uiRGRvlfTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d80EKJlwriXFRfjYUj1VHKNfGT2KiENCQqK5vgUduAI=; b=KToSApEEySnMVmrSOTKudkjinoUstmxrDPQCJdi8RmVJEIP/Fx1rMdTAfN9suA0WRfL4XyvXxPtaG/fnwKj4Eg6IQyXqGScxFhmG55l85C7GiNcBg3VpvacUGjfrBOqpKT5otcMHHzgeRtaVpC2ttX2wT8YpX9KMCQi4wQcyqi34QrgM4VKY3zYFSsEzxT2fANX/Bqo+H4dFRepwFXQd1hjRn5sa1eB+GG/8LliMyipQ+ndYhwZcsYusx/yE9enQkB7i0ubC3OwrqodtXVTLpvPiVMhkJZmXHkPsIOdyHofLcumU56EzciQmFudcS9FYu40V4X3p69W+Jprtrnu67w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=arm.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d80EKJlwriXFRfjYUj1VHKNfGT2KiENCQqK5vgUduAI=; b=k7pCxepKBLQdiEyTVU6yJo5WP3DRCYh26ZCBAA2xA6wtSSFmdaEoC+yKeHyDlBb/jPPRYKbzTgerjHME2uH4UrUOTXLdD7019MMD0LDCuCJO0wnBQMGuNW3sxbuVtREjJsrKjijhAREx10FnQ+zBWJcM7+NP2N6mhGr/9iPkAH4= Received: from DM3PR12CA0108.namprd12.prod.outlook.com (2603:10b6:0:55::28) by CH2PR02MB6663.namprd02.prod.outlook.com (2603:10b6:610:7e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Fri, 30 Jul 2021 04:41:11 +0000 Received: from DM3NAM02FT005.eop-nam02.prod.protection.outlook.com (2603:10b6:0:55:cafe::f0) by DM3PR12CA0108.outlook.office365.com (2603:10b6:0:55::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 04:41:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT005.mail.protection.outlook.com (10.13.5.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 04:41:10 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 29 Jul 2021 21:41:04 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 29 Jul 2021 21:41:04 -0700 Envelope-to: Vincent.Stehle@arm.com, sjg@chromium.org, ilias.apalodimas@linaro.org, u-boot@lists.denx.de, sughosh.ganu@linaro.org, xypron.glpk@gmx.de, takahiro.akashi@linaro.org Received: from [172.30.17.109] (port=47032) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1m9KKW-0004Lp-6y; Thu, 29 Jul 2021 21:41:04 -0700 Subject: Re: EFI from usb HDD To: AKASHI Takahiro , Michal Simek , Heinrich Schuchardt , Sughosh Ganu , U-Boot Mailing List , Ilias Apalodimas , Simon Glass , Vincent Stehle References: <9c57a3c7-e609-91e8-cf33-5637ce4f9340@xilinx.com> <20210610125915.GA96492@laputa> <6d4a2a7e-a295-f3e1-1ad8-445f40df334e@xilinx.com> <20210730023507.GA150924@laputa> From: Michal Simek Message-ID: Date: Fri, 30 Jul 2021 06:41:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210730023507.GA150924@laputa> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84cee0ad-9d3b-4f68-8431-08d953144157 X-MS-TrafficTypeDiagnostic: CH2PR02MB6663: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:1775; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y4BNq281ZW/VPUxlw3kJCEO+OI7c7JkdegLfiZReGMNAMXVtFz1dJaDvRE49JyBZsj/jm2E0dJIFogt+wFeC2TBT2/7EeRnfrI8iiz0Nmq6FyV36OG3S72gbpw6lCxD+J4wnYkeLW9n0SYAylC7S4UhJwdDlRD9wsaRShzB9BxK/V8i7brK+Nvcc0/xiW/D++QNTc3CQe52lAujvpxF6BUDPSfpgzZ5d32/5pzZH86TPT/VidlufYmea/TecNnJbulwY7wt0YOfUSmBneyqU9GAyGFe7HvxEGazIhklWSS6ozYeRGWkrtZDxSWQzmyco55sw1o3WVtXE6Z0OyK896slqfOOPWo54G/qU9+YfeXZaqAoJZqZm75fxfA6pD/gMWzhXJFkb0OALukV+HxyBai0sRJnaUHpkBiYhVUDJsyNCeTjHAp77KP5lK2+Gaw/30YTzMW2I5h4kAju1xpzTz7cDt2ZBWuFSCSqIlKppCO0nFwisgP4DHpT7/8fBen/tj+/enf+FHd2uvWHCBDvxb5vh0vgkNUbp+GeZ0dwmSquxN9q01klNTmrBEFmkCPX9D3jbMI0MLY86rwpEN5a5RGUhLCUbOSSWOupf54C9S3x7TlHkmZw4g9HFlg9s/BbuMEQ8LE2H1kfrsu0THaFOnxjI1sx0kWD8gbe2xHe/IAXEk+uaGlHY1PODDjk7Bqb/QRj0LPFZsjbXFLEdAVSEowvfEr9TNvRoFQnJcO4Lmx6D9sE19glDJSFzVJKoT6+RVdJ3NR+tzNZBN6NmV/SokSxABbQEvqFkvRgxA8sSFuYrdktfjFXDdvpw5aJ0o6s9baPhcY/JsUFZ2kEPzybtB+Zk/lbu/6AuSyn0IkUm6y6VE9NdHTXDi2Qcb/oFKD0e X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(36840700001)(46966006)(82740400003)(6666004)(45080400002)(44832011)(36860700001)(3480700007)(2616005)(316002)(478600001)(82310400003)(966005)(36906005)(9786002)(5660300002)(83380400001)(31696002)(8676002)(336012)(8936002)(70586007)(2906002)(26005)(356005)(70206006)(186003)(110136005)(7636003)(53546011)(426003)(31686004)(36756003)(47076005)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2021 04:41:10.9352 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84cee0ad-9d3b-4f68-8431-08d953144157 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT005.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6663 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/30/21 4:35 AM, AKASHI Takahiro wrote: > On Thu, Jul 29, 2021 at 04:09:32PM +0200, Michal Simek wrote: >> Hi, >> >> On 6/10/21 2:59 PM, AKASHI Takahiro wrote: >>> On Thu, Jun 10, 2021 at 02:31:46PM +0200, Michal Simek wrote: >>>> >>>> >>>> On 6/10/21 12:51 PM, Heinrich Schuchardt wrote: >>>>> On 6/10/21 12:04 PM, Michal Simek wrote: >>>>>> Hi, >>>>>> >>>>>> On 6/10/21 11:47 AM, Heinrich Schuchardt wrote: >>>>>>> On 6/10/21 10:44 AM, Michal Simek wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I am playing with booting from USB via EFI. And I see very weird >>>>>>>> behavior. I have burnt image with grub to USB flashdisk and I have >>>>>>>> tested it on 3 zynqmp boards. zcu102, zcu104 and SOM Kria board. >>>>>>>> On zcu102 grub is going to boot menu and everything is working fine as >>>>>>>> expected. >>>>>>>> On zcu104 and SOM Kria I am able to get grub not to menu. When I list >>>>>>>> partitions in grub I see that only SDs are listed: >>>>>>>> grub> ls >>>>>>>> (hd0) (hd0,msdos1) (hd1) (hd1,msdos1) >>>>>>> >>>>>>> Hello Michal, >>>>>>> >>>>>>> thanks for sharing your observations. >>>>>>> >>>>>>> What devices do hd0 and hd1 relate to? >>>>>>> >>>>>>>> >>>>>>>> On zcu102(working board) I also see usb(gpt) partitions and SD. >>>>>>>> grub> ls >>>>>>>> (hd0) (hd0,gpt2) (hd0,gpt1) (hd1) (hd1,msdos1) >>>>>>>> >>>>>>> >>>>>>> GPT and MBR partitioning are independent of the device type. >>>>>>> >>>>>>>> >>>>>>>> On zcu104 I see one more error message >>>>>>>> "PE image measurement failed" >>>>>>> >>>>>>> This is related to CONFIG_EFI_TCG2_PROTOCOL=y. Do you have a TPMv2? This >>>>>>> will not stop disk enumeration. >>>>>>> >>>>>>>> But I can't see it on SOM. >>>>>>>> >>>>>>>> U-Boot image is just the same for all boards. I am using generic >>>>>>>> xilinx_zynqmp_virt_defconfig. >>>>>>>> >>>>>>>> When I compare DT description for USB between zcu102 and zcu104 they >>>>>>>> are >>>>>>>> the same. SOM doesn't have usb enabled by default (but I enabled it) >>>>>>>> but >>>>>>>> grub starts which means that communication with USB is fine. >>>>>>>> >>>>>>>> It is based on my latest patches available here. >>>>>>>> u-boot/custodians/u-boot-microblaze.git (usb-efi-issue branch) >>>>>>>> >>>>>>>> Also when I list usb I see all partitions just fine. >>>>>>>> ZynqMP> part list usb 0 >>>>>>>> >>>>>>>> Partition Map for USB device 0  --   Partition Type: EFI >>>>>>>> >>>>>>>> Part    Start LBA       End LBA         Name >>>>>>>>           Attributes >>>>>>>>           Type GUID >>>>>>>>           Partition GUID >>>>>>>>     1     0x00000800      0x001007fe      "Microsoft basic data" >>>>>>>>           attrs:  0x0000000000000000 >>>>>>>>           type:   ebd0a0a2-b9e5-4433-87c0-68b6b72699c7 >>>>>>>>           type:   data >>>>>>>>           guid:   0e7f8b3d-296b-4720-be9d-c4687d3c4a77 >>>>>>>>     2     0x00100800      0x001197fe      "Microsoft basic data" >>>>>>>>           attrs:  0x0000000000000000 >>>>>>>>           type:   ebd0a0a2-b9e5-4433-87c0-68b6b72699c7 >>>>>>>>           type:   data >>>>>>>>           guid:   8892eddc-231a-4e6e-a5e1-c310f4482fb7 >>>>>>>> >>>>>>>> >>>>>>>> Do you have any idea why on one system is working fine to get to menu >>>>>>>> and on others there is an issue to get all partitions even u-boot is >>>>>>>> able to see them and can work with them. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Michal >>>>>>>> >>>>>>> >>>>>>> Where is the GRUB binary? - If it is in EFI/boot/bootaa64.efi, it could >>>>>>> be that the USB sub-system is simply not initialized yet when the boot >>>>>>> manager is called by distroboot. >>>>>>> >>>>>>> For testing partition detection in the UEFI sub-system it is enough >>>>>>> to run >>>>>>> >>>>>>>      efidebug devices >>>>>>> >>>>>>> Until yesterday we had a problem with partition numbers >= 10, cf. >>>>>>> >>>>>>> efi_loader: partition numbers are hexadecimal >>>>>>> https://source.denx.de/u-boot/u-boot/-/commit/3dca77b1dc1b6dbf9c8b51572fe4b0553cef009f >>>>>>> >>>>>>> >>>>>>> >>>>>>> Block devices are enumerated in efi_disk_register(). Please, try to add >>>>>>> debug output there to elucidate the problem. >>>>>> >>>>>> I found where the problem is. First of all zcu102 didn't use the same >>>>>> image as others (it wasn't updated properly). >>>>>> When you have CONFIG_EFI_CAPSULE_ON_DISK_EARLY that efi_disk_register() >>>>>> is called before usb block devices are detected and registered that's >>>>>> why grub doesn't see them. >>>>> >>>>> The problem is CONFIG_EFI_SETUP_EARLY=y required by >>>>> CONFIG_EFI_CAPSULE_ON_DISK_EARLY. >>>>> >>>>> Why is USB initialized later then MMC? >>>> >>>> It is not just usb. SCSI/sata are behaving in the same way too. >>>> >>>>> >>>>> Overall we have a deficiency in the UEFI implementation in that we >>>>> cannot deal with block devices added or removed after initialization. >>>>> >>>>> Here integration with the driver model is missing. >>>> >>>> Right. And also there are commands which can create MBR partitions and I >>>> expect when you write image to SD and then run rescan or so you could >>>> get other partitions too. >>>> Maybe hook via part_init()? with removing efi_disk_register. >>> >>> For the record, I have proposed my ideas several times[1], [2]. >>> I'm, however, no longer working on this issue as I have shifted >>> my focus to UEFI secure boot and capsule update. >>> >>> -Takahiro Akashi >>> >>> [1] https://lists.denx.de/pipermail/u-boot/2018-November/347491.html >>> [2] https://lists.denx.de/pipermail/u-boot/2019-February/357923.html >> >> I want to continue on this thread. I have disabled >> EFI_CAPSULE_ON_DISK_EARLY some time ago and trying to workaround that >> usb/scsi detection by simply calling usb reset and scsi reset as the >> part of PREBOOT. Then all disks are recorded and visible by grub. >> >> But I found another issue which is kind of weird. We are using >> distroboot with soft of fixed sequence. Important part of sequence is >> sd, usb, scsi. >> >> I have added grub on scsi and when I boot directly via run bootcmd_scsi0 >> everything is working fine. When I let distroboot to do the job it or >> run printenv -e before bootcmd_scsi0 I am getting exception. >> From debug it is visible that it is exception called from >> efi_disk_read_blocks. >> >> 0 0x7ff5d188 hang()+20: include/bootstage.h, line 389 >> 1 0x7ff5f908 __assert_fail(): lib/panic.c, line 25 >> 2 0x7fe976a8 do_irq(): arch/arm/lib/interrupts_64.c, line 123 >> 3 0x7fe96a0c _restore_regs()+124: arch/arm/cpu/armv8/exceptions.S, >> line 141 >> 4 0x7ff43740 efi_disk_read_blocks()+160: lib/efi_loader/efi_disk.c, >> line 102 > > How and when did you get this stack trace? When Abort happened I connected Xilinx debugger via jtag and look at cpu backtrace. Thanks, Michal