From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH v8 3/3] ring: introduce new header file to support C11 memory model Date: Fri, 19 Jan 2018 19:55:41 +0530 Message-ID: References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <1516161831-28719-4-git-send-email-hejianet@gmail.com> <2512442.13rg75T8JE@xps> <23810751-921d-4e3a-bac6-95d251cc122f@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , Jerin Jacob , Jianbo Liu , Jan Viktorin , Olivier Matz , , Jia He To: Jia He , Thomas Monjalon Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0066.outbound.protection.outlook.com [104.47.34.66]) by dpdk.org (Postfix) with ESMTP id E9F121B32C for ; Fri, 19 Jan 2018 16:25:02 +0100 (CET) In-Reply-To: <23810751-921d-4e3a-bac6-95d251cc122f@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" HI Jia, On 1/17/2018 2:17 PM, Jia He wrote: > > Hi Thomas > > On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: >> 17/01/2018 05:03, Jia He: >>> To support C11 memory model barrier, 2 options are suggested by Jerin: >>> 1. use rte_smp_rmb >>> 2. use load_acquire/store_release(refer to [1]). >>> CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" >>> on any architectures so far. >> In previous patches, it was enabled for ARM. >> You decided to not enable it at all? > Sorry, maybe I misunderstand your previous mail. >>This config option should be added in the common file (as disabled). > Do you mean CONFIG_RTE_RING_USE_C11_MEM_MODEL=n in comm_base and > "y" in armv8 config? > > Cheers, > Jia >> >>> config/common_linuxapp | 2 + >> It should be defined in common_base, not common_linuxapp. >> >>> --- /dev/null >>> +++ b/lib/librte_ring/rte_ring_c11_mem.h >>> @@ -0,0 +1,193 @@ >>> +/*- >>> + * Copyright(c) 2017 Intel Corporation. All rights reserved. >>> + * All rights reserved. >>> + * >>> + * SPDX-License-Identifier: BSD-3-Clause >>> + */ >> It is not complying with the template. >> Please check the license/ directory. >> >> Why is it Intel Copyright? >> "All rights reserved" is probably not needed. SPDX shall be first line. Agree, why are you copyrighting it to Intel? >> >>> +/* >>> + * Derived from FreeBSD's bufring.h >>> + * >>> + >>> ************************************************************************** >>> >>> + * >>> + * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org >>> + * All rights reserved. >>> + * >>> + * Redistribution and use in source and binary forms, with or without >>> + * modification, are permitted provided that the following >>> conditions are met: >>> + * >>> + * 1. Redistributions of source code must retain the above copyright >>> notice, >>> + * this list of conditions and the following disclaimer. >>> + * >>> + * 2. The name of Kip Macy nor the names of other >>> + * contributors may be used to endorse or promote products >>> derived from >>> + * this software without specific prior written permission. >>> + * >>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND >>> CONTRIBUTORS "AS IS" >>> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED >>> TO, THE >>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >>> PARTICULAR PURPOSE >>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR >>> CONTRIBUTORS BE >>> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF >>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR >>> BUSINESS >>> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, >>> WHETHER IN >>> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR >>> OTHERWISE) >>> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF >>> ADVISED OF THE >>> + * POSSIBILITY OF SUCH DAMAGE. >>> + * >>> + >>> ***************************************************************************/ >>> >> This double license may be an issue. >> Hemant, comment? >> > Check my response in your other patch. This is not a DPDK acceptable license. It need approval from GB. I could not locate a BSD-3 version of bufring.h What can be accepted in this case, without GB approval: BSD-3 only license + Keep copyright of Kip Macy + Put statement that Kip Macy allowed it for BSD-3 uses. Or, Your company (the copyright owner) is re-licensing the original "BSD-2-freebsd" as "BSD-3". + keep the Derived from statement.