From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-f43.google.com ([209.85.215.43]:34763 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdFBJMG (ORCPT ); Fri, 2 Jun 2017 05:12:06 -0400 Received: by mail-lf0-f43.google.com with SMTP id v20so7731901lfa.1 for ; Fri, 02 Jun 2017 02:12:05 -0700 (PDT) Subject: Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk To: Takashi Iwai , alsa-devel@alsa-project.org References: <20170601205850.24993-1-tiwai@suse.de> <20170601205850.24993-2-tiwai@suse.de> Cc: Takashi Sakamoto , Mark Brown , Hans Verkuil , linux-media@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Fri, 2 Jun 2017 12:12:03 +0300 MIME-Version: 1.0 In-Reply-To: <20170601205850.24993-2-tiwai@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello! On 6/1/2017 11:58 PM, Takashi Iwai wrote: > The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk > for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo"), just like in the Fixes: tag. > quirk for a MSI mobo. But it turned out that this isn't applied > properly due to the MSI-vendor quirk before this entry. I overlooked > such two MSI entries just because they were put in the wrong position, > although we have a list ordered by PCI SSID numbers. > > This patch fixes it by rearranging the unordered entries. > > Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo") > Reported-by: Rudolf Schmidt > Signed-off-by: Takashi Iwai [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk Date: Fri, 2 Jun 2017 12:12:03 +0300 Message-ID: References: <20170601205850.24993-1-tiwai@suse.de> <20170601205850.24993-2-tiwai@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170601205850.24993-2-tiwai-l3A5Bk7waGM@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Takashi Iwai , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org Cc: Takashi Sakamoto , Mark Brown , Hans Verkuil , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: alsa-devel@alsa-project.org Hello! On 6/1/2017 11:58 PM, Takashi Iwai wrote: > The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk > for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo"), just like in the Fixes: tag. > quirk for a MSI mobo. But it turned out that this isn't applied > properly due to the MSI-vendor quirk before this entry. I overlooked > such two MSI entries just because they were put in the wrong position, > although we have a list ordered by PCI SSID numbers. > > This patch fixes it by rearranging the unordered entries. > > Fixes: 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo") > Reported-by: Rudolf Schmidt > Signed-off-by: Takashi Iwai [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html