All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Nelson <snelson@pensando.io>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 2/8] ionic: remove pragma packed
Date: Wed, 4 Mar 2020 16:05:21 -0800	[thread overview]
Message-ID: <a684ff03-9e17-52da-1ff3-aa06b27f4281@pensando.io> (raw)
In-Reply-To: <20200304115420.2824655b@kicinski-fedora-PC1C0HJN>

On 3/4/20 11:54 AM, Jakub Kicinski wrote:
> On Tue,  3 Mar 2020 20:20:07 -0800 Shannon Nelson wrote:
>> Replace the misguided "#pragma packed" with tags on each
>> struct/union definition that actually needs it.  This is safer
>> and more efficient on the various compilers and architectures.
>>
>> Signed-off-by: Shannon Nelson <snelson@pensando.io>
> Ah, I think I missed this pragma in original review :S
>
> nit: I think __packed is preferred

I was hoping to keep with the __attribute__((packed)) format, as I found 
in other kernel headers, as this file is shared in places that don't 
understand the __packed shorthand.  However, with Dave's added urging, 
I'll fix that in v3.

sln


  reply	other threads:[~2020-03-05  0:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  4:20 [PATCH v2 net-next 0/8] ionic updates Shannon Nelson
2020-03-04  4:20 ` [PATCH v2 net-next 1/8] ionic: keep ionic dev on lif init fail Shannon Nelson
2020-03-04  4:20 ` [PATCH v2 net-next 2/8] ionic: remove pragma packed Shannon Nelson
2020-03-04 19:54   ` Jakub Kicinski
2020-03-05  0:05     ` Shannon Nelson [this message]
2020-03-04  4:20 ` [PATCH v2 net-next 3/8] ionic: improve irq numa locality Shannon Nelson
2020-03-04  4:20 ` [PATCH v2 net-next 4/8] ionic: clean up bitflag usage Shannon Nelson
2020-03-04  4:20 ` [PATCH v2 net-next 5/8] ionic: support ethtool rxhash disable Shannon Nelson
2020-03-04 19:59   ` Jakub Kicinski
2020-03-05  0:24     ` Shannon Nelson
2020-03-05  1:32       ` Jakub Kicinski
2020-03-04  4:20 ` [PATCH v2 net-next 6/8] ionic: print pci bus lane info Shannon Nelson
2020-03-04  4:20 ` [PATCH v2 net-next 7/8] ionic: add support for device id 0x1004 Shannon Nelson
2020-03-04  4:20 ` [PATCH v2 net-next 8/8] ionic: drop ethtool driver version Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a684ff03-9e17-52da-1ff3-aa06b27f4281@pensando.io \
    --to=snelson@pensando.io \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.