From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E8D6C433DB for ; Thu, 25 Feb 2021 01:35:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C908C64EC4 for ; Thu, 25 Feb 2021 01:35:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C908C64EC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lF5Yw-0006Ag-Gb for qemu-devel@archiver.kernel.org; Wed, 24 Feb 2021 20:35:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lF5Vp-00050a-9s for qemu-devel@nongnu.org; Wed, 24 Feb 2021 20:32:17 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:35795) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lF5Vm-00032z-Sq for qemu-devel@nongnu.org; Wed, 24 Feb 2021 20:32:16 -0500 Received: by mail-pl1-x62e.google.com with SMTP id g20so2312758plo.2 for ; Wed, 24 Feb 2021 17:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SyOT17jyzgHgW/jX/UwRrk117meKVGY5BOWir/klOg0=; b=Shmfs6Ac8D75HumFCAyGikMcsTAp9jYCpMUH55wiMkFE5AFKJYn1FMYyhWQjy7V8me 1p+dfmLvtLtJ2O+PVCVeQgD6t2SguBw55RADtXj2JqI4XwEdxAOG5OjS2H7lS0chI2UK Zrw0c305iv5HN0tCImjvCRmaiyoyhEoFO8KdjruWgVCC00CUvmGM4MtrYfVx1hvB3hlg gq7uXXYk7/8OTbtIfraurDOeBgysSSVeMnzbEf3IdUWwMfVzhQ1Ag6sHLOKisv6e2LzX 08qVaLF6ERa2e30gvQujqvdTYE3yVpUhN8E8YIu3hnXmGLDWAEZ/Fgiq1LildUkrIfO9 s0hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SyOT17jyzgHgW/jX/UwRrk117meKVGY5BOWir/klOg0=; b=SlAmrPv+GhgQaSMIreOmZ/Hy/PHzw4KPoBhUVrvjW0JF07hC/Y/KVXap1i0aJZOPRU urWPZdF6VANM/VH8Q+dNw/t5ci1PGQMXafAtwJaWvS7bHa64J4XRpj6F28QI6y1RyzLU 0/a/qWMAfIeUrj7KzMuYuCyYs5HuXBGgFPOAnrk0p5MVK5xnKdHwx8h92tDFr7WqPEi4 vYkG4fLYHOseBRfevKEc6edPn+PFj+m9UctUo+9rlxmrW87dGkdCAfuROaiKbGt+QjqC B9/igxm2cTpV+ahxJTEdXQDHBDFs31prqfyhHTy8TGCOh4Huv73Pjtjtg16Z1asWzSqi 6+PQ== X-Gm-Message-State: AOAM533o2L4NNJAvHTZzXZ73kd7d69ptaMoXHqEByYMFrVLLVzEwDkaa yCt1rhElVlI3F923NqCdYyhWF99Yhq2N/w== X-Google-Smtp-Source: ABdhPJyrOH6G94ed/725OEhnqEGfSgdOOBnMCfw8Avcz88MX3cHdnHUZM5Ql/58Re5OJQp5qo/Yd6w== X-Received: by 2002:a17:902:ab93:b029:df:f681:cdf3 with SMTP id f19-20020a170902ab93b02900dff681cdf3mr621025plr.28.1614216733055; Wed, 24 Feb 2021 17:32:13 -0800 (PST) Received: from [192.168.1.11] (174-21-84-25.tukw.qwest.net. [174.21.84.25]) by smtp.gmail.com with ESMTPSA id j3sm3624462pgk.24.2021.02.24.17.32.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Feb 2021 17:32:12 -0800 (PST) Subject: Re: [PATCH v22 08/17] i386: split smm helper (sysemu) To: Claudio Fontana , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210224133428.14071-1-cfontana@suse.de> <20210224133428.14071-9-cfontana@suse.de> From: Richard Henderson Message-ID: Date: Wed, 24 Feb 2021 17:32:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210224133428.14071-9-cfontana@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/24/21 5:34 AM, Claudio Fontana wrote: > smm is only really useful for sysemu, split in two modules > around the CONFIG_USER_ONLY, in order to remove the ifdef > and use the build system instead. > > add cpu_abort() when detecting attempts to enter SMM mode via > SMI interrupt in user-mode, and assert that the cpu is not > in SMM mode while translating RSM instructions. > > Signed-off-by: Claudio Fontana > Cc: Paolo Bonzini > --- > target/i386/helper.h | 4 ++++ > target/i386/tcg/seg_helper.c | 4 ++++ > target/i386/tcg/{ => sysemu}/smm_helper.c | 19 ++----------------- > target/i386/tcg/translate.c | 5 +++++ > target/i386/tcg/meson.build | 1 - > target/i386/tcg/sysemu/meson.build | 1 + > 6 files changed, 16 insertions(+), 18 deletions(-) > rename target/i386/tcg/{ => sysemu}/smm_helper.c (98%) Reviewed-by: Richard Henderson r~