From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A061C4332F for ; Wed, 23 Nov 2022 19:51:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 81EFC10E1F6; Wed, 23 Nov 2022 19:51:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10A9110E1F6 for ; Wed, 23 Nov 2022 19:51:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=gWgahCN0LwC89E2KB43w5T+Gp5ZpXQ1ebFse858HZYA=; b=aC79aj24enbYgV2hpmBvp9wsnL qwbwTJ6xtdijYnoXSkhsfv5lPt0Ow5+QQoWPLd9bYd9HdqLiaI1/VyZV31f8oqiYtE+/UrcKue6go eOzLw3/yB/1AGr62slNCOGam+g2JI59kRBPKOd9MVz+NJx3OJu/KHubE0N9HZPmsCVULPxCPaRkpn OV8K2fw8im0qOJq5OiTixKz2y7LQarby7iXHQHNRmNKnNAYJSSptVXuZKbu7SDZov2WQ3DhQN+1+s /r2rfAx6v2sN7ePVFd4iSYNZ5CqT7xD8Uo0LEa9DT0dMEqgpuH88VdZR4XgVi6MPQ+gctuUGhkcdB /b/chChQ==; Received: from [2601:1c2:d80:3110::a2e7] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxvm0-0023uQ-QK; Wed, 23 Nov 2022 19:51:08 +0000 Message-ID: Date: Wed, 23 Nov 2022 11:51:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] dma-buf: A collection of typo and documentation fixes Content-Language: en-US To: "T.J. Mercier" , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= References: <20221123193519.3948105-1-tjmercier@google.com> From: Randy Dunlap In-Reply-To: <20221123193519.3948105-1-tjmercier@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 11/23/22 11:35, T.J. Mercier wrote: > I've been collecting these typo fixes for a while and it feels like > time to send them in. > > Signed-off-by: T.J. Mercier Reviewed-by: Randy Dunlap Thanks. (although I would prefer to see CPU instead of cpu, but that's no reason to hold up this patch) > --- > drivers/dma-buf/dma-buf.c | 14 +++++++------- > include/linux/dma-buf.h | 6 +++--- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index dd0f83ee505b..614ccd208af4 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -1141,7 +1141,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_unmap_attachment, DMA_BUF); > * > * @dmabuf: [in] buffer which is moving > * > - * Informs all attachmenst that they need to destroy and recreated all their > + * Informs all attachments that they need to destroy and recreate all their > * mappings. > */ > void dma_buf_move_notify(struct dma_buf *dmabuf) > @@ -1159,11 +1159,11 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); > /** > * DOC: cpu access > * > - * There are mutliple reasons for supporting CPU access to a dma buffer object: > + * There are multiple reasons for supporting CPU access to a dma buffer object: > * > * - Fallback operations in the kernel, for example when a device is connected > * over USB and the kernel needs to shuffle the data around first before > - * sending it away. Cache coherency is handled by braketing any transactions > + * sending it away. Cache coherency is handled by bracketing any transactions > * with calls to dma_buf_begin_cpu_access() and dma_buf_end_cpu_access() > * access. > * > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); > * replace ION buffers mmap support was needed. > * > * There is no special interfaces, userspace simply calls mmap on the dma-buf > - * fd. But like for CPU access there's a need to braket the actual access, > + * fd. But like for CPU access there's a need to bracket the actual access, > * which is handled by the ioctl (DMA_BUF_IOCTL_SYNC). Note that > * DMA_BUF_IOCTL_SYNC can fail with -EAGAIN or -EINTR, in which case it must > * be restarted. > @@ -1264,10 +1264,10 @@ static int __dma_buf_begin_cpu_access(struct dma_buf *dmabuf, > * preparations. Coherency is only guaranteed in the specified range for the > * specified access direction. > * @dmabuf: [in] buffer to prepare cpu access for. > - * @direction: [in] length of range for cpu access. > + * @direction: [in] direction of access. > * > * After the cpu access is complete the caller should call > - * dma_buf_end_cpu_access(). Only when cpu access is braketed by both calls is > + * dma_buf_end_cpu_access(). Only when cpu access is bracketed by both calls is > * it guaranteed to be coherent with other DMA access. > * > * This function will also wait for any DMA transactions tracked through > @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_begin_cpu_access, DMA_BUF); > * actions. Coherency is only guaranteed in the specified range for the > * specified access direction. > * @dmabuf: [in] buffer to complete cpu access for. > - * @direction: [in] length of range for cpu access. > + * @direction: [in] direction of access. > * > * This terminates CPU access started with dma_buf_begin_cpu_access(). > * > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index 71731796c8c3..1d61a4f6db35 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -330,7 +330,7 @@ struct dma_buf { > * @lock: > * > * Used internally to serialize list manipulation, attach/detach and > - * vmap/unmap. Note that in many cases this is superseeded by > + * vmap/unmap. Note that in many cases this is superseded by > * dma_resv_lock() on @resv. > */ > struct mutex lock; > @@ -365,7 +365,7 @@ struct dma_buf { > */ > const char *name; > > - /** @name_lock: Spinlock to protect name acces for read access. */ > + /** @name_lock: Spinlock to protect name access for read access. */ > spinlock_t name_lock; > > /** > @@ -402,7 +402,7 @@ struct dma_buf { > * anything the userspace API considers write access. > * > * - Drivers may just always add a write fence, since that only > - * causes unecessarily synchronization, but no correctness issues. > + * causes unnecessary synchronization, but no correctness issues. > * > * - Some drivers only expose a synchronous userspace API with no > * pipelining across drivers. These do not set any fences for their -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236BDC4332F for ; Wed, 23 Nov 2022 19:52:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239525AbiKWTwx (ORCPT ); Wed, 23 Nov 2022 14:52:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239447AbiKWTwX (ORCPT ); Wed, 23 Nov 2022 14:52:23 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BC3FCC168; Wed, 23 Nov 2022 11:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=gWgahCN0LwC89E2KB43w5T+Gp5ZpXQ1ebFse858HZYA=; b=aC79aj24enbYgV2hpmBvp9wsnL qwbwTJ6xtdijYnoXSkhsfv5lPt0Ow5+QQoWPLd9bYd9HdqLiaI1/VyZV31f8oqiYtE+/UrcKue6go eOzLw3/yB/1AGr62slNCOGam+g2JI59kRBPKOd9MVz+NJx3OJu/KHubE0N9HZPmsCVULPxCPaRkpn OV8K2fw8im0qOJq5OiTixKz2y7LQarby7iXHQHNRmNKnNAYJSSptVXuZKbu7SDZov2WQ3DhQN+1+s /r2rfAx6v2sN7ePVFd4iSYNZ5CqT7xD8Uo0LEa9DT0dMEqgpuH88VdZR4XgVi6MPQ+gctuUGhkcdB /b/chChQ==; Received: from [2601:1c2:d80:3110::a2e7] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxvm0-0023uQ-QK; Wed, 23 Nov 2022 19:51:08 +0000 Message-ID: Date: Wed, 23 Nov 2022 11:51:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] dma-buf: A collection of typo and documentation fixes Content-Language: en-US To: "T.J. Mercier" , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org References: <20221123193519.3948105-1-tjmercier@google.com> From: Randy Dunlap In-Reply-To: <20221123193519.3948105-1-tjmercier@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/22 11:35, T.J. Mercier wrote: > I've been collecting these typo fixes for a while and it feels like > time to send them in. > > Signed-off-by: T.J. Mercier Reviewed-by: Randy Dunlap Thanks. (although I would prefer to see CPU instead of cpu, but that's no reason to hold up this patch) > --- > drivers/dma-buf/dma-buf.c | 14 +++++++------- > include/linux/dma-buf.h | 6 +++--- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index dd0f83ee505b..614ccd208af4 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -1141,7 +1141,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_unmap_attachment, DMA_BUF); > * > * @dmabuf: [in] buffer which is moving > * > - * Informs all attachmenst that they need to destroy and recreated all their > + * Informs all attachments that they need to destroy and recreate all their > * mappings. > */ > void dma_buf_move_notify(struct dma_buf *dmabuf) > @@ -1159,11 +1159,11 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); > /** > * DOC: cpu access > * > - * There are mutliple reasons for supporting CPU access to a dma buffer object: > + * There are multiple reasons for supporting CPU access to a dma buffer object: > * > * - Fallback operations in the kernel, for example when a device is connected > * over USB and the kernel needs to shuffle the data around first before > - * sending it away. Cache coherency is handled by braketing any transactions > + * sending it away. Cache coherency is handled by bracketing any transactions > * with calls to dma_buf_begin_cpu_access() and dma_buf_end_cpu_access() > * access. > * > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); > * replace ION buffers mmap support was needed. > * > * There is no special interfaces, userspace simply calls mmap on the dma-buf > - * fd. But like for CPU access there's a need to braket the actual access, > + * fd. But like for CPU access there's a need to bracket the actual access, > * which is handled by the ioctl (DMA_BUF_IOCTL_SYNC). Note that > * DMA_BUF_IOCTL_SYNC can fail with -EAGAIN or -EINTR, in which case it must > * be restarted. > @@ -1264,10 +1264,10 @@ static int __dma_buf_begin_cpu_access(struct dma_buf *dmabuf, > * preparations. Coherency is only guaranteed in the specified range for the > * specified access direction. > * @dmabuf: [in] buffer to prepare cpu access for. > - * @direction: [in] length of range for cpu access. > + * @direction: [in] direction of access. > * > * After the cpu access is complete the caller should call > - * dma_buf_end_cpu_access(). Only when cpu access is braketed by both calls is > + * dma_buf_end_cpu_access(). Only when cpu access is bracketed by both calls is > * it guaranteed to be coherent with other DMA access. > * > * This function will also wait for any DMA transactions tracked through > @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_begin_cpu_access, DMA_BUF); > * actions. Coherency is only guaranteed in the specified range for the > * specified access direction. > * @dmabuf: [in] buffer to complete cpu access for. > - * @direction: [in] length of range for cpu access. > + * @direction: [in] direction of access. > * > * This terminates CPU access started with dma_buf_begin_cpu_access(). > * > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index 71731796c8c3..1d61a4f6db35 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -330,7 +330,7 @@ struct dma_buf { > * @lock: > * > * Used internally to serialize list manipulation, attach/detach and > - * vmap/unmap. Note that in many cases this is superseeded by > + * vmap/unmap. Note that in many cases this is superseded by > * dma_resv_lock() on @resv. > */ > struct mutex lock; > @@ -365,7 +365,7 @@ struct dma_buf { > */ > const char *name; > > - /** @name_lock: Spinlock to protect name acces for read access. */ > + /** @name_lock: Spinlock to protect name access for read access. */ > spinlock_t name_lock; > > /** > @@ -402,7 +402,7 @@ struct dma_buf { > * anything the userspace API considers write access. > * > * - Drivers may just always add a write fence, since that only > - * causes unecessarily synchronization, but no correctness issues. > + * causes unnecessary synchronization, but no correctness issues. > * > * - Some drivers only expose a synchronous userspace API with no > * pipelining across drivers. These do not set any fences for their -- ~Randy