From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv4FQ-0001HY-Dm for qemu-devel@nongnu.org; Mon, 03 Apr 2017 11:50:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv4FM-00073M-El for qemu-devel@nongnu.org; Mon, 03 Apr 2017 11:50:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44088) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cv4FM-00073C-8P for qemu-devel@nongnu.org; Mon, 03 Apr 2017 11:50:24 -0400 References: <20170401004624.30886-1-ehabkost@redhat.com> <20170401004624.30886-20-ehabkost@redhat.com> From: Laszlo Ersek Message-ID: Date: Mon, 3 Apr 2017 17:50:13 +0200 MIME-Version: 1.0 In-Reply-To: <20170401004624.30886-20-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 19/19] virtio-mmio: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Alexander Graf , Marcel Apfelbaum , Thomas Huth , Peter Maydell , Markus Armbruster , Shannon Zhao , "Michael S. Tsirkin" On 04/01/17 02:46, Eduardo Habkost wrote: > virtio-mmio needs to be wired and mapped by other device or board > code, and won't work with -device. Remove the user_creatable flag > from the device class. > > Cc: Peter Maydell > Cc: Shannon Zhao > Cc: "Michael S. Tsirkin" > Signed-off-by: Eduardo Habkost > --- > hw/virtio/virtio-mmio.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > index b595512a3d..5807aa87fe 100644 > --- a/hw/virtio/virtio-mmio.c > +++ b/hw/virtio/virtio-mmio.c > @@ -450,11 +450,6 @@ static void virtio_mmio_class_init(ObjectClass *klass, void *data) > dc->reset = virtio_mmio_reset; > set_bit(DEVICE_CATEGORY_MISC, dc->categories); > dc->props = virtio_mmio_properties; > - /* > - * FIXME: Set only for compatibility on q35 machine-type. > - * Probably never meant to be user-creatable > - */ > - dc->user_creatable = true; > } > > static const TypeInfo virtio_mmio_info = { > Possible addition to the commit message: a reference to commit 587078f0ed63 ("hw/arm/virt: explain device-to-transport mapping in create_virtio_devices()", 2015-02-05). That's another example showing that board code has to participate in virtio-mmio transport placement. Reviewed-by: Laszlo Ersek