All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vishal Verma <vishal@kernel.org>
To: tools@linux.kernel.org
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: b4 prep + prefix handling
Date: Tue, 06 Dec 2022 15:44:59 -0700	[thread overview]
Message-ID: <a68d5dc1c7919b16062fa1c477cf12b5c924caa7.camel@kernel.org> (raw)

Hi Konstantin,

I found a possible issue with prefixes - and also a suggestion below:

- When a 'git config format.subjectprefix' exists, b4 send does
something unexpected:
(the .git/config subjectprefix here was "ndctl PATCH")

  | Subject: [PATCH 2/2] [ndctl PATCH] meson.build: add a check argument to run_command

- It might be helpful to configure whether the final form is "PATCH
prefix" vs "prefix PATCH". I'm used to the latter, but I don't know if
the former is considered conventional.

- It might be nice if prefixes from git-config could be added
automagically (perhaps b4 prep pulls these in when starting a new
set?). I have prefixes based on repos sometimes, like the above
example, and it would be nice to get consistent behavior regardless of
whether 'b4 prep/send' is used or 'git format-patch/send-email'

Thanks!
Vishal

             reply	other threads:[~2022-12-06 22:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 22:44 Vishal Verma [this message]
2022-12-09 21:11 ` b4 prep + prefix handling Konstantin Ryabitsev
2022-12-09 21:18   ` Vishal Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a68d5dc1c7919b16062fa1c477cf12b5c924caa7.camel@kernel.org \
    --to=vishal@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.