[PATCH 0/2] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

[PATCH 0/2] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

[Geert Uytterhoeven]

	Hi all,

The Renesas R-Car CAN FD Controller always uses two or more interrupts.
Hence it makes sense to make the interrupt-names property a required
property, to make it easier to identify the individual interrupts, and
validate the mapping.

  - The first patch updates the various R-Car Gen3 and RZ/G2 DTS files
    to add interrupt-names properties, and is intended for the
    renesas-devel tree,
  - The second patch updates the CAN-FD DT bindings to mark the
    interrupt-names property required, and is intended for the DT or net
    tree.

Thanks!

Geert Uytterhoeven (2):
  arm64: dts: renesas: Add interrupt-names to CANFD nodes
  dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

 .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml        | 3 ++-
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a774b1.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a774e1.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77951.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77960.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77961.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77970.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77980.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77990.dtsi                      | 1 +
 arch/arm64/boot/dts/renesas/r8a77995.dtsi                      | 1 +
 13 files changed, 14 insertions(+), 1 deletion(-)

-- 
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] arm64: dts: renesas: Add interrupt-names to CANFD nodes

[Geert Uytterhoeven]

The Renesas R-Car CAN FD Controller on R-Car Gen3 and RZ/G2 SoCs has two
interrupts.  Add interrupt-names properties to all CAN-FD device nodes
to identify the individual interrupts, so we can make this property a
required property in the DT bindings.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77951.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77960.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77961.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77990.dtsi | 1 +
 arch/arm64/boot/dts/renesas/r8a77995.dtsi | 1 +
 12 files changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index faf5bbbb3710ebe8..a31ded74b02e8e95 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -1179,6 +1179,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 				 <&cpg CPG_CORE R8A774A1_CLK_CANFD>,
 				 <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
index be998bc4041283ec..7ecb7e553e3c9d95 100644
--- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
@@ -1052,6 +1052,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				   <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 				 <&cpg CPG_CORE R8A774B1_CLK_CANFD>,
 				 <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 4f69f90d88cbbc1e..459da7091723710c 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -1009,6 +1009,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 				 <&cpg CPG_CORE R8A774C0_CLK_CANFD>,
 				 <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
index 989c1c00dcdcb393..34530881f9e3f782 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
@@ -1280,6 +1280,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 				 <&cpg CPG_CORE R8A774E1_CLK_CANFD>,
 				 <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
index 884210544ba01a4c..5eed142147d14fe7 100644
--- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
@@ -1368,6 +1368,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				   <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 			       <&cpg CPG_CORE R8A7795_CLK_CANFD>,
 			       <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
index 0d96b5bb958489ff..57d990e1c132d0c7 100644
--- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
@@ -1240,6 +1240,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				   <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 			       <&cpg CPG_CORE R8A7796_CLK_CANFD>,
 			       <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
index 58e161e5dae0e4cd..9f5cd45664083b12 100644
--- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
@@ -1229,6 +1229,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				   <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 			       <&cpg CPG_CORE R8A77961_CLK_CANFD>,
 			       <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index ecca9582edf6a739..951bbcef6ff845e9 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1103,6 +1103,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				   <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 			       <&cpg CPG_CORE R8A77965_CLK_CANFD>,
 			       <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 79718234d85fe50d..ac78c41c66f80874 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -557,6 +557,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 				 <&cpg CPG_CORE R8A77970_CLK_CANFD>,
 				 <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 148983130adf3113..e4163bde7c436fb9 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -609,6 +609,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 				 <&cpg CPG_CORE R8A77980_CLK_CANFD>,
 				 <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 5d41e46d06f566e2..5d877d7bb2edf8b9 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -1052,6 +1052,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				   <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 			       <&cpg CPG_CORE R8A77990_CLK_CANFD>,
 			       <&can_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 0eccf81db3747eae..55b3d1b2adf5a8a4 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -557,6 +557,7 @@ canfd: can@e66c0000 {
 			reg = <0 0xe66c0000 0 0x8000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
 				   <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "ch_int", "g_int";
 			clocks = <&cpg CPG_MOD 914>,
 			       <&cpg CPG_CORE R8A77995_CLK_CANFD>,
 			       <&can_clk>;
-- 
2.25.1

[PATCH 2/2] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

[Geert Uytterhoeven]

The Renesas R-Car CAN FD Controller always uses two or more interrupts.
Make the interrupt-names properties a required property, to make it
easier to identify the individual interrupts.

Update the example accordingly.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../devicetree/bindings/net/can/renesas,rcar-canfd.yaml        | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
index 9fc137fafed98b8f..6f71fc96bc4e3156 100644
--- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
+++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
@@ -88,6 +88,7 @@ required:
   - compatible
   - reg
   - interrupts
+  - interrupt-names
   - clocks
   - clock-names
   - power-domains
@@ -136,7 +137,6 @@ then:
         - const: rstc_n
 
   required:
-    - interrupt-names
     - reset-names
 else:
   properties:
@@ -167,6 +167,7 @@ examples:
             reg = <0xe66c0000 0x8000>;
             interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+            interrupt-names = "ch_int", "g_int";
             clocks = <&cpg CPG_MOD 914>,
                      <&cpg CPG_CORE R8A7795_CLK_CANFD>,
                      <&can_clk>;
-- 
2.25.1

Re: [PATCH 0/2] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

On 02.05.2022 19:33:51, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> The Renesas R-Car CAN FD Controller always uses two or more interrupts.
> Hence it makes sense to make the interrupt-names property a required
> property, to make it easier to identify the individual interrupts, and
> validate the mapping.
> 
>   - The first patch updates the various R-Car Gen3 and RZ/G2 DTS files
>     to add interrupt-names properties, and is intended for the
>     renesas-devel tree,
>   - The second patch updates the CAN-FD DT bindings to mark the
>     interrupt-names property required, and is intended for the DT or net
>     tree.
> 
> Thanks!

LGTM. Who takes this series?

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

[Geert Uytterhoeven]

Hi Marc,

On Mon, May 2, 2022 at 8:27 PM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 02.05.2022 19:33:51, Geert Uytterhoeven wrote:
> > The Renesas R-Car CAN FD Controller always uses two or more interrupts.
> > Hence it makes sense to make the interrupt-names property a required
> > property, to make it easier to identify the individual interrupts, and
> > validate the mapping.
> >
> >   - The first patch updates the various R-Car Gen3 and RZ/G2 DTS files
> >     to add interrupt-names properties, and is intended for the
> >     renesas-devel tree,
> >   - The second patch updates the CAN-FD DT bindings to mark the
> >     interrupt-names property required, and is intended for the DT or net
> >     tree.
> >
> > Thanks!
>
> LGTM. Who takes this series?

I'll take the first patch.

The second patch is up to you and the DT maintainers.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 0/2] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

On 03.05.2022 09:25:45, Geert Uytterhoeven wrote:
> Hi Marc,
> 
> On Mon, May 2, 2022 at 8:27 PM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > On 02.05.2022 19:33:51, Geert Uytterhoeven wrote:
> > > The Renesas R-Car CAN FD Controller always uses two or more interrupts.
> > > Hence it makes sense to make the interrupt-names property a required
> > > property, to make it easier to identify the individual interrupts, and
> > > validate the mapping.
> > >
> > >   - The first patch updates the various R-Car Gen3 and RZ/G2 DTS files
> > >     to add interrupt-names properties, and is intended for the
> > >     renesas-devel tree,
> > >   - The second patch updates the CAN-FD DT bindings to mark the
> > >     interrupt-names property required, and is intended for the DT or net
> > >     tree.
> > >
> > > Thanks!
> >
> > LGTM. Who takes this series?
> 
> I'll take the first patch.
> 
> The second patch is up to you and the DT maintainers.

Sounds good.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 2/2] dt-bindings: can: renesas,rcar-canfd: Make interrupt-names required

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

On 02.05.2022 19:33:53, Geert Uytterhoeven wrote:
> The Renesas R-Car CAN FD Controller always uses two or more interrupts.
> Make the interrupt-names properties a required property, to make it
> easier to identify the individual interrupts.
> 
> Update the example accordingly.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied to linux-can-next/testing.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]