From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F041C77B7F for ; Fri, 5 May 2023 17:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231669AbjEERRh (ORCPT ); Fri, 5 May 2023 13:17:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230297AbjEERRg (ORCPT ); Fri, 5 May 2023 13:17:36 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72E5BAD02 for ; Fri, 5 May 2023 10:17:35 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 345DK3BL022900; Fri, 5 May 2023 17:17:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=zdWcUQ72agBotpTCx3OSjXdkQZqkt9Cab2ssiVOcbNc=; b=Q6RqfDYL4c9mdd/gSKYGwIB4LLXoT5G4rWQoIxh6r2hgoNIMgT4OT61gW96x3vcVY+8y qhuQ0sz6puuS/+ZeK9U/47MRGFkfF9pblRZW7qTsJ2mzaIpXMOcomKVuOqPUVUh4N7XK Vq09Zt9zr6MGRXXxprytQxJmZR7bVziEa7Ape0q2fDoLeq01wo5FNFj5QXmopgnFD3V5 fd4+nfVtpFxd3QAB2XWCyi6s0P+vLjzx5wgD81Uh+aaOZAVtA35Fh+8dcDNjuGAJRzoh CNKBvXXmzFAqrAO0WV57vGmZIXah+UFf62o9XGWdiB+4cYEit2TdTPqGQ+NmgSaYEtfv Xg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qd28qgn5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 May 2023 17:17:27 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 345HHQ1o020117 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 5 May 2023 17:17:26 GMT Received: from [10.110.37.209] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 5 May 2023 10:17:26 -0700 Message-ID: Date: Fri, 5 May 2023 10:17:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [Freedreno] [PATCH v2 3/9] drm/msm/dpu: fix the condition for (not) applying QoS to CURSOR SSPP Content-Language: en-US To: Dmitry Baryshkov , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten CC: , , "Bjorn Andersson" , , "Stephen Boyd" , Daniel Vetter , David Airlie References: <20230502150533.3672840-1-dmitry.baryshkov@linaro.org> <20230502150533.3672840-4-dmitry.baryshkov@linaro.org> From: Jeykumar Sankaran In-Reply-To: <20230502150533.3672840-4-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Q6an5rlAw1UmQLbzvOEUVmfapl5dZ5wt X-Proofpoint-ORIG-GUID: Q6an5rlAw1UmQLbzvOEUVmfapl5dZ5wt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-05_23,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305050142 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: > The function dpu_plane_sspp_update_pipe() contains code to skip enabling > the QoS and OT limitis for CURSOR pipes. However all DPU since sdm845 > repurpose DMA SSPP for the cursor planes because they lack the real > CURSOR SSPP. Fix the condition to actually check that the plane is > CURSOR or not. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > index 3b210320ea62..b8ed7247a6af 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > @@ -1126,7 +1126,8 @@ static void dpu_plane_sspp_update_pipe(struct drm_plane *plane, > _dpu_plane_set_qos_lut(plane, pipe, fmt, pipe_cfg); > _dpu_plane_set_danger_lut(plane, pipe, fmt); > > - if (plane->type != DRM_PLANE_TYPE_CURSOR) { > + if (pipe->sspp->idx != SSPP_CURSOR0 && > + pipe->sspp->idx != SSPP_CURSOR1) { > _dpu_plane_set_qos_ctrl(plane, pipe, true, DPU_PLANE_QOS_PANIC_CTRL); > _dpu_plane_set_ot_limit(plane, pipe, pipe_cfg, frame_rate); > } Reviewed-by: Jeykumar Sankaran From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 099A3C77B7F for ; Sat, 6 May 2023 10:34:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 587B610E26A; Sat, 6 May 2023 10:33:55 +0000 (UTC) Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EDC410E642; Fri, 5 May 2023 17:17:32 +0000 (UTC) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 345DK3BL022900; Fri, 5 May 2023 17:17:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=zdWcUQ72agBotpTCx3OSjXdkQZqkt9Cab2ssiVOcbNc=; b=Q6RqfDYL4c9mdd/gSKYGwIB4LLXoT5G4rWQoIxh6r2hgoNIMgT4OT61gW96x3vcVY+8y qhuQ0sz6puuS/+ZeK9U/47MRGFkfF9pblRZW7qTsJ2mzaIpXMOcomKVuOqPUVUh4N7XK Vq09Zt9zr6MGRXXxprytQxJmZR7bVziEa7Ape0q2fDoLeq01wo5FNFj5QXmopgnFD3V5 fd4+nfVtpFxd3QAB2XWCyi6s0P+vLjzx5wgD81Uh+aaOZAVtA35Fh+8dcDNjuGAJRzoh CNKBvXXmzFAqrAO0WV57vGmZIXah+UFf62o9XGWdiB+4cYEit2TdTPqGQ+NmgSaYEtfv Xg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qd28qgn5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 May 2023 17:17:27 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 345HHQ1o020117 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 5 May 2023 17:17:26 GMT Received: from [10.110.37.209] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 5 May 2023 10:17:26 -0700 Message-ID: Date: Fri, 5 May 2023 10:17:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [Freedreno] [PATCH v2 3/9] drm/msm/dpu: fix the condition for (not) applying QoS to CURSOR SSPP Content-Language: en-US To: Dmitry Baryshkov , Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten References: <20230502150533.3672840-1-dmitry.baryshkov@linaro.org> <20230502150533.3672840-4-dmitry.baryshkov@linaro.org> From: Jeykumar Sankaran In-Reply-To: <20230502150533.3672840-4-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Q6an5rlAw1UmQLbzvOEUVmfapl5dZ5wt X-Proofpoint-ORIG-GUID: Q6an5rlAw1UmQLbzvOEUVmfapl5dZ5wt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-05_23,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2305050142 X-Mailman-Approved-At: Sat, 06 May 2023 10:33:25 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: > The function dpu_plane_sspp_update_pipe() contains code to skip enabling > the QoS and OT limitis for CURSOR pipes. However all DPU since sdm845 > repurpose DMA SSPP for the cursor planes because they lack the real > CURSOR SSPP. Fix the condition to actually check that the plane is > CURSOR or not. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > index 3b210320ea62..b8ed7247a6af 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > @@ -1126,7 +1126,8 @@ static void dpu_plane_sspp_update_pipe(struct drm_plane *plane, > _dpu_plane_set_qos_lut(plane, pipe, fmt, pipe_cfg); > _dpu_plane_set_danger_lut(plane, pipe, fmt); > > - if (plane->type != DRM_PLANE_TYPE_CURSOR) { > + if (pipe->sspp->idx != SSPP_CURSOR0 && > + pipe->sspp->idx != SSPP_CURSOR1) { > _dpu_plane_set_qos_ctrl(plane, pipe, true, DPU_PLANE_QOS_PANIC_CTRL); > _dpu_plane_set_ot_limit(plane, pipe, pipe_cfg, frame_rate); > } Reviewed-by: Jeykumar Sankaran