From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C87C9C4363D for ; Fri, 2 Oct 2020 15:04:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5039B206CA for ; Fri, 2 Oct 2020 15:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388267AbgJBPEQ (ORCPT ); Fri, 2 Oct 2020 11:04:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgJBPEP (ORCPT ); Fri, 2 Oct 2020 11:04:15 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D03AC0613D0 for ; Fri, 2 Oct 2020 08:04:15 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kOMbV-00FIfO-C3; Fri, 02 Oct 2020 17:04:13 +0200 Message-ID: Subject: Re: [PATCH net-next v2 00/10] genetlink: support per-command policy dump From: Johannes Berg To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, andrew@lunn.ch, jiri@resnulli.us, mkubecek@suse.cz, dsahern@kernel.org, pablo@netfilter.org Date: Fri, 02 Oct 2020 17:04:11 +0200 In-Reply-To: <20201002080308.7832bcc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20201001225933.1373426-1-kuba@kernel.org> <20201001173644.74ed67da@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201002074001.3484568a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <1dacbe07dc89cd69342199e61aeead4475f3621c.camel@sipsolutions.net> <20201002075538.2a52dccb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201002080308.7832bcc3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2020-10-02 at 08:03 -0700, Jakub Kicinski wrote: > > Huh, I even CC'ed you I think? > > I filter stuff which is to:netdev cc:me and get to it when I read the > ML. There's too much of it. Ah, ok :) > > Yeah, that'd work. I'd probably wonder if we shouldn't do > > > > [OP_POLICY] > > [OP] -> (u32, u32) > > > > in a struct with two u32's, since that's quite a bit more compact. > > What do we do if the op doesn't have a dump or do callback? > 0 is a valid policy ID, sadly :( Hm, good point. We could do -1 since that can't ever be reached though. But compactness isn't really that necessary here anyway, so ... johannes