All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 07/12] ice: setting and releasing switchdev environment
Date: Mon, 21 Jun 2021 18:21:15 +0000	[thread overview]
Message-ID: <a6a0b9064847e6106cca2ae4a9669b84f4322926.camel@intel.com> (raw)
In-Reply-To: <20210617234413.104069-8-michal.swiatkowski@linux.intel.com>

On Fri, 2021-06-18 at 01:44 +0200, Michal Swiatkowski wrote:
> From: Grzegorz Nitka <grzegorz.nitka@intel.com>
> 
> Switchdev environment has to be set up when user create VFs
> and eswitch mode is switchdev. Release is done when user
> delete all VFs.
> 
> Data path in this implementation is based on control plane VSI.
> This VSI is used to pass traffic from port representors to
> coresponfing VFs and vice versa. Default TX rule has to be
> added to forward packet to control plane VSI. This will redirect
> packets from VFs which don't match other rules to control plane
> VSI.
> 
> On RX site default rule is added on uplink VSI to receive all
> traffic that doesn't match other rules. When setting switchdev
> environment all other rules from VFs should be removed. Packet to
> VFs will be forwarded by control plane VSI.
> 
> As VF without any mac rules can't send any packet because of
> antispoof mechanism, VSI antispoof should be turned off on each VFs.
> 
> To send packet from representor to correct VSI, destintion VSI
> field in TX descriptor will have to be filled. Allow that by
> setting destination override bit in control plane VSI security
> config.
> 
> Packet from VFs will be received on control plane VSI. Driver
> should decide to which netdev forward the packet. Decision is
> made based on src_vsi field from descriptor. There is a target
> netdev list in control plane VSI struct which choose netdev
> based on src_vsi number.
> 
> Co-developed-by: Michal Swiatkowski <
> michal.swiatkowski at linux.intel.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com
> >
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>
> ---

<snip>

> +/**
> + * ice_eswitch_vsi_setup - configure switchdev control VSI
> + * @pf: pointer to PF structure
> + * @pi: pointer to port_info structure
> + */
> +static struct ice_vsi *
> +ice_eswitch_vsi_setup(struct ice_pf *pf, struct ice_port_info *pi)
> +{
> +	return ice_vsi_setup(pf, pi, ICE_VSI_SWITCHDEV_CTRL,
> ICE_INVAL_VFID);

This doesn't build; the switchdev VSI doesn't get introduced until the
next patch. 

drivers/net/ethernet/intel/ice/ice_eswitch.c: In function
ice_eswitch_vsi_setup:
drivers/net/ethernet/intel/ice/ice_eswitch.c:263:31: error:
ICE_VSI_SWITCHDEV_CTRL undeclared (first use in this function)
  263 |  return ice_vsi_setup(pf, pi, ICE_VSI_SWITCHDEV_CTRL,
ICE_INVAL_VFID);
      |                               ^~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_eswitch.c:263:31: note: each
undeclared identifier is reported only once for each function it
appears in
drivers/net/ethernet/intel/ice/ice_eswitch.c:264:1: error: control
reaches end of non-void function [-Werror=return-type]
  264 | }


  reply	other threads:[~2021-06-21 18:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 23:44 [Intel-wired-lan] [PATCH net-next 00/12] Add switchdev driver model for ice driver Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 01/12] ice: basic support for eswitch mode management Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 02/12] ice: Move devlink port to PF/VF struct Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 03/12] ice: introduce VF port representor Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 04/12] ice: allow process vf opcodes in different ways Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 05/12] ice: manage VSI antispoof and destination override Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 06/12] ice: allow changing lan_en and lb_en on dflt rules Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 07/12] ice: setting and releasing switchdev environment Michal Swiatkowski
2021-06-21 18:21   ` Nguyen, Anthony L [this message]
2021-06-22  0:35     ` Michal Swiatkowski
2021-06-22  1:18       ` Michal Swiatkowski
2021-06-22 15:14         ` Nguyen, Anthony L
2021-06-23  1:04           ` Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 08/12] ice: introduce new type of VSI for switchdev Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 09/12] ice: enable/disable switchdev when managing VFs Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 10/12] ice: rebuild switchdev when resetting all VFs Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 11/12] ice: switchdev slow path Michal Swiatkowski
2021-06-17 23:44 ` [Intel-wired-lan] [PATCH net-next 12/12] ice: add port representor ethtool ops and stats Michal Swiatkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6a0b9064847e6106cca2ae4a9669b84f4322926.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.