From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ivanoab7.miniserver.com ([37.128.132.42] helo=www.kot-begemot.co.uk) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjjdq-0007xF-78 for linux-um@lists.infradead.org; Mon, 30 Nov 2020 13:54:59 +0000 Subject: Re: [PATCH 3/7] um: clean up alarm IRQ chip name References: <20201123195621.275470-1-johannes@sipsolutions.net> <20201123205446.d4ce9995bfe5.I782d052498e91373788c1650029d3571a26e4bdf@changeid> From: Anton Ivanov Message-ID: Date: Mon, 30 Nov 2020 13:54:54 +0000 MIME-Version: 1.0 In-Reply-To: <20201123205446.d4ce9995bfe5.I782d052498e91373788c1650029d3571a26e4bdf@changeid> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Johannes Berg , linux-um@lists.infradead.org Cc: Johannes Berg On 23/11/2020 19:56, Johannes Berg wrote: > From: Johannes Berg > > We don't use "SIGVTALRM", it's just SIGALRM. Clean up the naming. > While at it, fix the comment's grammar. > > Signed-off-by: Johannes Berg > --- > arch/um/kernel/irq.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/um/kernel/irq.c b/arch/um/kernel/irq.c > index b94c72f56617..97ff77c297c8 100644 > --- a/arch/um/kernel/irq.c > +++ b/arch/um/kernel/irq.c > @@ -481,7 +481,7 @@ static void dummy(struct irq_data *d) > { > } > > -/* This is used for everything else than the timer. */ > +/* This is used for everything other than the timer. */ > static struct irq_chip normal_irq_type = { > .name = "SIGIO", > .irq_disable = dummy, > @@ -491,8 +491,8 @@ static struct irq_chip normal_irq_type = { > .irq_unmask = dummy, > }; > > -static struct irq_chip SIGVTALRM_irq_type = { > - .name = "SIGVTALRM", > +static struct irq_chip alarm_irq_type = { > + .name = "SIGALRM", > .irq_disable = dummy, > .irq_enable = dummy, > .irq_ack = dummy, > @@ -504,8 +504,7 @@ void __init init_IRQ(void) > { > int i; > > - irq_set_chip_and_handler(TIMER_IRQ, &SIGVTALRM_irq_type, handle_edge_irq); > - > + irq_set_chip_and_handler(TIMER_IRQ, &alarm_irq_type, handle_edge_irq); > > for (i = 1; i < NR_IRQS; i++) > irq_set_chip_and_handler(i, &normal_irq_type, handle_edge_irq); > Acked-By: Anton Ivanov -- Anton R. Ivanov https://www.kot-begemot.co.uk/ _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um